Skip to contentSkip to conversation

fs/dlm/lowcomms-tcp.c: error handling bug

PATCH Adrian Bunk 1 participant 1 message Mar 19, 2007 Distributed lock manager (DLM)

lore
Share & tools
lore
#0 lore raw

The Coverity checker spotted that the following part of commit bd44e2b007bc9024bce3357c185b38c73f87c3dd is obviously bogus:

<-- snip -->

fs/dlm/lowcomms-tcp.c +3 -0
@@ -327,6 +327,9 @@ static int receive_from_sock(struct connection *con)
 
        if (ret <= 0)
                goto out_close;
+       if (ret == -EAGAIN)
+               goto out_resched;
+

...

<-- snip -->

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed