Skip to contentSkip to conversation

drivers/video/aty/atyfb_base.c: array overruns

DISCUSSION Adrian Bunk 3 participants 3 messages Mar 19, 2007 – Mar 31, 2007

lore
Share & tools
lore
#0 lore raw

The Coverity checker spotted the following two array overruns in drivers/video/aty/atyfb_base.c:

<-- snip -->

...

static const u32 lt_lcd_regs[] = {
        CONFIG_PANEL_LG,
        LCD_GEN_CNTL_LG,
        DSTN_CONTROL_LG,
        HFB_PITCH_ADDR_LG,
        HORZ_STRETCHING_LG,
        VERT_STRETCHING_LG,
        0, /* EXT_VERT_STRETCH */
        LT_GIO_LG,
        POWER_MANAGEMENT_LG
};

void aty_st_lcd(int index, u32 val, const struct atyfb_par *par)

{
        if (M64_HAS(LT_LCD_REGS)) {
                aty_st_le32(lt_lcd_regs[index], val, par);

...
}
...
u32 aty_ld_lcd(int index, const struct atyfb_par *par)

{
        if (M64_HAS(LT_LCD_REGS)) {
                return aty_ld_le32(lt_lcd_regs[index], par);

...
}
...
static int aty_bl_update_status(struct backlight_device *bd)

{
        struct atyfb_par *par = class_get_devdata(&bd->class_dev);
        unsigned int reg = aty_ld_lcd(LCD_MISC_CNTL, par);
...
        aty_st_lcd(LCD_MISC_CNTL, reg, par);

        return 0;
}

...

<-- snip -->

LCD_MISC_CNTL = 0x14 = 20 > 8

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#1 lore raw
Quoted 6 lines · Adrian Bunk

The Coverity checker spotted the following two array overruns in drivers/video/aty/atyfb_base.c:

<-- snip -->

...

Quoted 11 lines
static const u32 lt_lcd_regs[] = {
        CONFIG_PANEL_LG,
        LCD_GEN_CNTL_LG,
        DSTN_CONTROL_LG,
        HFB_PITCH_ADDR_LG,
        HORZ_STRETCHING_LG,
        VERT_STRETCHING_LG,
        0, /* EXT_VERT_STRETCH */
        LT_GIO_LG,
        POWER_MANAGEMENT_LG
};

We can pad this array with zeroes, as a stop-gap measure. Ville, what do you think?

Tony

Quoted 33 lines

void aty_st_lcd(int index, u32 val, const struct atyfb_par *par)

{
        if (M64_HAS(LT_LCD_REGS)) {
                aty_st_le32(lt_lcd_regs[index], val, par);

...
}
...
u32 aty_ld_lcd(int index, const struct atyfb_par *par)

{
        if (M64_HAS(LT_LCD_REGS)) {
                return aty_ld_le32(lt_lcd_regs[index], par);

...
}
...
static int aty_bl_update_status(struct backlight_device *bd)

{
        struct atyfb_par *par = class_get_devdata(&bd->class_dev);
        unsigned int reg = aty_ld_lcd(LCD_MISC_CNTL, par);
...
        aty_st_lcd(LCD_MISC_CNTL, reg, par);

        return 0;
}

...

<-- snip -->

LCD_MISC_CNTL = 0x14 = 20 > 8

cu
Adrian

#2 lore raw
Quoted 19 lines · Antonino A. Daplas
Quoted 6 lines · Adrian Bunk

The Coverity checker spotted the following two array overruns in drivers/video/aty/atyfb_base.c:

<-- snip -->

...

Quoted 11 lines
static const u32 lt_lcd_regs[] = {
        CONFIG_PANEL_LG,
        LCD_GEN_CNTL_LG,
        DSTN_CONTROL_LG,
        HFB_PITCH_ADDR_LG,
        HORZ_STRETCHING_LG,
        VERT_STRETCHING_LG,
        0, /* EXT_VERT_STRETCH */
        LT_GIO_LG,
        POWER_MANAGEMENT_LG
};
Quoted 2 lines

We can pad this array with zeroes, as a stop-gap measure. Ville, what do you think?

Actually this array overrun can never happen. LCD_MISC_CNTL is accessed in the in the pmac backlight code and the backlight device is not registered for the Rage LT chip (only user of lt_lcd_regs[]).

Quoted 34 lines
Quoted 33 lines

void aty_st_lcd(int index, u32 val, const struct atyfb_par *par)

{
        if (M64_HAS(LT_LCD_REGS)) {
                aty_st_le32(lt_lcd_regs[index], val, par);

...
}
...
u32 aty_ld_lcd(int index, const struct atyfb_par *par)

{
        if (M64_HAS(LT_LCD_REGS)) {
                return aty_ld_le32(lt_lcd_regs[index], par);

...
}
...
static int aty_bl_update_status(struct backlight_device *bd)

{
        struct atyfb_par *par = class_get_devdata(&bd->class_dev);
        unsigned int reg = aty_ld_lcd(LCD_MISC_CNTL, par);
...
        aty_st_lcd(LCD_MISC_CNTL, reg, par);

        return 0;
}

...

<-- snip -->

LCD_MISC_CNTL = 0x14 = 20 > 8

cu
Adrian

Signature · 3 lines
Ville Syrjälä
[email protected]
http://www.sci.fi/~syrjala/