drivers/video/s3fb.c: fix a use-before-check
PATCH 1/1 drivers/video/s3fb.c: fix a use-before-check
NULL checks should be before the first dereference.
Spotted by the Coverity checker.
Signed-off-by Adrian Bunk <[email protected]>
---
drivers/video/s3fb.c renamed from drivers/video/s3fb.c.old +2 -1
@@ -1000,11 +1000,12 @@ err_enable_device: static void __devexit s3_pci_remove(struct pci_dev *dev) {struct fb_info *info =pci_get_drvdata (dev); -struct s3fb_info *par = info->par;if (info) {#ifdef CONFIG_MTRR +struct s3fb_info *par = info->par; +if (par->mtrr_reg >=0 ) {mtrr_del (par->mtrr_reg,0 ,0 ); par->mtrr_reg =-1 ;
Quoted 5 lines · Adrian Bunk
NULL checks should be before the first dereference.
Spotted by the Coverity checker.
Signed-off-by Adrian Bunk <[email protected]>
Acked-by Ondrej Zajicek <[email protected]>
Signature · 5 lines
Elen sila lumenn' omentielvo Ondrej 'SanTiago' Zajicek (email: [email protected], jabber: [email protected]) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."