Skip to contentSkip to conversation

rivafb: fix initial brightness

PATCH New Guido Guenther 1 participant 1 message Mar 20, 2007 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rivafb: fix initial brightness

Hi,
this is the rivafb equivalent of 238576e12fef1d52751c6e08db2d0bdb0e248caf. It fixes rivafb having a default backlight brightness of 0 (no picture at all) on a PBook 6,1. Since this is a regression over 2.6.20, can this go into 2.6.21? Cheers,
-- Guido

drivers/video/riva/fbdev.c +1 -3
index 1d1c7c6..d7ece8d 100644
@@ -285,8 +285,6 @@ static const struct riva_regs reg_template = {
 #define MAX_LEVEL 0x534
 #define LEVEL_STEP ((MAX_LEVEL - MIN_LEVEL) / FB_BACKLIGHT_MAX)
 
-static struct backlight_properties riva_bl_data;
-
 static int riva_bl_get_level_brightness(struct riva_par *par,
 		int level)
 {
@@ -372,7 +370,7 @@ static void riva_bl_init(struct riva_par *par)
 		FB_BACKLIGHT_MAX);
 
 	bd->props.max_brightness = FB_BACKLIGHT_LEVELS - 1;
-	bd->props.brightness = riva_bl_data.max_brightness;
+	bd->props.brightness = bd->props.max_brightness;
 	bd->props.power = FB_BLANK_UNBLANK;
 	backlight_update_status(bd);