: Sample RTT from SYN exchange

PATCH New Arnaldo Carvalho de Melo 1 participant 1 message Mar 20, 2007

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Arnaldo Carvalho de Melo

author

2007-03-20 23:18 UTC #0 lore raw

PATCH 30/31 : Sample RTT from SYN exchange

Function:
---------
This patch acquires the RTT of the initial SYN (Request/Response) exchange and stores it in an unused field of dccp_sock.

Purpose:
--------
The purpose is primarily to provide an initial RTT sample for CCIDs. CCID 3 in particular benefits from such a sample; using the RTT of the SYN exchange is recommended in an erratum to RFC 4342, and in draft-ietf-dccp-rfc3448bis.

Implementation note:
--------------------
Double use is made of the `icsk_ack.lrcvtime' field by #defining an alias for it. This is justified (1) by exploiting that Acks are only meaningful when the client has reached the OPEN state and the alias is used before reaching this state and
(2) since there is currently no other use for this field in the entire DCCP code. (NB: Since the RTT sample is currently used only by CCID 3, it could be wrapped in Kconfig #ifdef options, but this clutters code and so has not been done.)

Signed-off-by Gerrit Renker <[email protected]>

Signed-off-by Ian McDonald <[email protected]>

Signed-off-by Arnaldo Carvalho de Melo <[email protected]>

---
 include/linux/dccp.h |    2 ++
 net/dccp/input.c     |    8 ++++++++
 net/dccp/options.c   |    8 ++++++++
 3 files changed, 18 insertions(+), 0 deletions(-)

include/linux/dccp.h +2 -0

index fdd4217..e668cf5 100644
@@ -481,10 +481,12 @@ struct dccp_ackvec;
  * @dccps_hc_rx_insert_options -
  * @dccps_hc_tx_insert_options -
  * @dccps_xmit_timer - timer for when CCID is not ready to send
+ * @dccps_syn_rtt - RTT sample from Request/Response exchange (in usecs)
  */
 struct dccp_sock {
 	/* inet_connection_sock has to be the first member of dccp_sock */
 	struct inet_connection_sock	dccps_inet_connection;
+#define dccps_syn_rtt			dccps_inet_connection.icsk_ack.lrcvtime
 	__u64				dccps_swl;
 	__u64				dccps_swh;
 	__u64				dccps_awl;

net/dccp/input.c +8 -0

index bd578c8..da6ec18 100644
@@ -300,6 +300,14 @@ static int dccp_rcv_request_sent_state_process(struct sock *sk,
 		if (dccp_parse_options(sk, skb))
 			goto out_invalid_packet;
 
+		/* Obtain RTT sample from SYN exchange (used by CCID 3) */
+		if (dp->dccps_options_received.dccpor_timestamp_echo) {
+			struct timeval now;
+
+			dccp_timestamp(sk, &now);
+			dp->dccps_syn_rtt = dccp_sample_rtt(sk, &now, NULL);
+		}
+
 		if (dccp_msk(sk)->dccpms_send_ack_vector &&
 		    dccp_ackvec_add(dp->dccps_hc_rx_ackvec, sk,
 				    DCCP_SKB_CB(skb)->dccpd_seq,

net/dccp/options.c +8 -0

index 9074ca7..14b6212 100644
@@ -563,6 +563,14 @@ int dccp_insert_options(struct sock *sk, struct sk_buff *skb)
 	    dccp_insert_options_feat(sk, skb))
 		return -1;
 
+	/*
+	 * Obtain RTT sample from Request/Response exchange.
+	 * This is currently used in CCID 3 initialisation.
+	 */
+	if (DCCP_SKB_CB(skb)->dccpd_type == DCCP_PKT_REQUEST &&
+	    dccp_insert_option_timestamp(sk, skb))
+		return -1;
+
 	/* XXX: insert other options when appropriate */
 
 	if (DCCP_SKB_CB(skb)->dccpd_opt_len != 0) {

Signature · 1 line

1.5.0.3