Do not access the bio after generic_make_request

PATCH In review Olaf Kirch 1 participant 1 message Mar 21, 2007 Device mapper

lore

Share & tools

lore

Olaf Kirch

author

2007-03-21 07:06 UTC #0 lore raw

PATCH 2/3 Do not access the bio after generic_make_request

Do not access the bio after generic_make_request

We should never access a bio after generic_make_request - there's no guarantee it still exists.

Signed-off-by [email protected]

---
 drivers/md/dm-crypt.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

drivers/md/dm-crypt.c +4 -1

Index: linux-2.6.20/drivers/md/dm-crypt.c
===================================================================
@@ -655,9 +655,12 @@ static void process_write(struct crypt_i
 
 		generic_make_request(clone);
 
+		/* Do not reference clone after this - it
+		 * may be gone already. */
+
 		/* out of memory -> run queues */
 		if (remaining)
-			congestion_wait(bio_data_dir(clone), HZ/100);
+			congestion_wait(WRITE, HZ/100);
 	}
 }

Signature · 2 lines

Olaf Kirch  |  --- o --- Nous sommes du soleil we love when we play
[email protected] |    / | \   sol.dhoop.naytheet.ah kin.ir.samse.qurax