Skip to contentSkip to conversation

MSI: Leave MSI-X masking to the irq chip

PATCH Eric W. Biederman 1 participant 1 message Mar 28, 2007 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 4 lines · Michael Ellerman

When freeing an MSI-X in msi_free_irq(), the irq must have already been free'd (otherwise we'd hit the BUG_ON), and in the process will have been masked or otherwise disabled by the irq chip methods. So there's no reason to mask again in the MSI code.

Given the recent discussion about the problems of lazy disable I don't believe the premise of this patch.

Although I suspect the proper solution is to fix free_irq to call ->mask instead of disable. If an irq fires in the forest and no one is listening who cares.

After which point this patch would make sense again.

Eric