Skip to contentSkip to conversation

ALSA initialization still seems to be too late?

PATCH Adrian Bunk 1 participant 1 message Mar 23, 2007 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

The commit below from 2005 (sic) seems to be an example that workarounds often have quite a long lifetime.

Can we get this sorted out properly for 2.6.22?

TIA
Adrian

commit c7ac6b42ffba28c350cbcd48268f46689f6eb1cc

Author: Linus Torvalds <[email protected]>
Date:   Wed Dec 21 14:52:32 2005 -0800

Initialize drivers/media/video/saa7134 late

When compiled-in, make sure the sound system has initialized before these drivers do.

Reported by Adrian Bunk <[email protected]>

(The right fix would be to make the sound core use "subsys_initcall()" and thus initialize before all normal drivers, but this is the quick and limited safe fix for 2.6.15).

drivers/media/video/saa7134/saa7134-alsa.c +2 -1
index 953d5fe..6752dd1 100644
@@ -1028,7 +1028,8 @@ static void saa7134_alsa_exit(void)
 	return;
 }
 
-module_init(saa7134_alsa_init);
+/* We initialize this late, to make sure the sound system is up and running */
+late_initcall(saa7134_alsa_init);
 module_exit(saa7134_alsa_exit);
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Ricardo Cerqueira");
drivers/media/video/saa7134/saa7134-oss.c +2 -1
index 513a699..c450d57 100644
@@ -1002,7 +1002,8 @@ static void saa7134_oss_exit(void)
 	return;
 }
 
-module_init(saa7134_oss_init);
+/* We initialize this late, to make sure the sound system is up and running */
+late_initcall(saa7134_oss_init);
 module_exit(saa7134_oss_exit);
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Gerd Knorr <[email protected]> [SuSE Labs]");