Skip to contentSkip to conversation

: Further reduction of direct access to skb->data

PATCH In review Arnaldo Carvalho de Melo 2 participants 2 messages Mar 24, 2007 – Mar 25, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover : Further reduction of direct access to skb->data

Hi David,

Please take a look, at first I thought about adding a skb_copy_{from,to}_data,
that would do just the memcpy, but then skb_{copy,store}_bits seems to be fit for this purpose, but its more costly in some cases, comments?

Available at:

master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22

- Arnaldo

maintainer
#1 lore raw

From: Arnaldo Carvalho de Melo <[email protected]>
Date: Sat, 24 Mar 2007 18:07:06 -0300

Quoted 10 lines

Hi David,

Please take a look, at first I thought about adding a skb_copy_{from,to}_data,
that would do just the memcpy, but then skb_{copy,store}_bits seems to be fit for this purpose, but its more costly in some cases, comments?

Available at:

master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22

I think you should make the named alias for direct memcpy() instead, call it skb_copy_{from,to}_linear_data() so that the assumed invariant is well documented.