add Attansic L2 PCI ID
Subsystems (3)
PATCH 1/1 add Attansic L2 PCI ID
From: Chris Snook <[email protected]>
Add PCI ID for the Attansic L2 100 Mb ethernet adapter.
include/linux/pci_ids.h +1 -0
@@ -2090,6 +2090,7 @@#define PCI_VENDOR_ID_ATTANSIC 0x1969#define PCI_DEVICE_ID_ATTANSIC_L1 0x1048 +#define PCI_DEVICE_ID_ATTANSIC_L2 0x2048#define PCI_VENDOR_ID_JMICRON 0x197B#define PCI_DEVICE_ID_JMICRON_JMB360 0x2360
include/linux/pci_ids.h line 2093
Quoted 13 lines · Chris Snook
From: Chris Snook <[email protected]>
Add PCI ID for the Attansic L2 100 Mb ethernet adapter.
Signed-off-by Chris Snook <[email protected]>include/linux/pci_ids.h +1
-0@@ -2090,6 +2090,7 @@#define PCI_VENDOR_ID_ATTANSIC 0x1969#define PCI_DEVICE_ID_ATTANSIC_L1 0x1048 +#define PCI_DEVICE_ID_ATTANSIC_L2 0x2048
Actually you should be doing the reverse:
Remove PCI_DEVICE_ID_ATTANSIC_L1, and replace the one place that uses it with the hexadecimal constant.
Jeff
Quoted 19 lines · Jeff Garzik
Quoted 11 lines · Chris Snook
From: Chris Snook <[email protected]>
Add PCI ID for the Attansic L2 100 Mb ethernet adapter.
Signed-off-by Chris Snook <[email protected]>---
linux-2.6.21-rc5.orig/include/linux/pci_ids.h2007-03-27
23:26:50.000000000 -0400
+++linux-2.6.21-rc5/include/linux/pci_ids.h2007-03-28
15:11:03.000000000 -0400include/linux/pci_ids.h line 2093
Quoted 4 lines
include/linux/pci_ids.h +1
-0@@ -2090,6 +2090,7 @@#define PCI_VENDOR_ID_ATTANSIC 0x1969#define PCI_DEVICE_ID_ATTANSIC_L1 0x1048 +#define PCI_DEVICE_ID_ATTANSIC_L2 0x2048Actually you should be doing the reverse:
Quoted 3 lines
Remove
PCI_DEVICE_ID_ATTANSIC_L1, and replace the one place that uses it with the hexadecimal constant.Jeff
We're working on integrating the driver for the L2 chip, so it will be useful to symbolically distinguish between them. For now, adding the ID serves to document the distinction between the L1 and L2 chips, as they're alike enough that an atl1 driver hacked with the new PCI ID will detect link status on the L2, even though it won't really work. By getting the ID in now, we can distribute patches that don't touch core code and won't need to be tweaked for submission.
If pci_ids.h bloat is really a big deal, we can hold off until the L2 patches are ready, but I don't see the harm in getting this out there now.
-- Chris
Quoted 20 lines · Chris Snook
Quoted 19 lines · Jeff Garzik
Quoted 11 lines · Chris Snook
From: Chris Snook <[email protected]>
Add PCI ID for the Attansic L2 100 Mb ethernet adapter.
Signed-off-by Chris Snook <[email protected]>---
linux-2.6.21-rc5.orig/include/linux/pci_ids.h2007-03-27
23:26:50.000000000 -0400
+++linux-2.6.21-rc5/include/linux/pci_ids.h2007-03-28
15:11:03.000000000 -0400include/linux/pci_ids.h line 2093
Quoted 4 lines
include/linux/pci_ids.h +1
-0@@ -2090,6 +2090,7 @@#define PCI_VENDOR_ID_ATTANSIC 0x1969#define PCI_DEVICE_ID_ATTANSIC_L1 0x1048 +#define PCI_DEVICE_ID_ATTANSIC_L2 0x2048Actually you should be doing the reverse:
Quoted 7 lines
Quoted 3 lines
Remove
PCI_DEVICE_ID_ATTANSIC_L1, and replace the one place that uses it with the hexadecimal constant.Jeff
We're working on integrating the driver for the L2 chip, so it will be useful to symbolically distinguish between them. For now, adding the ID serves to document the distinction between the L1 and L2 chips, as they're alike enough that an atl1 driver hacked with the new PCI ID will detect link status on the L2, even though it won't really work. By getting the ID in now, we can distribute patches that don't touch core code and won't need to be tweaked for submission.
If
pci_ids.hbloat is really a big deal, we can hold off until the L2 patches are ready, but I don't see the harm in getting this out there now.
It is current policy that we do not add PCI ID symbols that are only used in one place. It is pointless to add this.
Jeff