Skip to contentSkip to conversation

at91_cf, minor fix

PATCH In review David Brownell 2 participants 2 messages Apr 6, 2007 – Apr 7, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 at91_cf, minor fix

This is a minor correctness fix: since the at91_cf driver probe() routine is in the init section, it should use platform_driver_probe() instead of leaving that pointer around in the driver struct after init section removal.

---
This is a refresh of a patch sent to the linux-pcmcia list on 15-February; it seems that despite the MAINTAINERS file, that's not the place to send patches. (So what good is that list, and why is it in MAINTAINERS?)

drivers/pcmcia/at91_cf.c +1 -2
Index: at91/drivers/pcmcia/at91_cf.c
===================================================================
@@ -360,7 +360,6 @@ static struct platform_driver at91_cf_dr
 		.name		= (char *) driver_name,
 		.owner		= THIS_MODULE,
 	},
-	.probe		= at91_cf_probe,
 	.remove		= __exit_p(at91_cf_remove),
 	.suspend	= at91_cf_suspend,
 	.resume		= at91_cf_resume,
@@ -370,7 +369,7 @@ static struct platform_driver at91_cf_dr
 
 static int __init at91_cf_init(void)
 {
-	return platform_driver_register(&at91_cf_driver);
+	return platform_driver_probe(&at91_cf_driver, at91_cf_probe);
 }
 module_init(at91_cf_init);
 
#1 lore raw
Quoted 3 lines · On Fri, 6 Apr 2007 14:48:47 -0700 David Brownell <[email protected]> wrote:

This is a refresh of a patch sent to the linux-pcmcia list on 15-February; it seems that despite the MAINTAINERS file, that's not the place to send patches. (So what good is that list, and why is it in MAINTAINERS?)

Dominik has been pretty quiet lately - Uni studies, iirc.

Copying me (or lkml) on stuff is always a good way to avoid lossage.