Skip to contentSkip to conversation

ia64: Fix CPU freq displayed in /proc/cpuinfo

PATCH In review Venki Pallipadi 2 participants 3 messages Apr 6, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ia64: Fix CPU freq displayed in /proc/cpuinfo

My patch: git commit•235ca2c20ac0b31a8eb39e2d599bcc3e9c9a10 introduced a bug in IA64 cpuinfo output.

Patch changed the proc_freq from 1HZ resolution to 1KHz resolution, but left format string unchanged at " %lu.%06lu". Below is the fix.

Thanks to Bjorn for catching this.

Index: new/arch/ia64/kernel/setup.c
=================================--- new.orig/arch/ia64/kernel/setup.c 2007-04-02 09:42:37.000000000 -0700
+++ new/arch/ia64/kernel/setup.c 2007-04-06 08:31:23.000000000 -0700
@@ -639,7 +639,7 @@
"features : %s\n"
"cpu number : %lu\n"

 		   "cpu regs   : %u\n"
-		   "cpu MHz    : %lu.%06lu\n"
+		   "cpu MHz    : %lu.%03lu\n"
 		   "itc MHz    : %lu.%06lu\n"
 		   "BogoMIPS   : %lu.%02lu\n",

cpunum, c->vendor, c->family, c->model,

#1 lore raw

+ "cpu MHz : %lu.%03lu\n"
"itc MHz : %lu.%06lu\n"

Why did you cut the precision of cpu MHz back to 1Khz? Is the extra precision not-warranted, or is this just to be more like other architectures?

Should we do the same for itc MHz to treat both evenly?

-Tony

#2 lore raw
In reply to Venki Pallipadi
Quoted 8 lines · Tony
(quoted diff) +1 -0
+		   "cpu MHz    : %lu.%03lu\n"
 		   "itc MHz    : %lu.%06lu\n"

Why did you cut the precision of cpu MHz back to 1Khz? Is the extra precision not-warranted, or is this just to be more like other architectures?

That is because we try to get this from cpufreq and cpufreq has this info in kHz.

Quoted 1 line

Should we do the same for itc MHz to treat both evenly?

Not sure about this. I guess we can retain it the way it is as it is something directly coming from hardware. CPU frequency in turn can come cpufreq or acpi tables. ACPI table will reduce this further as it always gives the info in MHz (on processors that has ACPI based P-states support).

Thanks,
Venki