dont force uclinux mtd map to be root dev
PATCH 1/1 dont force uclinux mtd map to be root dev
the cheesy uclinux mtd maps can be used for more than just the root device, so i think we should drop the forcing. also, i feel like this is a policy decision that shouldnt be in the kernel in the first place. people who have been lazy and boot with uclinux mtd maps and dont put root= into their commandline can simply add the appropriate root= line either into their bootloader or into the compiled in bootargs
---
drivers/mtd/maps/uclinux.c +0 -5
@@ -16,7 +16,6 @@#include <linux/kernel.h> #include <linux/fs.h> #include <linux/major.h> -#include <linux/root_dev.h> #include <linux/mtd/mtd.h> #include <linux/mtd/map.h> #include <linux/mtd/partitions.h>
@@ -89,10 +88,6 @@ int __init uclinux_mtd_init(void) uclinux_ram_mtdinfo = mtd;add_mtd_partitions (mtd, uclinux_romfs,NUM_PARTITIONS ); -printk ("uclinux[mtd]: set %s to be root filesystem\n" , - uclinux_romfs[0 ].name); -ROOT_DEV =MKDEV (MTD_BLOCK_MAJOR ,0 ); -return (0 ); }
Quoted 6 lines · Mike Frysinger
the cheesy uclinux mtd maps can be used for more than just the root device, so i think we should drop the forcing. also, i feel like this is a policy decision that shouldnt be in the kernel in the first place. people who have been lazy and boot with uclinux mtd maps and dont put root= into their commandline can simply add the appropriate root= line either into their bootloader or into the compiled in bootargs
Agreed. I remember trying to get rid of this a while ago, but I can't remember what happened to it.