Basic OMAP2430 High speed I2C & Speed handling (final)

RFC PATCH Syed Mohammed, Khasim 2 participants 2 messages Apr 17, 2007 – Apr 18, 2007 1 message not in the archive

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Syed Mohammed, Khasim

author

2007-04-17 23:19 UTC #1 lore raw

Quoted 1 line

Well you could keep it only for omap1 in device.c.

OK, I will do the following, please correct me if I am wrong.

- I will keep the I2C data structure in plat-omap/device.c under a OMAP1 macro.

- Will remove I2C platform_data structure from mach-omap2/device.c

- Add a platform_data structure and i2c_set_clock() function (similar to n800-usb.c) in

	board-2430sdp.c
	board-h4.c
	board-n800.c
	board-apollon.c

- In I2C driver call the set_clock function to set the clock and speed.

Regards,
Khasim

Quoted 22 lines

-----Original Message-----
From: Tony Lindgren [mailto:[email protected]]
Sent: Tuesday, April 17, 2007 6:12 PM
To: Syed Mohammed, Khasim
Subject: Re: [PATCH / RFC] Basic OMAP2430 High speed I2C & Speed handling (final)
Quoted 7 lines · Syed Mohammed, Khasim
Quoted 5 lines
If the clock and rate can be board specific, then you can board specific i2c_set_clock() function. There are some examples, see board-n800-usb.c for example.
But what should happen to the definitions in device.c? If I remove them
it might break other boards. I am more worried about omap1s.
Quoted 2 lines
Should I still keep device.c one?
Well you could keep it only for omap1 in device.c.
Tony

Tony Lindgren

2007-04-18 00:52 UTC #2 lore raw

Quoted 8 lines · Syed Mohammed, Khasim

Quoted 1 line
Well you could keep it only for omap1 in device.c.
OK, I will do the following, please correct me if I am wrong.
- I will keep the I2C data structure in plat-omap/device.c under a OMAP1 macro.
- Will remove I2C platform_data structure from mach-omap2/device.c

Quoted 7 lines

- Add a platform_data structure and i2c_set_clock() function (similar to n800-usb.c) in
	board-2430sdp.c
	board-h4.c
	board-n800.c
	board-apollon.c
- In I2C driver call the set_clock function to set the clock and speed.

If it's only an issue with 2430, you could still do the I2C init in devices.c for 2420.

Tony