Skip to contentSkip to conversation

Prevent softlockup triggering in nvidiafb

PATCH Dave Jones 3 participants 5 messages Apr 23, 2007 Framebuffer layer

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

If the chip locks up, we get into a long polling loop, where the softlockup detector kicks in.
See https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151878
for an example.

drivers/video/nvidia/nv_accel.c renamed from drivers/video/nvidia/nv_accel.c~ +2 -0
@@ -132,6 +132,8 @@ static void NVDmaWait(struct nvidia_par 
 			}
 		} else
 			par->dmaFree = dmaGet - par->dmaCurrent - 1;
+
+		touch_softlockup_watchdog();
 	}
 
 	if (!count) {
author
#2 lore raw
In reply to Alan Cox
Quoted 10 lines · Alan Cox
Quoted 4 lines · On Mon, 23 Apr 2007 11:36:30 -0400 Dave Jones <[email protected]> wrote:

If the chip locks up, we get into a long polling loop, where the softlockup detector kicks in.
See https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151878
for an example.

Surely in this situation the softlockup report and trap out is precisely what should be occurring.

We can't do anything useful with the trace. It already prints out info that the hardware locked up.

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#3 lore raw
Quoted 7 lines · Alan Cox
Quoted 6 lines
Quoted 3 lines · On Mon, 23 Apr 2007 11:36:30 -0400 Dave Jones <[email protected]> wrote:

If the chip locks up, we get into a long polling loop, where the softlockup detector kicks in.
See https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151878

Quoted 7 lines

for an example.

Quoted 2 lines

Surely in this situation the softlockup report and trap out is

precisely what should be occurring.

We can't do anything useful with the trace. It already prints out info that the hardware locked up.

And when nvidiafb detects a lockup, it will go to safe mode. Better than rebooting, I think.

Tony