Skip to contentSkip to conversation

Last call for bug fixes before 2.6.21-omap1 will be tagged

PATCH In review Tony Lindgren 4 participants 6 messages May 2, 2007 – May 4, 2007

Subsystems (4)
lore
Share & tools
lore

Tony Lindgren

author maintainer
#0 lore raw

Hi all,

I'm planning to tag 2.6.21-omap1 on Friday so let's make sure most of the boards run fine. If you have any pending bug fixes for 2.6.21, now it's time to send them.

Regards,

Tony

#1 lore raw
Quoted 6 lines · Tony Lindgren

Hi all,

I'm planning to tag 2.6.21-omap1 on Friday so let's make sure most of the boards run fine. If you have any pending bug fixes for 2.6.21, now it's time to send them.

OMAP2430 defconfig build failure for USB.

-------------------------snip----------------------------
In file included from drivers/usb/musb/plat_uds.c:109:
drivers/usb/musb/musbdefs.h:67:31: error: asm/arch/hdrc_cnf.h: No such file or directory
drivers/usb/musb/plat_uds.c: In function 'fifo_setup':
drivers/usb/musb/plat_uds.c:944: error: 'MUSB_C_RAM_BITS' undeclared (first use in this function)
drivers/usb/musb/plat_uds.c:944: error: (Each undeclared identifier is reported only once
drivers/usb/musb/plat_uds.c:944: error: for each function it appears in.) drivers/usb/musb/plat_uds.c: In function 'ep_config_from_table':
drivers/usb/musb/plat_uds.c:1068: error: 'MUSB_C_RAM_BITS' undeclared (first use in this function)
make[2]: *** [drivers/usb/musb/plat_uds.o] Error 1
make[1]: *** [drivers/usb/musb] Error 2 -------------------------snip----------------------------

Signature · 1 line
--Trilok Soni
#2 lore raw
Quoted 10 lines · Trilok Soni
Quoted 6 lines · Tony Lindgren

Hi all,

I'm planning to tag 2.6.21-omap1 on Friday so let's make sure most of the boards run fine. If you have any pending bug fixes for 2.6.21, now it's time to send them.

OMAP2430 defconfig build failure for USB.

MUSB should not be enabled in the .config.

MUSB support is not quite ready for the 2430 yet. I have gadget working locally, but have some problems with host mode. Will post patches when I have it working.

Kevin

author maintainer
#3 lore raw
Quoted 9 lines · Kevin Hilman
Quoted 8 lines · Trilok Soni
Quoted 6 lines · Tony Lindgren

Hi all,

I'm planning to tag 2.6.21-omap1 on Friday so let's make sure most of the boards run fine. If you have any pending bug fixes for 2.6.21, now it's time to send them.

Quoted 8 lines
Quoted 2 lines

OMAP2430 defconfig build failure for USB.

MUSB should not be enabled in the .config.

MUSB support is not quite ready for the 2430 yet. I have gadget working locally, but have some problems with host mode. Will post patches when I have it working.

I just posted 7 musb/tusb6010 patches to this list that may help. Patch "Avoid host babble by checking tx fifo" in the series should fix lots of musb host side issues.

Regards,

Tony

#4 lore raw

PATCH 1/1 ARM: OMAP2: Remove redundant check on osc refcount

In reply to Tony Lindgren

The usage of the external oscillator is handled already by sleep_block and doesn't require any extra checking. Incidentally this fixes a bug where N800 wouldn't enter retention the first time the display would blank.

---
 arch/arm/mach-omap2/pm.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/pm.c +0 -2
index b3a0d9d..63e380f 100644
@@ -621,8 +621,6 @@ static int omap2_can_sleep(void)
 		return 0;
 	if (atomic_read(&sleep_block) > 0)
 		return 0;
-	if (clk_get_usecount(osc_ck) > 1)
-		return 0;
 	if (omap_dma_running())
 		return 0;
 
Signature · 1 line
1.5.1.3
author maintainer
#5 lore raw

Re: [PATCH 1/1] ARM: OMAP2: Remove redundant check on osc refcount

Quoted 17 lines · Igor Stoppa

The usage of the external oscillator is handled already by sleep_block and doesn't require any extra checking. Incidentally this fixes a bug where N800 wouldn't enter retention the first time the display would blank.

---
 arch/arm/mach-omap2/pm.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/pm.c +0 -0
index b3a0d9d..63e380f 100644

arch/arm/mach-omap2/pm.c static int omap2_can_sleep(void) · line 626

Quoted 8 lines
arch/arm/mach-omap2/pm.c +0 -2
@@ -621,8 +621,6 @@ static int omap2_can_sleep(void)
 		return 0;
 	if (atomic_read(&sleep_block) > 0)
 		return 0;
-	if (clk_get_usecount(osc_ck) > 1)
-		return 0;
 	if (omap_dma_running())
 		return 0;
 

Thanks, pushing today.

Tony