Skip to contentSkip to conversation

improve scripts/gcc-version.sh output a bit when called without args

PATCH Superseded Jesper Juhl 1 participant 1 message May 7, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 improve scripts/gcc-version.sh output a bit when called without args

Currently, if you call scripts/gcc-version.sh without arguments it will generate this output :

$ sh scripts/gcc-version.sh
scripts/gcc-version.sh: line 17: -E: command not found
scripts/gcc-version.sh: line 18: -E: command not found
0000

Not too pretty. I believe this is an improvement :

$ sh scripts/gcc-version.sh
Error: No compiler specified.
Usage:
        scripts/gcc-version.sh <gcc-command>

as implemented by the patch below.

Not really important, just something I noticed, cleaned up and generated a patch for.
If you like it you can have it. If you hate it just ignore it :)

---

 scripts/gcc-version.sh |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
scripts/gcc-version.sh +6 -0
index bb4fbea..59a03a4 100644
@@ -8,6 +8,12 @@
 
 compiler="$*"
 
+if [ ${#compiler} -eq 0 ]; then
+	echo "Error: No compiler specified."
+	echo -e "Usage:\n\t$0 <gcc-command>"
+	exit 1
+fi
+
 MAJOR=$(echo __GNUC__ | $compiler -E -xc - | tail -n 1)
 MINOR=$(echo __GNUC_MINOR__ | $compiler -E -xc - | tail -n 1)
 printf "%02d%02d\\n" $MAJOR $MINOR