Skip to contentSkip to conversation

sched: teql_enqueue can check limits before skb enqueue

PATCH Applied Krishna Kumar 2 participants 2 messages May 8, 2007 – May 9, 2007

Subsystems (3)
Networking Network drivers Traffic control (tc)
lore
Share & tools
lore

Krishna Kumar

author
#0 lore raw

PATCH 1/1 sched: teql_enqueue can check limits before skb enqueue

Optimize teql_enqueue so that it first checks limits before enqueing.

Patch against net-2.6.22.git

Signed-off-by Krishna Kumar <[email protected]>

---

net/sched/sch_teql.c +2 -3
diff -ruNp org/net/sched/sch_teql.c new/net/sched/sch_teql.c
@@ -94,14 +94,13 @@ teql_enqueue(struct sk_buff *skb, struct
 	struct net_device *dev = sch->dev;
 	struct teql_sched_data *q = qdisc_priv(sch);
 
-	__skb_queue_tail(&q->q, skb);
-	if (q->q.qlen <= dev->tx_queue_len) {
+	if (q->q.qlen < dev->tx_queue_len) {
+		__skb_queue_tail(&q->q, skb);
 		sch->bstats.bytes += skb->len;
 		sch->bstats.packets++;
 		return 0;
 	}
 
-	__skb_unlink(skb, &q->q);
 	kfree_skb(skb);
 	sch->qstats.drops++;
 	return NET_XMIT_DROP;