use mutex instead of semaphore in RocketPort driver
A message that is not in the archive (sent off-list or not yet received): [email protected]
Review end: · line 1780
Quoted 13 lines
(quoted diff) +2
-2- down_interruptible(&info->write_sem); + mutex_lock_interruptible(&info->write_mtx); #ifdef ROCKET_DEBUG_WRITE printk(KERN_INFO "rp_write %d chars...", count);@@ -1773,7 +1776,7 @@ end: wake_up_interruptible(&tty->poll_wait); #endif } - up(&info->write_sem); + mutex_unlock(&info->write_mtx); return retval
this code is very very buggy.
mutex_lock_interruptible() may not get the mutex in case a signal happens... and yet you unlox the mutex unconditionally!!!
El Tue, May 22, 2007 at 09:59:01AM -0700 Arjan van de Ven ha dit:
Quoted 4 lines
Quoted 4 lines
(quoted diff) +1
-1- down_interruptible(&info->write_sem); + mutex_lock_interruptible(&info->write_mtx);
Quoted 11 lines
Review end: · line 1780
Quoted 9 lines
#ifdef
ROCKET_DEBUG_WRITE(quoted diff) +1
-1printk(KERN_INFO "rp_write %d chars...", count);@@ -1773,7 +1776,7 @@ end: wake_up_interruptible(&tty->poll_wait); #endif } - up(&info->write_sem); + mutex_unlock(&info->write_mtx); return retvalthis code is very very buggy.
more buggy than with the use of a semaphore?
Quoted 2 lines
mutex_lock_interruptible()may not get the mutex in case a signal happens... and yet you unlox the mutex unconditionally!!!
as far as i understand only the thread that locked the mutex can unlock it (as opposed to semaphores, which can be released by any thread/process). obviously this doesn't make the code be more correct. what i don't know is how the kernel behaves when trying to unlock a mutex the thread doesn't own. another and possibly more important problem of the code is that in case of being interrupted by a signal the data that should be protected by the mutex/semaphore can be accessed/changed by two threads at the same time.
would the following resolve the problem?
if(mutex_lock_interruptible(&info->write_mtx))
return -ERESTARTSYS
thanks for your comments
Signature · 10 lines
Matthias Kaehlcke
Linux Application Developer
Barcelona
Nothing is more despicable than respect based on fear
(Albert Camus)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-Quoted 3 lines · Matthias Kaehlcke
El Tue, May 22, 2007 at 09:59:01AM -0700 Arjan van de Ven ha dit:
Quoted 1 line
Quoted 1 line
Please provide context when quoting a patch, git grep takes a while...
Quoted 29 lines
Quoted 13 lines
Review end: · line 1780
Quoted 12 lines
(quoted diff) +2
-2- down_interruptible(&info->write_sem); + mutex_lock_interruptible(&info->write_mtx); #ifdef ROCKET_DEBUG_WRITE printk(KERN_INFO "rp_write %d chars...", count);@@ -1773,7 +1776,7 @@ end: wake_up_interruptible(&tty->poll_wait); #endif } - up(&info->write_sem); + mutex_unlock(&info->write_mtx); return retvalthis code is very very buggy.
more buggy than with the use of a semaphore?
Quoted 2 lines
mutex_lock_interruptible()may not get the mutex in case a signal happens... and yet you unlox the mutex unconditionally!!!as far as i understand only the thread that locked the mutex can unlock it (as opposed to semaphores, which can be released by any thread/process). obviously this doesn't make the code be more correct. what i don't know is how the kernel behaves when trying to unlock a mutex the thread doesn't own. another and possibly more important problem of the code is that in case of being interrupted by a signal the data that should be protected by the mutex/semaphore can be accessed/changed by two threads at the same time.
Quoted 7 lines
would the following resolve the problem?
if(mutex_lock_interruptible(&info->write_mtx))
return-ERESTARTSYSthanks for your comments
No. At least one user of tty_operations/tty_driver's write function doesn't check the return value so it would never be retried, mutex_lock should be used instead.
All of the _interruptible and functions that return -ERESTARTSYS should probably use __must_check...
Signature · 1 line
Simon Arlott
Simon Arlott napsal(a):
Quoted 6 lines · Matthias Kaehlcke
Quoted 5 lines
would the following resolve the problem?
if(mutex_lock_interruptible(&info->write_mtx)) return
-ERESTARTSYS
Quoted 6 lines
Quoted 2 lines
thanks for your comments
No. At least one user of tty_operations/tty_driver's write function doesn't check the return value so it would never be retried,
mutex_lockshould be used instead.
Who? There are some drivers that returns ERESTARTSYS from write function.
regards,
Signature · 4 lines
http://www.fi.muni.cz/~xslaby/ Jiri Slaby faculty of informatics, masaryk university, brno, cz e-mail: jirislaby gmail com, gpg pubkey fingerprint: B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E