Skip to contentSkip to conversation

dm crypt: fix avoid cloned bio ref after free

PATCH In review Alasdair G Kergon 1 participant 1 message May 8, 2007 Device mapper

lore
Share & tools
lore

Alasdair G Kergon

author maintainer
#0 lore raw

PATCH 5/26 dm crypt: fix avoid cloned bio ref after free

From: [email protected]

Do not access the bio after generic_make_request

We should never access a bio after generic_make_request - there's no guarantee it still exists.

---

 drivers/md/dm-crypt.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletion(-)
drivers/md/dm-crypt.c +4 -1
Index: linux-2.6.21/drivers/md/dm-crypt.c
===================================================================
@@ -655,9 +655,12 @@ static void process_write(struct crypt_i
 
 		generic_make_request(clone);
 
+		/* Do not reference clone after this - it
+		 * may be gone already. */
+
 		/* out of memory -> run queues */
 		if (remaining)
-			congestion_wait(bio_data_dir(clone), HZ/100);
+			congestion_wait(WRITE, HZ/100);
 	}
 }