Skip to contentSkip to conversation

remove broken URLs from net drivers' output

DISCUSSION Jeff Garzik 3 participants 9 messages May 9, 2007 – May 10, 2007 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 17 lines · Linux Kernel Mailing List
Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2c2a8c531e953c753b06605c8ad6a9161ca527fa
Commit:     2c2a8c531e953c753b06605c8ad6a9161ca527fa
Parent:     b96687768a9ac0fdd005c7700093ebb24b93450f
Author:     Markus Dahms <[email protected]>
AuthorDate: Wed May 9 07:58:10 2007 +0200
Committer:  Adrian Bunk <[email protected]>
CommitDate: Wed May 9 08:58:18 2007 +0200

remove broken URLs from net drivers' output

Remove broken URLs (www.scyld.com) from network drivers' logging output. URLs in comments and other strings are left intact.

Quoted 11 lines
---
 drivers/net/3c509.c     |    5 ++---
 drivers/net/3c59x.c     |    2 +-
 drivers/net/atp.c       |    8 +++-----
 drivers/net/eepro100.c  |    2 +-
 drivers/net/epic100.c   |   10 ++++------
 drivers/net/natsemi.c   |    1 -
 drivers/net/ne2k-pci.c  |    3 +--
 drivers/net/sundance.c  |    3 +--
 drivers/net/yellowfin.c |    1 -
 9 files changed, 13 insertions(+), 22 deletions(-)

Grumble... This stuff should go through my tree.

Jeff

#2 lore raw
Quoted 30 lines · Jeff Garzik
Quoted 17 lines · Linux Kernel Mailing List
Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2c2a8c531e953c753b06605c8ad6a9161ca527fa
Commit:     2c2a8c531e953c753b06605c8ad6a9161ca527fa
Parent:     b96687768a9ac0fdd005c7700093ebb24b93450f
Author:     Markus Dahms <[email protected]>
AuthorDate: Wed May 9 07:58:10 2007 +0200
Committer:  Adrian Bunk <[email protected]>
CommitDate: Wed May 9 08:58:18 2007 +0200

remove broken URLs from net drivers' output

Remove broken URLs (www.scyld.com) from network drivers' logging output. URLs in comments and other strings are left intact.

Quoted 11 lines
---
 drivers/net/3c509.c     |    5 ++---
 drivers/net/3c59x.c     |    2 +-
 drivers/net/atp.c       |    8 +++-----
 drivers/net/eepro100.c  |    2 +-
 drivers/net/epic100.c   |   10 ++++------
 drivers/net/natsemi.c   |    1 -
 drivers/net/ne2k-pci.c  |    3 +--
 drivers/net/sundance.c  |    3 +--
 drivers/net/yellowfin.c |    1 -
 9 files changed, 13 insertions(+), 22 deletions(-)
Quoted 4 lines

Grumble... This stuff should go through my tree.

Jeff

Note, just for the record; I never explicitly added an Acked-by to this patch, I only said in a conversational email that it made sense to me...
I don't actually mind, in this case, to have an Acked-by tagged on with my name, but in general I think that such lines should only be added when people explicitly say Acked-by: John Doe, or something like "Feel free to add my ACK to this" etc.

Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
#3 lore raw
Quoted 38 lines · Jesper Juhl
Quoted 32 lines · Jeff Garzik
Quoted 1 line · Linux Kernel Mailing List

Gitweb:

http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2c2a8c531e953c753b06605c8ad6a9161ca527fa

Quoted 10 lines
Commit:     2c2a8c531e953c753b06605c8ad6a9161ca527fa
Parent:     b96687768a9ac0fdd005c7700093ebb24b93450f
Author:     Markus Dahms <[email protected]>
AuthorDate: Wed May 9 07:58:10 2007 +0200
Committer:  Adrian Bunk <[email protected]>
CommitDate: Wed May 9 08:58:18 2007 +0200

remove broken URLs from net drivers' output

Remove broken URLs (www.scyld.com) from network drivers' logging

output.

Quoted 6 lines

URLs in comments and other strings are left intact.

Quoted 11 lines
---
 drivers/net/3c509.c     |    5 ++---
 drivers/net/3c59x.c     |    2 +-
 drivers/net/atp.c       |    8 +++-----
 drivers/net/eepro100.c  |    2 +-
 drivers/net/epic100.c   |   10 ++++------
 drivers/net/natsemi.c   |    1 -
 drivers/net/ne2k-pci.c  |    3 +--
 drivers/net/sundance.c  |    3 +--
 drivers/net/yellowfin.c |    1 -
 9 files changed, 13 insertions(+), 22 deletions(-)
Quoted 4 lines

Grumble... This stuff should go through my tree.

Jeff

Quoted 7 lines

Note, just for the record; I never explicitly added an Acked-by to this patch, I only said in a conversational email that it made sense to me...
I don't actually mind, in this case, to have an Acked-by tagged on with my name, but in general I think that such lines should only be added when people explicitly say Acked-by: John Doe, or something like "Feel free to add my ACK to this" etc.

Did I miss that "Acked-by:" is considered to be a formal tag like "Signed-off-by:"?

I thought it was just an informal tag to mark which people did agree with the patch (and the line between your "Makes good sense to me." and a "Feel free to add my ACK to this" is really thin).

Quoted 1 line

Jesper Juhl

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#4 lore raw
Quoted 1 line · Adrian Bunk

I thought it was just an informal tag to mark which people did agree with the patch (and the line between your "Makes good sense to me." and a "Feel free to add my ACK to this" is really thin).

No, the line is easy and obvious: if there is any doubt, DO NOT ASSUME.

If they do not explicitly ACK it, then do not presume to speak for them.

Jeff

#5 lore raw
Quoted 8 lines · Jeff Garzik
Quoted 3 lines · Adrian Bunk

I thought it was just an informal tag to mark which people did agree with the patch (and the line between your "Makes good sense to me." and a "Feel free to add my ACK to this" is really thin).

No, the line is easy and obvious: if there is any doubt, DO NOT ASSUME.

If they do not explicitly ACK it, then do not presume to speak for them.

There is no doubt that Jesper did explicitly ACK the patch. We are ONLY discussing whether his informal ACK can be translated into an "Acked-by:" line.

The line I mentioned only exists if "Acked-by:" is considered a formal tag someone must explicitely give, and not an informal indication that someone agrees with the patch. But in this case, we should better require people to give explicit "Acked-by:" lines, like we already require for "Signed-off-by:" lines.

I've seen many cases where people other than me added "Acked-by:" tags when there was only a "Makes good sense to me." or "Fine with me.", but no formal "Acked-by:" given.

If "Acked-by:" should be considered a formal tag, it
- should be documented in Documentation/SubmittingPatches and
- the practice must change to always require people to give a formal "Acked-by:".

Quoted 1 line

Jeff

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#6 lore raw
Quoted 6 lines · Adrian Bunk
Quoted 5 lines · Jeff Garzik
Quoted 3 lines · Adrian Bunk

I thought it was just an informal tag to mark which people did agree with the patch (and the line between your "Makes good sense to me." and a "Feel free to add my ACK to this" is really thin).

Quoted 8 lines
Quoted 3 lines

No, the line is easy and obvious: if there is any doubt, DO NOT ASSUME.

If they do not explicitly ACK it, then do not presume to speak for them.

There is no doubt that Jesper did explicitly ACK the patch. We are ONLY discussing whether his informal ACK can be translated into an "Acked-by:" line.

Right. The patch is fine. What I said when I commented on it was an ACK, that's not being debated.
I just thought that Acked-by: was considered a lot more formal and was surprised to see that line with my name on the patch. But I've since checked up on that assumption and I can't find anything that states that it is considered as formal as I thought it was, so the mistake is all mine and what you did is fine.

If Acked-by: should be made more formal or not is a different discussion.

Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
#7 lore raw
In reply to Jeff Garzik
Quoted 29 lines · Jeff Garzik
Quoted 16 lines · Linux Kernel Mailing List

Gitweb:
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2c2a8c531e953c753b06605c8ad6a9161ca527fa

Commit:     2c2a8c531e953c753b06605c8ad6a9161ca527fa
Parent:     b96687768a9ac0fdd005c7700093ebb24b93450f
Author:     Markus Dahms <[email protected]>
AuthorDate: Wed May 9 07:58:10 2007 +0200
Committer:  Adrian Bunk <[email protected]>
CommitDate: Wed May 9 08:58:18 2007 +0200

remove broken URLs from net drivers' output
Remove broken URLs (www.scyld.com) from network drivers' logging
output.
URLs in comments and other strings are left intact.

Quoted 11 lines
---
 drivers/net/3c509.c     |    5 ++---
 drivers/net/3c59x.c     |    2 +-
 drivers/net/atp.c       |    8 +++-----
 drivers/net/eepro100.c  |    2 +-
 drivers/net/epic100.c   |   10 ++++------
 drivers/net/natsemi.c   |    1 -
 drivers/net/ne2k-pci.c  |    3 +--
 drivers/net/sundance.c  |    3 +--
 drivers/net/yellowfin.c |    1 -
 9 files changed, 13 insertions(+), 22 deletions(-)
Quoted 1 line

Grumble... This stuff should go through my tree.

It had been sent twice to both linux-kernel and netdev, and when going through old linux-kernel emails I considered it trivial enough (people might argue about dead email addresses, but not about dead URLs).

I could send such patches to Andrew for that he includes them in -mm and therefore will include them in his huge list of "forward again and again to the maintainer until there is any reaction" patches.

But IMHO for such trivial patches it's enough if the maintainer had the chance to veto them.

Quoted 1 line

Jeff

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#8 lore raw
Quoted 5 lines · Adrian Bunk

It had been sent twice to both linux-kernel and netdev, and when going through old linux-kernel emails I considered it trivial enough (people might argue about dead email addresses, but not about dead URLs).

I could send such patches to Andrew for that he includes them in -mm and therefore will include them in his huge list of "forward again and again to the maintainer until there is any reaction" patches.

But IMHO for such trivial patches it's enough if the maintainer had the chance to veto them.

Please follow the rule that everybody else follows: send to me and netdev. It's that simple :)

Jeff

#9 lore raw
Quoted 11 lines · Jeff Garzik
Quoted 8 lines · Adrian Bunk

It had been sent twice to both linux-kernel and netdev, and when going through old linux-kernel emails I considered it trivial enough (people might argue about dead email addresses, but not about dead URLs). I could send such patches to Andrew for that he includes them in -mm and therefore will include them in his huge list of "forward again and again to the maintainer until there is any reaction" patches.
But IMHO for such trivial patches it's enough if the maintainer had the chance to veto them.

Quoted 2 lines

Please follow the rule that everybody else follows: send to me and netdev.
It's that simple :)

This doesn't answer the main question:
How often, if there's no maintainer reaction?

It happens that Andrew forwards patches from me in -mm 5 or 10 times to a maintainer until he gets any reaction from the maintainer.

Before I'd start the same with trivial patches, it would be easier to change the "[email protected]" mail alias to point to Andrew so that trivial patches can also become part of his "forward patches to maintainers again and again until there's any reaction" process.

That's not meant as a threat or anything like that, it's a serious suggestion to avoid duplicated work.

Quoted 1 line

Jeff

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed