Skip to contentSkip to conversation

Current git fails to compile on AMD64 for three days in a row

DISCUSSION Florin Iucha 4 participants 4 messages May 10, 2007 – May 11, 2007

lore
Share & tools
lore
#0 lore raw

I just pulled the current git (de5603748af8bf7deac403e6ba92887f8d18e812) and tried to compile it on my AMD64 box, to test Chuck's RPC fix. It fails:

arch/x86_64/kernel/head64.c: In function ‘x86_64_start_kernel’:
arch/x86_64/kernel/head64.c:70: error: size of array ‘type name’ is negative

It is failing in the same way since Monday.

florin

Signature · 2 lines
Bruce Schneier expects the Spanish Inquisition.
      http://geekz.co.uk/schneierfacts/fact/163
#1 lore raw
Quoted 7 lines · Florin Iucha

I just pulled the current git (de5603748af8bf7deac403e6ba92887f8d18e812) and tried to compile it on my AMD64 box, to test Chuck's RPC fix. It fails:

arch/x86_64/kernel/head64.c: In function 'x86_64_start_kernel':
arch/x86_64/kernel/head64.c:70: error: size of array 'type name' is
negative

Multiplying CONFIG_PHYSICAL_START by two in .config should fix it.

#2 lore raw
In reply to Florin Iucha
Quoted 9 lines · On Thu, 10 May 2007 10:16:43 -0500 [email protected] (Florin Iucha) wrote:

I just pulled the current git (de5603748af8bf7deac403e6ba92887f8d18e812) and tried to compile it on my AMD64 box, to test Chuck's RPC fix. It fails:

arch/x86_64/kernel/head64.c: In function ‘x86_64_start_kernel’:
arch/x86_64/kernel/head64.c:70: error: size of array ‘type name’ is negative

It is failing in the same way since Monday.

Yeah, about twelve zillion people are hitting that and none appear to look at the source to work out why it blew up.

I'll fast-track this:

From: Vivek Goyal <[email protected]>

o x86_64 kernel needs to be compiled for 2MB aligned addresses. Currently we are using BUILD_BUG_ON() to warn the user if he has not done so. But looks like folks are not finding message very intutive and don't open the respective c file to find problem source. (Bug 8439)

arch/x86_64/kernel/head64.c: In function 'x86_64_start_kernel':
arch/x86_64/kernel/head64.c:70: error: size of array 'type name' is negative

o Using preprocessor directive #error to print a better message if CONFIG_PHYSICAL_START is not aligned to 2MB boundary.

Cc Andi Kleen <[email protected]>
Cc "Eric W. Biederman" <[email protected]>

---

 arch/x86_64/kernel/head64.c |    7 -------
 include/asm-x86_64/page.h   |    9 +++++++++
 2 files changed, 9 insertions(+), 7 deletions(-)
arch/x86_64/kernel/head64.c renamed from arch/x86_64/kernel/head64.c~x86_64-display-more-intutive-error-message-if-kernel-is-not-2mb-aligned +0 -7
diff -puN arch/x86_64/kernel/head64.c~x86_64-display-more-intutive-error-message-if-kernel-is-not-2mb-aligned arch/x86_64/kernel/head64.c
@@ -62,13 +62,6 @@ void __init x86_64_start_kernel(char * r
 {
 	int i;
 
-	/*
-	 * Make sure kernel is aligned to 2MB address. Catching it at compile
-	 * time is better. Change your config file and compile the kernel
-	 * for a 2MB aligned address (CONFIG_PHYSICAL_START)
-	 */
-	BUILD_BUG_ON(CONFIG_PHYSICAL_START & (__KERNEL_ALIGN - 1));
-
 	/* clear bss before set_intr_gate with early_idt_handler */
 	clear_bss();
 
include/asm-x86_64/page.h renamed from include/asm-x86_64/page.h~x86_64-display-more-intutive-error-message-if-kernel-is-not-2mb-aligned +9 -0
diff -puN include/asm-x86_64/page.h~x86_64-display-more-intutive-error-message-if-kernel-is-not-2mb-aligned include/asm-x86_64/page.h
@@ -80,6 +80,15 @@ extern unsigned long phys_base;
 #define __PHYSICAL_START	CONFIG_PHYSICAL_START
 #define __KERNEL_ALIGN		0x200000
 
+/*
+ * Make sure kernel is aligned to 2MB address. Catching it at compile
+ * time is better. Change your config file and compile the kernel
+ * for a 2MB aligned address (CONFIG_PHYSICAL_START)
+ */
+#if (CONFIG_PHYSICAL_START % __KERNEL_ALIGN) != 0
+#error "CONFIG_PHYSICAL_START must be a multiple of 2MB"
+#endif
+
 #define __START_KERNEL		(__START_KERNEL_map + __PHYSICAL_START)
 #define __START_KERNEL_map	_AC(0xffffffff80000000, UL)
 #define __PAGE_OFFSET           _AC(0xffff810000000000, UL)

_

#3 lore raw
In reply to Florin Iucha
Quoted 8 lines · Florin Iucha

I just pulled the current git (de5603748af8bf7deac403e6ba92887f8d18e812) and tried to compile it on my AMD64 box, to test Chuck's RPC fix. It fails:

arch/x86_64/kernel/head64.c: In function ???x86_64_start_kernel???:
arch/x86_64/kernel/head64.c:70: error: size of array ???type name??? is negative

It is failing in the same way since Monday.

It's a BUILD_BUG_ON -- your relocatable base address in CONFIG needs to be a multiple of 2MB as documented.

There is a patch floating around to turn this into an #error which might be more clear.
-Andi