Correct rp_filter help text.

PATCH Dave Jones 2 participants 2 messages May 17, 2007

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Dave Jones

author

2007-05-17 21:58 UTC #0 lore raw

As mentioned in http://bugzilla.kernel.org/show_bug.cgi?id=5015
The helptext implies that this is on by default.
This may be true on some distros (Fedora/RHEL have it enabled in /etc/sysctl.conf), but the kernel defaults to it off.

Signed-off-by Dave Jones <[email protected]>

net/ipv4/Kconfig +3 -3

index c68196c..420d7a4 100644
@@ -43,11 +43,11 @@ config IP_ADVANCED_ROUTER
 	  asymmetric routing (packets from you to a host take a different path
 	  than packets from that host to you) or if you operate a non-routing
 	  host which has several IP addresses on different interfaces. To turn
-	  rp_filter off use:
+	  rp_filter on use:
 
-	  echo 0 > /proc/sys/net/ipv4/conf/<device>/rp_filter
+	  echo 1 > /proc/sys/net/ipv4/conf/<device>/rp_filter
 	  or
-	  echo 0 > /proc/sys/net/ipv4/conf/all/rp_filter
+	  echo 1 > /proc/sys/net/ipv4/conf/all/rp_filter
 
 	  If unsure, say N here.

Signature · 1 line

http://www.codemonkey.org.uk

David Miller

maintainer

2007-05-17 22:01 UTC #1 lore raw

From: Dave Jones <[email protected]>
Date: Thu, 17 May 2007 17:58:19 -0400

Quoted 6 lines

As mentioned in http://bugzilla.kernel.org/show_bug.cgi?id=5015
The helptext implies that this is on by default.
This may be true on some distros (Fedora/RHEL have it enabled in /etc/sysctl.conf), but the kernel defaults to it off.
Signed-off-by Dave Jones <[email protected]>

Thanks Dave, I'll apply this, thanks.