Skip to contentSkip to conversation

Fix a simple issue w.r.t mounting of containers

PATCH In review Balbir Singh 2 participants 2 messages May 18, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix a simple issue w.r.t mounting of containers

Fix containers mounting issue. With the current v9 patches if a container hierarchy is mounted and then umounted. A second mount of the hierarchy fails

Steps to reproduce the problem

1. mount -t container container /<mnt point>
2. umount /<mnt point>
3. mount -t container container /<mnt point>

Step 3 fails with -EBUSY. This is due to the fact that when we unmount, in container_put_super(), we need to delete the current root from the roots list.

The patch below fixes the issue

---

 kernel/container.c |    1 +
 1 file changed, 1 insertion(+)
kernel/container.c renamed from kernel/container.c~fix-remount-issue +1 -0
diff -puN kernel/container.c~fix-remount-issue kernel/container.c
@@ -574,6 +574,7 @@ static void container_put_super(struct s
 	ret = rebind_subsystems(root, 0);
 	BUG_ON(ret);
 
+	list_del(&root->root_list);
 	kfree(root);
 	mutex_unlock(&container_mutex);
 }

_

Signature · 4 lines
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL
#1 lore raw

Thanks. I've added that to my tree.

Paul

Quoted 44 lines · Balbir Singh

Fix containers mounting issue. With the current v9 patches if a container hierarchy is mounted and then umounted. A second mount of the hierarchy fails

Steps to reproduce the problem

1. mount -t container container /<mnt point>
2. umount /<mnt point>
3. mount -t container container /<mnt point>

Step 3 fails with -EBUSY. This is due to the fact that when we unmount, in container_put_super(), we need to delete the current root from the roots list.

The patch below fixes the issue

---

 kernel/container.c |    1 +
 1 file changed, 1 insertion(+)

diff -puN kernel/container.c~fix-remount-issue kernel/container.c

kernel/container.c 2007-05-18 18:00:02.000000000 +0530 renamed from kernel/container.c~fix-remount-issue 2007-05-18 17:59:40.000000000 +0530 +1 -0
@@ -574,6 +574,7 @@ static void container_put_super(struct s
        ret = rebind_subsystems(root, 0);
        BUG_ON(ret);
 
+       list_del(&root->root_list);
        kfree(root);
        mutex_unlock(&container_mutex);
 }

_

--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL