s390 error: implicit declaration of function sg_dma_len
Current Linus tree does not compile on s390 because esp_scsi references unavailable functions.
/dev/shm/R/linux-2.6.21/drivers/scsi/esp_scsi.c: In function `esp_map_dma':/dev/shm/R/linux-2.6.21/drivers/scsi/esp_scsi.c:338: error: implicit declaration of function sg_dma_len' /dev/shm/R/linux-2.6.21/drivers/scsi/esp_scsi.c: In function esp_cur_dma_addr':/dev/shm/R/linux-2.6.21/drivers/scsi/esp_scsi.c:357: error: implicit declaration of function `sg_dma_address'
From: Olaf Hering <[email protected]>
Date: Fri, 25 May 2007 10:22:38 +0200
Quoted 2 lines
Current Linus tree does not compile on s390 because
esp_scsireferences unavailable functions.
I have a fix for this pending in my sparc-2.6 tree which I'll send to Linus tomorrow, thanks for the report.
PATCH 1/1 s390 error: implicit declaration of function sg_dma_len
In reply to Olaf HeringQuoted 8 lines · Olaf Hering
Current Linus tree does not compile on s390 because
esp_scsireferences unavailable functions.
/dev/shm/R/linux-2.6.21/drivers/scsi/esp_scsi.c: In function `esp_map_dma':/dev/shm/R/linux-2.6.21/drivers/scsi/esp_scsi.c:338: error: implicit declaration of functionsg_dma_len' /dev/shm/R/linux-2.6.21/drivers/scsi/esp_scsi.c: In functionesp_cur_dma_addr':/dev/shm/R/linux-2.6.21/drivers/scsi/esp_scsi.c:357: error: implicit declaration of function `sg_dma_address'
Hmm. Try this:
drivers/scsi/Kconfig +1 -1
@@ -1755,7 +1755,7 @@ config SUN3X_ESP config SCSI_ESP_CORE tristate "ESP Scsi Driver Core" - depends on SCSI + depends on SCSI && !S390 select SCSI_SPI_ATTRS help This is a core driver for NCR53c9x based scsi chipsets,
James, please apply. ESP cards simply don't fit in a mainframe :-)
Cheers,
Hannes
Signature · 8 lines
Dr. Hannes Reinecke zSeries & Storage [email protected] +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Hannes Reinecke <[email protected]>
Date: Fri, 25 May 2007 11:08:08 +0200
Quoted 1 line
James, please apply. ESP cards simply don't fit in a mainframe :-)
No James, please don't, I have a patch in my sparc-2.6 queue which will fix this already, and in a different way.
Quoted 7 lines · David Miller
From: Hannes Reinecke <[email protected]>
Date: Fri, 25 May 2007 11:08:08 +0200Quoted 1 line
James, please apply. ESP cards simply don't fit in a mainframe :-)
No James, please don't, I have a patch in my sparc-2.6 queue which will fix this already, and in a different way.
OK, I won't ... but we're growing users of this base driver now, like this one:
Could you share the updates you're planning with linux-scsi, just so we don't run into problems?
Thanks,
James
From: James Bottomley <[email protected]>
Date: Fri, 25 May 2007 08:47:38 -0500
Quoted 7 lines
OK, I won't ... but we're growing users of this base driver now, like this one:
Could you share the updates you're planning with linux-scsi, just so we don't run into problems?
Only the driver front-end Kconfg's will exist, which will properly check for things like platform and bus type dependencies, and the Makefile goes:
obj-$(FOO_ESP) += esp_core.o foo_esp.o
From: Hannes Reinecke <[email protected]>
Date: Fri, 25 May 2007 11:08:08 +0200
drivers/scsi/Kconfig config SUN3X_ESP · line 1758
Quoted 2 lines
drivers/scsi/Kconfig +1
-1- depends on SCSI + depends on SCSI && !S390
And for the record, the correct test would be HAS_DMA not !S390.