Skip to contentSkip to conversation

Fix broken CLIR in isdn driver

PATCH New Karsten Keil 1 participant 1 message May 29, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix broken CLIR in isdn driver

I noticed that CLIR (aka "hide your calling number") in isdn_tty is broken:
The at-command parser filters out the required "R" (e.g. ATDR089123456) It's been broken for a *very* long time.

---
 drivers/isdn/i4l/isdn_tty.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/isdn/i4l/isdn_tty.c +2 -1
index ea5f30d..4e5f87c 100644
@@ -2693,8 +2693,9 @@ isdn_tty_getdial(char *p, char *q,int cnt)
 	int limit = ISDN_MSNLEN - 1;	/* MUST match the size of interface var to avoid
 					buffer overflow */
 
-	while (strchr(" 0123456789,#.*WPTS-", *p) && *p && --cnt>0) {
+	while (strchr(" 0123456789,#.*WPTSR-", *p) && *p && --cnt>0) {
 		if ((*p >= '0' && *p <= '9') || ((*p == 'S') && first) ||
+		    ((*p == 'R') && first) ||
 		    (*p == '*') || (*p == '#')) {
 			*q++ = *p;
 			limit--;
Signature · 4 lines
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)