Skip to contentSkip to conversation

Mailing patches

DISCUSSION Ralf Baechle 4 participants 10 messages Jun 4, 2007 – Jun 6, 2007 MIPS

lore
Share & tools
lore
#1 lore raw
Quoted 9 lines · Ralf Baechle

I've updated the wiki page on the mechanics of how to mail patches to cover more modern versions of thunderbird or similar:

http://www.linux-mips.org/wiki/Mailing-patches

I'm not a Thunderbird (or Evolution) user myself, so I'd appreciate proofreading and comments.

Ralf

What about just attaching the patches to a message? Seems like it'll avoid most of the problems Tbird has with them. I'm just not sure if that hampers importing them into git or not.

--Kumba

Signature · 3 lines
Gentoo/MIPS Team Lead

"Such is oft the course of deeds that move the wheels of the world: small hands do them because they must, while the eyes of the great are elsewhere."  --Elrond
#2 lore raw
Quoted 5 lines · Kumba

What about just attaching the patches to a message? Seems like it'll avoid most of the problems Tbird has with them. I'm just not sure if that hampers importing them into git or not.

--Kumba

Deeerrr...

Quoted 1 line

6) No MIME, no links, no compression, no attachments. Just plain text.

# dd if=/dev/coffee of=/proc/self/root cpc=135 count=2
2+0 cups in
2+0 cups out
270 milligrams (0.2 g) drank, 0 s, Infinity C/s

--Kumba

Signature · 3 lines
Gentoo/MIPS Team Lead

"Such is oft the course of deeds that move the wheels of the world: small hands do them because they must, while the eyes of the great are elsewhere."  --Elrond
#3 lore raw
Quoted 4 lines · Kumba
# dd if=/dev/coffee of=/proc/self/root cpc=135 count=2
2+0 cups in
2+0 cups out
270 milligrams (0.2 g) drank, 0 s, Infinity C/s

Good idea :-)

Ralf

#4 lore raw
In reply to Kumba
Quoted 3 lines · Kumba

What about just attaching the patches to a message? Seems like it'll avoid most of the problems Tbird has with them. I'm just not sure if that hampers importing them into git or not.

There are issues if people have the log message in the attachment as well. And of course there is still the prime reason why attachments are a no-no - most mailers won't quote them so commenting on them is hard when discussing things.

Git has some limited abilities to handle MIME messages since quite a while though. But quilt which is the heart of how I manage the queue tree doesn't.

Ralf

#5 lore raw

sorry for the mess,when git-format-patch , wo forgot the -n para and i would like to know what command para is recommended for sending patch on maillist?

git-send-email --no-chain-reply-to --compose --from [email protected] --no-signed-off-by-cc --smtp-server <server> --subject "Lemote Loongson 2E patch update" --suppress-from --to [email protected] 00*

--no-chain-reply-to or --chain-reply-to ?

and.....should i resend the patches?

Tian

Quoted 20 lines · Ralf Baechle
Quoted 2 lines · Kumba

What about just attaching the patches to a message? Seems like it'll avoid most of the problems Tbird has with them. I'm just not sure if that hampers importing them into git or not.

There are issues if people have the log message in the attachment as well. And of course there is still the prime reason why attachments are a no-no - most mailers won't quote them so commenting on them is hard when discussing things.

Git has some limited abilities to handle MIME messages since quite a while though. But quilt which is the heart of how I manage the queue tree doesn't.

Ralf

#6 lore raw

Hi,

Quoted 2 lines · Tian

--no-chain-reply-to or --chain-reply-to ?

Usually "--no-chain-reply-to" is used and I think it's easier to discuss on the patchset with this option.

Quoted 2 lines

and.....should i resend the patches?

Does your patchset have order depedency ? if so, I think you should.

Signature · 1 line
              Franck
#7 lore raw

thx for reply

and would it be better if I use --thread when git-format-patch?

Quoted 14 lines · Franck Bui-Huu

Hi,

Quoted 2 lines · Tian

--no-chain-reply-to or --chain-reply-to ?

Usually "--no-chain-reply-to" is used and I think it's easier to discuss on the patchset with this option.

Quoted 2 lines

and.....should i resend the patches?

Does your patchset have order depedency ? if so, I think you should.

#8 lore raw
Quoted 4 lines · Tian

thx for reply

and would it be better if I use --thread when git-format-patch?

Well, since you're using git-send-email with "--compose" and "--no-chain-reply-to" switches, you don't need it. Take a look at git-send-email and git-format-patch man pages, it's well described.

Signature · 1 line
              Franck
#9 lore raw
In reply to Tian
Quoted 11 lines · Tian

sorry for the mess,when git-format-patch , wo forgot the -n para and i would like to know what command para is recommended for sending patch on maillist?

git-send-email --no-chain-reply-to --compose --from [email protected] --no-signed-off-by-cc --smtp-server <server> --subject "Lemote Loongson 2E patch update" --suppress-from --to [email protected] 00*

--no-chain-reply-to or --chain-reply-to ?

and.....should i resend the patches?

No, that's fine.

I don't like --no-chain-reply-to for no better reason than that looking a bit odd in some threded mail readers. But that's just a matter of preference not a technical need.

The ordering of patches is guaranteed even without chain reply mode because git-send-email will ensure the dates of each email is different from the previous one.

Ralf