Skip to contentSkip to conversation

Kconfig.debug DEBUG_PREEMPT dependency

PATCH In review maximilian attems 2 participants 3 messages Jun 6, 2007 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Kconfig.debug DEBUG_PREEMPT dependency

allow to set DEBUG_PREEMPT on PREEMPT_BKL, but !PREEMPT purpose is to get bonus of debug_smp_processor_id().

lib/Kconfig.debug +1 -1
index da95e10..1d4ab66 100644
@@ -145,7 +145,7 @@ config DEBUG_SLAB_LEAK
 
 config DEBUG_PREEMPT
 	bool "Debug preemptible kernel"
-	depends on DEBUG_KERNEL && PREEMPT && TRACE_IRQFLAGS_SUPPORT
+	depends on DEBUG_KERNEL && (PREEMPT || PREEMPT_BKL) && TRACE_IRQFLAGS_SUPPORT
 	default y
 	help
 	  If you say Y here then the kernel will use a debug variant of the
#1 lore raw

lib/Kconfig.debug config DEBUG_SLAB_LEAK · line 148

Quoted 2 lines · maximilian attems
lib/Kconfig.debug +1 -1
-	depends on DEBUG_KERNEL && PREEMPT && TRACE_IRQFLAGS_SUPPORT
+	depends on DEBUG_KERNEL && (PREEMPT || PREEMPT_BKL) && TRACE_IRQFLAGS_SUPPORT

upps please discard needs more work:
arch/i386/kernel/built-in.o: In function `show_registers':
(.text+0x2e8e): undefined reference to add_preempt_count' arch/i386/kernel/built-in.o: In function show_registers':
(.text+0x2e9c): undefined reference to sub_preempt_count' arch/i386/kernel/built-in.o: In function show_registers':
(.text+0x2ef2): undefined reference to add_preempt_count' arch/i386/kernel/built-in.o: In function show_registers':
(.text+0x2f02): undefined reference to sub_preempt_count' arch/i386/kernel/built-in.o: In function is_valid_bugaddr':
(.text+0x366c): undefined reference to add_preempt_count' arch/i386/kernel/built-in.o: In function is_valid_bugaddr':
(.text+0x367b): undefined reference to sub_preempt_count' arch/i386/kernel/built-in.o: In function romchecksum':
...

Signature · 1 line
maks
#2 lore raw
In reply to maximilian attems
Quoted 2 lines · maximilian attems

allow to set DEBUG_PREEMPT on PREEMPT_BKL, but !PREEMPT purpose is to get bonus of debug_smp_processor_id().

hm, have you tested this? In the case of !PREEMPT there will be _lots_ of places that use smp_processor_id() but where the preempt_count() wont be elevated - causing false positive warnings.

Ingo