Skip to contentSkip to conversation

powernow-k8 typos

PATCH In review Joachim Deguara 3 participants 3 messages Jun 8, 2007 – Jun 11, 2007

lore
Share & tools
lore

Joachim Deguara

author
#0 lore raw

PATCH 1/1 powernow-k8 typos

typos fixed

Signed-off-by Joachim.Deguara <[email protected]>
Acked-by Mark Langsdorf <[email protected]>
arch/i386/kernel/cpu/cpufreq/powernow-k8.c +0 -1
Index: 2.6-vanilla/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
===================================================================
@@ -599,7 +599,7 @@ static void print_basics(struct powernow
 	for (j = 0; j < data->numps; j++) {
 		if (data->powernow_table[j].frequency != CPUFREQ_ENTRY_INVALID) {
 			if (cpu_family == CPU_HW_PSTATE) {
-			printk(KERN_INFO PFX "   %d : fid 0x%x gid 0x%x (%d MHz)\n", j,

(data->powernow_table[j].index & 0xff00) >> 8,
+ printk(KERN_INFO PFX " %d : fid 0x%x did 0x%x (%d MHz)\n", j,
(data->powernow_table[j].index & 0xff00) >> 8,
(data->powernow_table[j].index & 0xff0000) >> 16, data->powernow_table[j].frequency/1000);
} else {
@@ -1084,7 +1084,7 @@ static int powernowk8_target(struct cpuf

if (cpu_family == CPU_HW_PSTATE)
dprintk("targ: curr fid 0x%x, did 0x%x\n",
- data->currfid, data->currvid);
+ data->currfid, data->currdid);
else {
dprintk("targ: curr fid 0x%x, vid 0x%x\n", data->currfid, data->currvid);

#1 lore raw
Quoted 10 lines · Joachim Deguara

typos fixed

Signed-off-by Joachim.Deguara <[email protected]>
Acked-by Mark Langsdorf <[email protected]>

Index: 2.6-vanilla/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
===================================================================

arch/i386/kernel/cpu/cpufreq/powernow-k8.c static void print_basics(struct powernow · line 604

Quoted 7 lines
arch/i386/kernel/cpu/cpufreq/powernow-k8.c +1 -1
@@ -599,7 +599,7 @@ static void print_basics(struct powernow
 	for (j = 0; j < data->numps; j++) {
 		if (data->powernow_table[j].frequency != CPUFREQ_ENTRY_INVALID) {
 			if (cpu_family == CPU_HW_PSTATE) {
-			printk(KERN_INFO PFX "   %d : fid 0x%x gid 0x%x (%d MHz)\n", j, 
 (data->powernow_table[j].index & 0xff00) >> 8,
+			printk(KERN_INFO PFX "   %d : fid 0x%x did 0x%x (%d MHz)\n", j, 
 (data->powernow_table[j].index & 0xff00) >> 8,

word-wrapped.
Is also so long it should probably be split over two lines anyway. Also, the printk should be indented by one more tab. (Same for the one in the else arm of this if)

arch/i386/kernel/cpu/cpufreq/powernow-k8.c static int powernowk8_target(struct cpuf · line 1087

Quoted 9 lines
arch/i386/kernel/cpu/cpufreq/powernow-k8.c +0 -0
 				(data->powernow_table[j].index & 0xff0000) >> 16,
arch/i386/kernel/cpu/cpufreq/powernow-k8.c +1 -1
 				data->powernow_table[j].frequency/1000);
 			} else {

@@ -1084,7 +1084,7 @@ static int powernowk8_target(struct cpuf
 
 	if (cpu_family == CPU_HW_PSTATE)
 		dprintk("targ: curr fid 0x%x, did 0x%x\n",
-			data->currfid, data->currvid);
+			data->currfid, data->currdid);

I've been curious for a while.. What is a 'did' ? fid and vid I can figure out, but did has been puzzling me.

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#2 lore raw
Quoted 7 lines
Quoted 2 lines

(data->powernow_table[j].index

& 0xff0000) >> 16,

Quoted 4 lines
(quoted diff) +0 -0
 				data->powernow_table[j].frequency/1000);
 			} else {

@@ -1084,7 +1084,7 @@ static int powernowk8_target(struct cpuf
Quoted 7 lines

Review static int powernowk8_target(struct cpuf · line 1087

Quoted 4 lines
(quoted diff) +1 -1
 	if (cpu_family == CPU_HW_PSTATE)
 		dprintk("targ: curr fid 0x%x, did 0x%x\n",
-			data->currfid, data->currvid);
+			data->currfid, data->currdid);

I've been curious for a while.. What is a 'did' ? fid and vid I can figure out, but did has been puzzling me.

Divisor ID. It's part of a new scheme to allow us to define a much larger range of allowable voltages and frequencies.

-Mark Langsdorf
Operating System Research Center
AMD