Skip to contentSkip to conversation

drivers/isdn/hisax: ARRAY_SIZE instead of sizeof

PATCH In review Andi Drebes 4 participants 9 messages Jun 10, 2007 – Jun 11, 2007 Kernel janitors

lore
Share & tools
lore

Andi Drebes

author
#0 lore raw

PATCH 1/1 drivers/isdn/hisax: ARRAY_SIZE instead of sizeof

This patch replaces various array size calculations in drivers/isdn/hisax done using sizeof with the ARRAY_SIZE macro.

Please CC me when you write comments, because I'm not subscribed to the LKML.

Tested by compilation on an i386 box using "allyesconfig". Diffed against Linus' git-tree.

Signed-off-by Andi Drebes <[email protected]>

---

drivers/isdn/hisax/callc.c +1 -1
index 7c56c44..50b98d5 100644
@@ -834,7 +834,7 @@ static struct FsmNode fnlist[] __initdata  };
 /* *INDENT-ON* */
 
-#define FNCOUNT (sizeof(fnlist)/sizeof(struct FsmNode))
+#define FNCOUNT ARRAY_SIZE(fnlist)
 
 int __init
 CallcNew(void)
drivers/isdn/hisax/isdnl1.c +3 -3
index a14204e..39c749c 100644
@@ -647,7 +647,7 @@ static struct FsmNode L1SFnList[] __initdata  	{ST_L1_F8, EV_TIMER_DEACT, l1_timer_deact},
 };
 
-#define L1S_FN_COUNT (sizeof(L1SFnList)/sizeof(struct FsmNode))
+#define L1S_FN_COUNT ARRAY_SIZE(L1SFnList)
 
 #ifdef HISAX_UINTERFACE
 static void

@@ -706,7 +706,7 @@ static struct FsmNode L1UFnList[] __initdata  	{ST_L1_RESET, EV_TIMER_DEACT, l1_timer_deact},
 };
 
-#define L1U_FN_COUNT (sizeof(L1UFnList)/sizeof(struct FsmNode))
+#define L1U_FN_COUNT ARRAY_SIZE(L1UFnList)
 
 #endif
 

@@ -754,7 +754,7 @@ static struct FsmNode L1BFnList[] __initdata  	{ST_L1_WAIT_DEACT, EV_TIMER_DEACT, l1b_timer_deact},
 };
 
-#define L1B_FN_COUNT (sizeof(L1BFnList)/sizeof(struct FsmNode))
+#define L1B_FN_COUNT ARRAY_SIZE(L1BFnList)
 
 int __init 
 Isdnl1New(void)
drivers/isdn/hisax/isdnl2.c +1 -1
index 3446f24..846a7e6 100644
@@ -1623,7 +1623,7 @@ static struct FsmNode L2FnList[] __initdata  	{ST_L2_8, EV_L1_DEACTIVATE, l2_persistent_da},
 };
 
-#define L2_FN_COUNT (sizeof(L2FnList)/sizeof(struct FsmNode))
+#define L2_FN_COUNT ARRAY_SIZE(L2FnList)
 
 static void
 isdnl2_l1l2(struct PStack *st, int pr, void *arg)
drivers/isdn/hisax/isdnl3.c +1 -1
index 935f233..c081fed 100644
@@ -543,7 +543,7 @@ static struct FsmNode L3FnList[] __initdata  };
 /* *INDENT-ON* */
 
-#define L3_FN_COUNT (sizeof(L3FnList)/sizeof(struct FsmNode))
+#define L3_FN_COUNT ARRAY_SIZE(L3FnList)
 
 void
 l3_msg(struct PStack *st, int pr, void *arg)
drivers/isdn/hisax/l3_1tr6.c +3 -6
index c5c36ee..ff62679 100644
@@ -698,8 +698,7 @@ static struct stateentry downstl[]  	 CC_T308_2, l3_1tr6_t308_2},
 };
 
-#define DOWNSTL_LEN \
-	(sizeof(downstl) / sizeof(struct stateentry))
+#define DOWNSTL_LEN ARRAY_SIZE(downstl)
 
 static struct stateentry datastln1[]  {

@@ -735,8 +734,7 @@ static struct stateentry datastln1[]  	 MT_N1_REL_ACK, l3_1tr6_rel_ack}
 };
 
-#define DATASTLN1_LEN \
-	(sizeof(datastln1) / sizeof(struct stateentry))
+#define DATASTLN1_LEN ARRAY_SIZE(datastln1)
 
 static struct stateentry manstatelist[]  {

@@ -746,8 +744,7 @@ static struct stateentry manstatelist[]           DL_RELEASE | INDICATION, l3_1tr6_dl_release},
 };
  
-#define MANSLLEN \
-        (sizeof(manstatelist) / sizeof(struct stateentry))
+#define MANSLLEN ARRAY_SIZE(manstatelist)
 /* *INDENT-ON* */
 
 static void
drivers/isdn/hisax/l3dss1.c +4 -8
index 99feae8..c434fa5 100644
@@ -2820,8 +2820,7 @@ static struct stateentry downstatelist[]  	 CC_T309, l3dss1_dl_release},
 };
 
-#define DOWNSLLEN \
-	(sizeof(downstatelist) / sizeof(struct stateentry))
+#define DOWNSLLEN ARRAY_SIZE(downstatelist)
 
 static struct stateentry datastatelist[]  {

@@ -2875,8 +2874,7 @@ static struct stateentry datastatelist[]  	 MT_RESUME_REJECT, l3dss1_resume_rej},
 };
 
-#define DATASLLEN \
-	(sizeof(datastatelist) / sizeof(struct stateentry))
+#define DATASLLEN ARRAY_SIZE(datastatelist)
 
 static struct stateentry globalmes_list[]  {

@@ -2888,8 +2886,7 @@ static struct stateentry globalmes_list[]  	 MT_RESTART_ACKNOWLEDGE, l3dss1_restart_ack},
 */
 };
-#define GLOBALM_LEN \
-	(sizeof(globalmes_list) / sizeof(struct stateentry))
+#define GLOBALM_LEN ARRAY_SIZE(globalmes_list)
 
 static struct stateentry manstatelist[]  {

@@ -2903,8 +2900,7 @@ static struct stateentry manstatelist[]           DL_RELEASE | INDICATION, l3dss1_dl_release},
 };
 
-#define MANSLLEN \
-        (sizeof(manstatelist) / sizeof(struct stateentry))
+#define MANSLLEN ARRAY_SIZE(manstatelist)
 /* *INDENT-ON* */
drivers/isdn/hisax/l3ni1.c +4 -8
index f7041d5..ba05ae3 100644
@@ -2755,8 +2755,7 @@ static struct stateentry downstatelist[]  	 CC_TSPID, l3ni1_spid_tout },
 };
 
-#define DOWNSLLEN \
-	(sizeof(downstatelist) / sizeof(struct stateentry))
+#define DOWNSLLEN ARRAY_SIZE(downstatelist)
 
 static struct stateentry datastatelist[]  {

@@ -2810,8 +2809,7 @@ static struct stateentry datastatelist[]  	 MT_RESUME_REJECT, l3ni1_resume_rej},
 };
 
-#define DATASLLEN \
-	(sizeof(datastatelist) / sizeof(struct stateentry))
+#define DATASLLEN ARRAY_SIZE(datastatelist)
 
 static struct stateentry globalmes_list[]  {

@@ -2825,8 +2823,7 @@ static struct stateentry globalmes_list[]  	{ SBIT( 0 ), MT_DL_ESTABLISHED, l3ni1_spid_send },
 	{ SBIT( 20 ) | SBIT( 21 ) | SBIT( 22 ), MT_INFORMATION, l3ni1_spid_epid },
 };
-#define GLOBALM_LEN \
-	(sizeof(globalmes_list) / sizeof(struct stateentry))
+#define GLOBALM_LEN ARRAY_SIZE(globalmes_list)
 
 static struct stateentry manstatelist[]  {

@@ -2840,8 +2837,7 @@ static struct stateentry manstatelist[]           DL_RELEASE | INDICATION, l3ni1_dl_release},
 };
 
-#define MANSLLEN \
-        (sizeof(manstatelist) / sizeof(struct stateentry))
+#define MANSLLEN ARRAY_SIZE(manstatelist)
 /* *INDENT-ON* */
drivers/isdn/hisax/q931.c +1 -1
index aacbf0d..8b853d5 100644
@@ -140,7 +140,7 @@ struct MessageType {
 	}
 };
 
-#define MTSIZE sizeof(mtlist)/sizeof(struct MessageType)
+#define MTSIZE ARRAY_SIZE(mtlist)
 
 static
 struct MessageType mt_n0[] @@ -157,7 +157,7 @@ struct MessageType mt_n0[]  	{MT_N0_CLO_ACK, "CLOse ACKnowledge"}

};

-#define MT_N0_LEN (sizeof(mt_n0) / sizeof(struct MessageType)) +#define MT_N0_LEN ARRAY_SIZE(mt_n0)

static
struct MessageType mt_n1[] @@ -194,7 +194,7 @@ struct MessageType mt_n1[] {MT_N1_STAT, "STATus"}
};

-#define MT_N1_LEN (sizeof(mt_n1) / sizeof(struct MessageType)) +#define MT_N1_LEN ARRAY_SIZE(mt_n1)

static int
@@ -438,7 +438,7 @@ struct CauseValue {
},
};

-#define CVSIZE sizeof(cvlist)/sizeof(struct CauseValue) +#define CVSIZE ARRAY_SIZE(cvlist)

static
int
@@ -516,7 +516,7 @@ struct MessageType cause_1tr6[] {CAUSE_UserInfoDiscarded, "User Info Discarded"}
};

-static int cause_1tr6_len = (sizeof(cause_1tr6) / sizeof(struct MessageType)); +static int cause_1tr6_len = ARRAY_SIZE(cause_1tr6);

static int
prcause_1tr6(char *dest, u_char * p)
@@ -865,7 +865,7 @@ struct DTag { /* Display tags */
{ 0x96, "Redirection name" },
{ 0x9e, "Text" },
};
-#define DTAGSIZE sizeof(dtaglist)/sizeof(struct DTag) +#define DTAGSIZE ARRAY_SIZE(dtaglist)

static int
disptext_ni1(char *dest, u_char * p)
@@ -1074,7 +1074,7 @@ struct InformationElement {
};

-#define IESIZE sizeof(ielist)/sizeof(struct InformationElement) +#define IESIZE ARRAY_SIZE(ielist)

static
struct InformationElement ielist_ni1[] = {
@@ -1102,7 +1102,7 @@ struct InformationElement ielist_ni1[] = {
};

-#define IESIZE_NI1 sizeof(ielist_ni1)/sizeof(struct InformationElement) +#define IESIZE_NI1 ARRAY_SIZE(ielist_ni1)

static
struct InformationElement ielist_ni1_cs5[] = {
@@ -1110,14 +1110,14 @@ struct InformationElement ielist_ni1_cs5[] = {
{ 0x2a, "Display text", disptext_ni1 },
};

-#define IESIZE_NI1_CS5 sizeof(ielist_ni1_cs5)/sizeof(struct InformationElement) +#define IESIZE_NI1_CS5 ARRAY_SIZE(ielist_ni1_cs5)

static
struct InformationElement ielist_ni1_cs6[] = {
{ 0x7b, "Call appearance", general_ni1 },
};

-#define IESIZE_NI1_CS6 sizeof(ielist_ni1_cs6)/sizeof(struct InformationElement) +#define IESIZE_NI1_CS6 ARRAY_SIZE(ielist_ni1_cs6)

static struct InformationElement we_0[] {
@@ -1133,7 +1133,7 @@ static struct InformationElement we_0[] {WE0_userInfo, "User Info", general}
};

-#define WE_0_LEN (sizeof(we_0) / sizeof(struct InformationElement)) +#define WE_0_LEN ARRAY_SIZE(we_0)

static struct InformationElement we_6[] {
@@ -1145,7 +1145,7 @@ static struct InformationElement we_6[] {WE6_statusCalled, "Status Called", general},
{WE6_addTransAttr, "Additional Transmission Attributes", general}
};
-#define WE_6_LEN (sizeof(we_6) / sizeof(struct InformationElement)) +#define WE_6_LEN ARRAY_SIZE(we_6)

int
QuickHex(char *txt, u_char * p, int cnt)

drivers/isdn/hisax/tei.c +1 -1
index ceb0df9..21567af 100644
@@ -447,7 +447,7 @@ static struct FsmNode TeiFnList[] __initdata  	{ST_TEI_IDVERIFY, EV_CHKREQ, tei_id_chk_req},
 };
 
-#define TEI_FN_COUNT (sizeof(TeiFnList)/sizeof(struct FsmNode))
+#define TEI_FN_COUNT ARRAY_SIZE(TeiFnList)
 
 int __init
 TeiNew(void)

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

#1 lore raw

This is OK, thanks for changing.

Quoted 292 lines · Andi Drebes

This patch replaces various array size calculations in drivers/isdn/hisax done using sizeof with the ARRAY_SIZE macro.

Please CC me when you write comments, because I'm not subscribed to the LKML.

Tested by compilation on an i386 box using "allyesconfig". Diffed against Linus' git-tree.

Signed-off-by Andi Drebes <[email protected]>

---

drivers/isdn/hisax/callc.c +1 -1
index 7c56c44..50b98d5 100644
@@ -834,7 +834,7 @@ static struct FsmNode fnlist[] __initdata >  };
 /* *INDENT-ON* */
 
-#define FNCOUNT (sizeof(fnlist)/sizeof(struct FsmNode))
+#define FNCOUNT ARRAY_SIZE(fnlist)
 
 int __init
 CallcNew(void)
drivers/isdn/hisax/isdnl1.c +3 -3
index a14204e..39c749c 100644
@@ -647,7 +647,7 @@ static struct FsmNode L1SFnList[] __initdata >  	{ST_L1_F8, EV_TIMER_DEACT, l1_timer_deact},
 };
 
-#define L1S_FN_COUNT (sizeof(L1SFnList)/sizeof(struct FsmNode))
+#define L1S_FN_COUNT ARRAY_SIZE(L1SFnList)
 
 #ifdef HISAX_UINTERFACE
 static void

@@ -706,7 +706,7 @@ static struct FsmNode L1UFnList[] __initdata >  	{ST_L1_RESET, EV_TIMER_DEACT, l1_timer_deact},
 };
 
-#define L1U_FN_COUNT (sizeof(L1UFnList)/sizeof(struct FsmNode))
+#define L1U_FN_COUNT ARRAY_SIZE(L1UFnList)
 
 #endif
 

@@ -754,7 +754,7 @@ static struct FsmNode L1BFnList[] __initdata >  	{ST_L1_WAIT_DEACT, EV_TIMER_DEACT, l1b_timer_deact},
 };
 
-#define L1B_FN_COUNT (sizeof(L1BFnList)/sizeof(struct FsmNode))
+#define L1B_FN_COUNT ARRAY_SIZE(L1BFnList)
 
 int __init 
 Isdnl1New(void)
drivers/isdn/hisax/isdnl2.c +1 -1
index 3446f24..846a7e6 100644
@@ -1623,7 +1623,7 @@ static struct FsmNode L2FnList[] __initdata >  	{ST_L2_8, EV_L1_DEACTIVATE, l2_persistent_da},
 };
 
-#define L2_FN_COUNT (sizeof(L2FnList)/sizeof(struct FsmNode))
+#define L2_FN_COUNT ARRAY_SIZE(L2FnList)
 
 static void
 isdnl2_l1l2(struct PStack *st, int pr, void *arg)
drivers/isdn/hisax/isdnl3.c +1 -1
index 935f233..c081fed 100644
@@ -543,7 +543,7 @@ static struct FsmNode L3FnList[] __initdata >  };
 /* *INDENT-ON* */
 
-#define L3_FN_COUNT (sizeof(L3FnList)/sizeof(struct FsmNode))
+#define L3_FN_COUNT ARRAY_SIZE(L3FnList)
 
 void
 l3_msg(struct PStack *st, int pr, void *arg)
drivers/isdn/hisax/l3_1tr6.c +3 -6
index c5c36ee..ff62679 100644
@@ -698,8 +698,7 @@ static struct stateentry downstl[] >  	 CC_T308_2, l3_1tr6_t308_2},
 };
 
-#define DOWNSTL_LEN \
-	(sizeof(downstl) / sizeof(struct stateentry))
+#define DOWNSTL_LEN ARRAY_SIZE(downstl)
 
 static struct stateentry datastln1[] >  {

@@ -735,8 +734,7 @@ static struct stateentry datastln1[] >  	 MT_N1_REL_ACK, l3_1tr6_rel_ack}
 };
 
-#define DATASTLN1_LEN \
-	(sizeof(datastln1) / sizeof(struct stateentry))
+#define DATASTLN1_LEN ARRAY_SIZE(datastln1)
 
 static struct stateentry manstatelist[] >  {

@@ -746,8 +744,7 @@ static struct stateentry manstatelist[] >           DL_RELEASE | INDICATION, l3_1tr6_dl_release},
 };
 
-#define MANSLLEN \
-        (sizeof(manstatelist) / sizeof(struct stateentry))
+#define MANSLLEN ARRAY_SIZE(manstatelist)
 /* *INDENT-ON* */
 
 static void
drivers/isdn/hisax/l3dss1.c +4 -8
index 99feae8..c434fa5 100644
@@ -2820,8 +2820,7 @@ static struct stateentry downstatelist[] >  	 CC_T309, l3dss1_dl_release},
 };
 
-#define DOWNSLLEN \
-	(sizeof(downstatelist) / sizeof(struct stateentry))
+#define DOWNSLLEN ARRAY_SIZE(downstatelist)
 
 static struct stateentry datastatelist[] >  {

@@ -2875,8 +2874,7 @@ static struct stateentry datastatelist[] >  	 MT_RESUME_REJECT, l3dss1_resume_rej},
 };
 
-#define DATASLLEN \
-	(sizeof(datastatelist) / sizeof(struct stateentry))
+#define DATASLLEN ARRAY_SIZE(datastatelist)
 
 static struct stateentry globalmes_list[] >  {

@@ -2888,8 +2886,7 @@ static struct stateentry globalmes_list[] >  	 MT_RESTART_ACKNOWLEDGE, l3dss1_restart_ack},
 */
 };
-#define GLOBALM_LEN \
-	(sizeof(globalmes_list) / sizeof(struct stateentry))
+#define GLOBALM_LEN ARRAY_SIZE(globalmes_list)
 
 static struct stateentry manstatelist[] >  {

@@ -2903,8 +2900,7 @@ static struct stateentry manstatelist[] >           DL_RELEASE | INDICATION, l3dss1_dl_release},
 };
 
-#define MANSLLEN \
-        (sizeof(manstatelist) / sizeof(struct stateentry))
+#define MANSLLEN ARRAY_SIZE(manstatelist)
 /* *INDENT-ON* */
drivers/isdn/hisax/l3ni1.c +4 -8
index f7041d5..ba05ae3 100644
@@ -2755,8 +2755,7 @@ static struct stateentry downstatelist[] >  	 CC_TSPID, l3ni1_spid_tout },
 };
 
-#define DOWNSLLEN \
-	(sizeof(downstatelist) / sizeof(struct stateentry))
+#define DOWNSLLEN ARRAY_SIZE(downstatelist)
 
 static struct stateentry datastatelist[] >  {

@@ -2810,8 +2809,7 @@ static struct stateentry datastatelist[] >  	 MT_RESUME_REJECT, l3ni1_resume_rej},
 };
 
-#define DATASLLEN \
-	(sizeof(datastatelist) / sizeof(struct stateentry))
+#define DATASLLEN ARRAY_SIZE(datastatelist)
 
 static struct stateentry globalmes_list[] >  {

@@ -2825,8 +2823,7 @@ static struct stateentry globalmes_list[] >  	{ SBIT( 0 ), MT_DL_ESTABLISHED, l3ni1_spid_send },
 	{ SBIT( 20 ) | SBIT( 21 ) | SBIT( 22 ), MT_INFORMATION, l3ni1_spid_epid },
 };
-#define GLOBALM_LEN \
-	(sizeof(globalmes_list) / sizeof(struct stateentry))
+#define GLOBALM_LEN ARRAY_SIZE(globalmes_list)
 
 static struct stateentry manstatelist[] >  {

@@ -2840,8 +2837,7 @@ static struct stateentry manstatelist[] >           DL_RELEASE | INDICATION, l3ni1_dl_release},
 };
 
-#define MANSLLEN \
-        (sizeof(manstatelist) / sizeof(struct stateentry))
+#define MANSLLEN ARRAY_SIZE(manstatelist)
 /* *INDENT-ON* */
drivers/isdn/hisax/q931.c +1 -1
index aacbf0d..8b853d5 100644
@@ -140,7 +140,7 @@ struct MessageType {
 	}
 };
 
-#define MTSIZE sizeof(mtlist)/sizeof(struct MessageType)
+#define MTSIZE ARRAY_SIZE(mtlist)
 
 static
 struct MessageType mt_n0[] > @@ -157,7 +157,7 @@ struct MessageType mt_n0[] >  	{MT_N0_CLO_ACK, "CLOse ACKnowledge"}

};

drivers/isdn/hisax/q931.c +11 -11
-#define MT_N0_LEN (sizeof(mt_n0) / sizeof(struct MessageType))
+#define MT_N0_LEN ARRAY_SIZE(mt_n0)
 
 static
 struct MessageType mt_n1[] > @@ -194,7 +194,7 @@ struct MessageType mt_n1[] >  	{MT_N1_STAT, "STATus"}
 };
 
-#define MT_N1_LEN (sizeof(mt_n1) / sizeof(struct MessageType))
+#define MT_N1_LEN ARRAY_SIZE(mt_n1)
 
 
 static int

@@ -438,7 +438,7 @@ struct CauseValue {
 	},
 };
 
-#define CVSIZE sizeof(cvlist)/sizeof(struct CauseValue)
+#define CVSIZE ARRAY_SIZE(cvlist)
 
 static
 int

@@ -516,7 +516,7 @@ struct MessageType cause_1tr6[] >  	{CAUSE_UserInfoDiscarded, "User Info Discarded"}
 };
 
-static int cause_1tr6_len = (sizeof(cause_1tr6) / sizeof(struct MessageType));
+static int cause_1tr6_len = ARRAY_SIZE(cause_1tr6);
 
 static int
 prcause_1tr6(char *dest, u_char * p)

@@ -865,7 +865,7 @@ struct DTag { /* Display tags */
 	{ 0x96, "Redirection name" },
 	{ 0x9e, "Text" },
 };
-#define DTAGSIZE sizeof(dtaglist)/sizeof(struct DTag)
+#define DTAGSIZE ARRAY_SIZE(dtaglist)
 
 static int
 disptext_ni1(char *dest, u_char * p)

@@ -1074,7 +1074,7 @@ struct InformationElement {
 };
 
 
-#define IESIZE sizeof(ielist)/sizeof(struct InformationElement)
+#define IESIZE ARRAY_SIZE(ielist)
 
 static
 struct InformationElement ielist_ni1[] = {

@@ -1102,7 +1102,7 @@ struct InformationElement ielist_ni1[] = {
 };
 
 
-#define IESIZE_NI1 sizeof(ielist_ni1)/sizeof(struct InformationElement)
+#define IESIZE_NI1 ARRAY_SIZE(ielist_ni1)
 
 static
 struct InformationElement ielist_ni1_cs5[] = {

@@ -1110,14 +1110,14 @@ struct InformationElement ielist_ni1_cs5[] = {
 	{ 0x2a, "Display text", disptext_ni1 },
 };
 
-#define IESIZE_NI1_CS5 sizeof(ielist_ni1_cs5)/sizeof(struct InformationElement)
+#define IESIZE_NI1_CS5 ARRAY_SIZE(ielist_ni1_cs5)
 
 static
 struct InformationElement ielist_ni1_cs6[] = {
 	{ 0x7b, "Call appearance", general_ni1 },
 };
 
-#define IESIZE_NI1_CS6 sizeof(ielist_ni1_cs6)/sizeof(struct InformationElement)
+#define IESIZE_NI1_CS6 ARRAY_SIZE(ielist_ni1_cs6)
 
 static struct InformationElement we_0[] >  {

@@ -1133,7 +1133,7 @@ static struct InformationElement we_0[] >  	{WE0_userInfo, "User Info", general}
 };
 
-#define WE_0_LEN (sizeof(we_0) / sizeof(struct InformationElement))
+#define WE_0_LEN ARRAY_SIZE(we_0)
 
 static struct InformationElement we_6[] >  {

@@ -1145,7 +1145,7 @@ static struct InformationElement we_6[] >  	{WE6_statusCalled, "Status Called", general},
 	{WE6_addTransAttr, "Additional Transmission Attributes", general}
 };
-#define WE_6_LEN (sizeof(we_6) / sizeof(struct InformationElement))
+#define WE_6_LEN ARRAY_SIZE(we_6)
 
 int
 QuickHex(char *txt, u_char * p, int cnt)
drivers/isdn/hisax/tei.c +1 -1
index ceb0df9..21567af 100644
@@ -447,7 +447,7 @@ static struct FsmNode TeiFnList[] __initdata >  	{ST_TEI_IDVERIFY, EV_CHKREQ, tei_id_chk_req},
 };
 
-#define TEI_FN_COUNT (sizeof(TeiFnList)/sizeof(struct FsmNode))
+#define TEI_FN_COUNT ARRAY_SIZE(TeiFnList)
 
 int __init
 TeiNew(void)
Signature · 8 lines
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
#2 lore raw
Quoted 6 lines · Karsten Keil
Quoted 6 lines
drivers/isdn/hisax/callc.c +0 -0
@@ -834,7 +834,7 @@ static struct FsmNode fnlist[] __initdata =
 };
 /* *INDENT-ON* */
Quoted 7 lines

drivers/isdn/hisax/callc.c static struct FsmNode fnlist[] __initdata }; · line 839

Quoted 5 lines
drivers/isdn/hisax/callc.c +1 -1
-#define FNCOUNT (sizeof(fnlist)/sizeof(struct FsmNode))
+#define FNCOUNT ARRAY_SIZE(fnlist)
 
 int __init
 CallcNew(void)

This is OK, thanks for changing.

I'd suggest to not use another define, but use ARRAY_SIZE(foo) _instead of_ eg. FNCOUNT.

MfG, JBG

Signature · 4 lines
      Jan-Benedict Glaw      [email protected]              +49-172-7608481
Signature of:           Ich hatte in letzter Zeit ein bißchen viel Realitycheck.
the second  :               Langsam möchte ich mal wieder weiterträumen können.
                             -- Maximilian Wilhelm (18. Mai 2006, #lug-owl.de)

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

author
#3 lore raw
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/isdn/hisax/callc.c +1 -1
@@ -834,7 +834,7 @@ static struct FsmNode fnlist[] __initdata > > >  };
 /* *INDENT-ON* */
 
-#define FNCOUNT (sizeof(fnlist)/sizeof(struct FsmNode))
+#define FNCOUNT ARRAY_SIZE(fnlist)
Quoted 7 lines
Quoted 4 lines

drivers/isdn/hisax/callc.c static struct FsmNode fnlist[] __initdata > > > }; · line 839

Quoted 2 lines
drivers/isdn/hisax/callc.c +0 -0
 int __init
 CallcNew(void)

This is OK, thanks for changing.

I'd suggest to not use another define, but use ARRAY_SIZE(foo) _instead of_ eg. FNCOUNT.

I thought of this, too, but I tried to keep things consistent. Let me explain that a little bit more in detail. If you have a look at the files in drivers/isdn/hisax then you will see that a lot of array size definitions are assigned to preprocessor macros. So I thought removing just one of the macros while the other continue to exist would make the code a little bit more inconsistent. However, one might disagree about that. So here's another patch that includes the changes from the original patch and removes the FNCOUNT preprocessor definition. Perhaps the original authors of the files should decide wether they want to keep it or not.

Tested by compilation on an i386 box using "allyesconfig". Diffed against Linus' git-tree.

Signed-off-by Andi Drebes <[email protected]>

---

drivers/isdn/hisax/callc.c +1 -3
index 7c56c44..0b9ed8e 100644
@@ -834,8 +834,6 @@ static struct FsmNode fnlist[] __initdata  };
 /* *INDENT-ON* */
 
-#define FNCOUNT (sizeof(fnlist)/sizeof(struct FsmNode))
-
 int __init
 CallcNew(void)
 {

@@ -843,7 +841,7 @@ CallcNew(void)
 	callcfsm.event_count = EVENT_COUNT;
 	callcfsm.strEvent = strEvent;
 	callcfsm.strState = strState;
-	return FsmNew(&callcfsm, fnlist, FNCOUNT);
+	return FsmNew(&callcfsm, fnlist, ARRAY_SIZE(fnlist));
 }
 
 void
drivers/isdn/hisax/isdnl1.c +3 -3
index a14204e..39c749c 100644
@@ -647,7 +647,7 @@ static struct FsmNode L1SFnList[] __initdata  	{ST_L1_F8, EV_TIMER_DEACT, l1_timer_deact},
 };
 
-#define L1S_FN_COUNT (sizeof(L1SFnList)/sizeof(struct FsmNode))
+#define L1S_FN_COUNT ARRAY_SIZE(L1SFnList)
 
 #ifdef HISAX_UINTERFACE
 static void

@@ -706,7 +706,7 @@ static struct FsmNode L1UFnList[] __initdata  	{ST_L1_RESET, EV_TIMER_DEACT, l1_timer_deact},
 };
 
-#define L1U_FN_COUNT (sizeof(L1UFnList)/sizeof(struct FsmNode))
+#define L1U_FN_COUNT ARRAY_SIZE(L1UFnList)
 
 #endif
 

@@ -754,7 +754,7 @@ static struct FsmNode L1BFnList[] __initdata  	{ST_L1_WAIT_DEACT, EV_TIMER_DEACT, l1b_timer_deact},
 };
 
-#define L1B_FN_COUNT (sizeof(L1BFnList)/sizeof(struct FsmNode))
+#define L1B_FN_COUNT ARRAY_SIZE(L1BFnList)
 
 int __init 
 Isdnl1New(void)
drivers/isdn/hisax/isdnl2.c +1 -1
index 3446f24..846a7e6 100644
@@ -1623,7 +1623,7 @@ static struct FsmNode L2FnList[] __initdata  	{ST_L2_8, EV_L1_DEACTIVATE, l2_persistent_da},
 };
 
-#define L2_FN_COUNT (sizeof(L2FnList)/sizeof(struct FsmNode))
+#define L2_FN_COUNT ARRAY_SIZE(L2FnList)
 
 static void
 isdnl2_l1l2(struct PStack *st, int pr, void *arg)
drivers/isdn/hisax/isdnl3.c +1 -1
index 935f233..c081fed 100644
@@ -543,7 +543,7 @@ static struct FsmNode L3FnList[] __initdata  };
 /* *INDENT-ON* */
 
-#define L3_FN_COUNT (sizeof(L3FnList)/sizeof(struct FsmNode))
+#define L3_FN_COUNT ARRAY_SIZE(L3FnList)
 
 void
 l3_msg(struct PStack *st, int pr, void *arg)
drivers/isdn/hisax/l3_1tr6.c +3 -6
index c5c36ee..ff62679 100644
@@ -698,8 +698,7 @@ static struct stateentry downstl[]  	 CC_T308_2, l3_1tr6_t308_2},
 };
 
-#define DOWNSTL_LEN \
-	(sizeof(downstl) / sizeof(struct stateentry))
+#define DOWNSTL_LEN ARRAY_SIZE(downstl)
 
 static struct stateentry datastln1[]  {

@@ -735,8 +734,7 @@ static struct stateentry datastln1[]  	 MT_N1_REL_ACK, l3_1tr6_rel_ack}
 };
 
-#define DATASTLN1_LEN \
-	(sizeof(datastln1) / sizeof(struct stateentry))
+#define DATASTLN1_LEN ARRAY_SIZE(datastln1)
 
 static struct stateentry manstatelist[]  {

@@ -746,8 +744,7 @@ static struct stateentry manstatelist[]           DL_RELEASE | INDICATION, l3_1tr6_dl_release},
 };
  
-#define MANSLLEN \
-        (sizeof(manstatelist) / sizeof(struct stateentry))
+#define MANSLLEN ARRAY_SIZE(manstatelist)
 /* *INDENT-ON* */
 
 static void
drivers/isdn/hisax/l3dss1.c +4 -8
index 99feae8..c434fa5 100644
@@ -2820,8 +2820,7 @@ static struct stateentry downstatelist[]  	 CC_T309, l3dss1_dl_release},
 };
 
-#define DOWNSLLEN \
-	(sizeof(downstatelist) / sizeof(struct stateentry))
+#define DOWNSLLEN ARRAY_SIZE(downstatelist)
 
 static struct stateentry datastatelist[]  {

@@ -2875,8 +2874,7 @@ static struct stateentry datastatelist[]  	 MT_RESUME_REJECT, l3dss1_resume_rej},
 };
 
-#define DATASLLEN \
-	(sizeof(datastatelist) / sizeof(struct stateentry))
+#define DATASLLEN ARRAY_SIZE(datastatelist)
 
 static struct stateentry globalmes_list[]  {

@@ -2888,8 +2886,7 @@ static struct stateentry globalmes_list[]  	 MT_RESTART_ACKNOWLEDGE, l3dss1_restart_ack},
 */
 };
-#define GLOBALM_LEN \
-	(sizeof(globalmes_list) / sizeof(struct stateentry))
+#define GLOBALM_LEN ARRAY_SIZE(globalmes_list)
 
 static struct stateentry manstatelist[]  {

@@ -2903,8 +2900,7 @@ static struct stateentry manstatelist[]           DL_RELEASE | INDICATION, l3dss1_dl_release},
 };
 
-#define MANSLLEN \
-        (sizeof(manstatelist) / sizeof(struct stateentry))
+#define MANSLLEN ARRAY_SIZE(manstatelist)
 /* *INDENT-ON* */
drivers/isdn/hisax/l3ni1.c +4 -8
index f7041d5..ba05ae3 100644
@@ -2755,8 +2755,7 @@ static struct stateentry downstatelist[]  	 CC_TSPID, l3ni1_spid_tout },
 };
 
-#define DOWNSLLEN \
-	(sizeof(downstatelist) / sizeof(struct stateentry))
+#define DOWNSLLEN ARRAY_SIZE(downstatelist)
 
 static struct stateentry datastatelist[]  {

@@ -2810,8 +2809,7 @@ static struct stateentry datastatelist[]  	 MT_RESUME_REJECT, l3ni1_resume_rej},
 };
 
-#define DATASLLEN \
-	(sizeof(datastatelist) / sizeof(struct stateentry))
+#define DATASLLEN ARRAY_SIZE(datastatelist)
 
 static struct stateentry globalmes_list[]  {

@@ -2825,8 +2823,7 @@ static struct stateentry globalmes_list[]  	{ SBIT( 0 ), MT_DL_ESTABLISHED, l3ni1_spid_send },
 	{ SBIT( 20 ) | SBIT( 21 ) | SBIT( 22 ), MT_INFORMATION, l3ni1_spid_epid },
 };
-#define GLOBALM_LEN \
-	(sizeof(globalmes_list) / sizeof(struct stateentry))
+#define GLOBALM_LEN ARRAY_SIZE(globalmes_list)
 
 static struct stateentry manstatelist[]  {

@@ -2840,8 +2837,7 @@ static struct stateentry manstatelist[]           DL_RELEASE | INDICATION, l3ni1_dl_release},
 };
 
-#define MANSLLEN \
-        (sizeof(manstatelist) / sizeof(struct stateentry))
+#define MANSLLEN ARRAY_SIZE(manstatelist)
 /* *INDENT-ON* */
drivers/isdn/hisax/q931.c +1 -1
index aacbf0d..8b853d5 100644
@@ -140,7 +140,7 @@ struct MessageType {
 	}
 };
 
-#define MTSIZE sizeof(mtlist)/sizeof(struct MessageType)
+#define MTSIZE ARRAY_SIZE(mtlist)
 
 static
 struct MessageType mt_n0[] @@ -157,7 +157,7 @@ struct MessageType mt_n0[]  	{MT_N0_CLO_ACK, "CLOse ACKnowledge"}

};

-#define MT_N0_LEN (sizeof(mt_n0) / sizeof(struct MessageType)) +#define MT_N0_LEN ARRAY_SIZE(mt_n0)

static
struct MessageType mt_n1[] @@ -194,7 +194,7 @@ struct MessageType mt_n1[] {MT_N1_STAT, "STATus"}
};

-#define MT_N1_LEN (sizeof(mt_n1) / sizeof(struct MessageType)) +#define MT_N1_LEN ARRAY_SIZE(mt_n1)

static int
@@ -438,7 +438,7 @@ struct CauseValue {
},
};

-#define CVSIZE sizeof(cvlist)/sizeof(struct CauseValue) +#define CVSIZE ARRAY_SIZE(cvlist)

static
int
@@ -516,7 +516,7 @@ struct MessageType cause_1tr6[] {CAUSE_UserInfoDiscarded, "User Info Discarded"}
};

-static int cause_1tr6_len = (sizeof(cause_1tr6) / sizeof(struct MessageType)); +static int cause_1tr6_len = ARRAY_SIZE(cause_1tr6);

static int
prcause_1tr6(char *dest, u_char * p)
@@ -865,7 +865,7 @@ struct DTag { /* Display tags */
{ 0x96, "Redirection name" },
{ 0x9e, "Text" },
};
-#define DTAGSIZE sizeof(dtaglist)/sizeof(struct DTag) +#define DTAGSIZE ARRAY_SIZE(dtaglist)

static int
disptext_ni1(char *dest, u_char * p)
@@ -1074,7 +1074,7 @@ struct InformationElement {
};

-#define IESIZE sizeof(ielist)/sizeof(struct InformationElement) +#define IESIZE ARRAY_SIZE(ielist)

static
struct InformationElement ielist_ni1[] = {
@@ -1102,7 +1102,7 @@ struct InformationElement ielist_ni1[] = {
};

-#define IESIZE_NI1 sizeof(ielist_ni1)/sizeof(struct InformationElement) +#define IESIZE_NI1 ARRAY_SIZE(ielist_ni1)

static
struct InformationElement ielist_ni1_cs5[] = {
@@ -1110,14 +1110,14 @@ struct InformationElement ielist_ni1_cs5[] = {
{ 0x2a, "Display text", disptext_ni1 },
};

-#define IESIZE_NI1_CS5 sizeof(ielist_ni1_cs5)/sizeof(struct InformationElement) +#define IESIZE_NI1_CS5 ARRAY_SIZE(ielist_ni1_cs5)

static
struct InformationElement ielist_ni1_cs6[] = {
{ 0x7b, "Call appearance", general_ni1 },
};

-#define IESIZE_NI1_CS6 sizeof(ielist_ni1_cs6)/sizeof(struct InformationElement) +#define IESIZE_NI1_CS6 ARRAY_SIZE(ielist_ni1_cs6)

static struct InformationElement we_0[] {
@@ -1133,7 +1133,7 @@ static struct InformationElement we_0[] {WE0_userInfo, "User Info", general}
};

-#define WE_0_LEN (sizeof(we_0) / sizeof(struct InformationElement)) +#define WE_0_LEN ARRAY_SIZE(we_0)

static struct InformationElement we_6[] {
@@ -1145,7 +1145,7 @@ static struct InformationElement we_6[] {WE6_statusCalled, "Status Called", general},
{WE6_addTransAttr, "Additional Transmission Attributes", general}
};
-#define WE_6_LEN (sizeof(we_6) / sizeof(struct InformationElement)) +#define WE_6_LEN ARRAY_SIZE(we_6)

int
QuickHex(char *txt, u_char * p, int cnt)

drivers/isdn/hisax/tei.c +1 -1
index ceb0df9..21567af 100644
@@ -447,7 +447,7 @@ static struct FsmNode TeiFnList[] __initdata  	{ST_TEI_IDVERIFY, EV_CHKREQ, tei_id_chk_req},
 };
 
-#define TEI_FN_COUNT (sizeof(TeiFnList)/sizeof(struct FsmNode))
+#define TEI_FN_COUNT ARRAY_SIZE(TeiFnList)
 
 int __init
 TeiNew(void)

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

#4 lore raw

G'day Andi,

Quoted 11 lines · Andi Drebes
Quoted 2 lines

I'd suggest to not use another define, but use ARRAY_SIZE(foo) _instead of_ eg. FNCOUNT.

I thought of this, too, but I tried to keep things consistent. Let me explain that a little bit more in detail. If you have a look at the files in drivers/isdn/hisax then you will see that a lot of array size definitions are assigned to preprocessor macros. So I thought removing just one of the macros while the other continue to exist would make the code a little bit more inconsistent. However, one might disagree about that. So here's another patch that includes the changes from the original patch and removes the FNCOUNT preprocessor definition. Perhaps the original authors of the files should decide wether they want to keep it or not.

I think what was meant here was to remove _all_ the macros that you assigned to the ARRAY_SIZE() macro.

If you look at the two advantages replacing code with the ARRAY_SIZE() macro has;
1. More readable/consistent code.
2. Faster compile times, because of less macros being defined.

If you were to simply redefine other macro's to be an ARRAY_SIZE() macro, the code will still contain the original macro's that people will have to look up, so would _not_ be more readable/consistent and you now have two stages of macro replacement, so the code will actually take _longer_ to compile.

So to get the benefit of this change you have to _remove_ all the macros that are somehow equivalent to ARRAY_SIZE(), and replace their use in the code, with an appropriate ARRAY_SIZE() usage.

Darren J.
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

#5 lore raw
Quoted 17 lines · Darren Jenkins

G'day Andi,

Quoted 12 lines · Andi Drebes
Quoted 2 lines

I'd suggest to not use another define, but use ARRAY_SIZE(foo) _instead of_ eg. FNCOUNT.

I thought of this, too, but I tried to keep things consistent. Let me explain that a little bit more in detail. If you have a look at the files in drivers/isdn/hisax then you will see that a lot of array size definitions
are assigned to preprocessor macros. So I thought removing just one of the macros while the other continue to exist would make the code a little bit more inconsistent. However, one might disagree about that. So here's another patch that includes the changes from the original patch and removes the FNCOUNT preprocessor definition. Perhaps the original authors of the files should decide wether they want to keep it or not.

Quoted 3 lines

I think what was meant here was to remove _all_ the macros that you assigned to the ARRAY_SIZE() macro.

...

Agree, here is a new version.

This patch replaces various array size calculations in drivers/isdn/hisax done using sizeof with the ARRAY_SIZE macro.

Signed-off-by Karsten Keil <[email protected]>
Signed-off-by Andi Drebes <[email protected]>
---
 drivers/isdn/hisax/callc.c   |    4 +--
 drivers/isdn/hisax/isdnl1.c  |   12 ++-----
 drivers/isdn/hisax/isdnl2.c  |    4 +--
 drivers/isdn/hisax/isdnl3.c  |    4 +--
 drivers/isdn/hisax/l3_1tr6.c |   20 +++--------
 drivers/isdn/hisax/l3dss1.c  |   26 ++++----------
 drivers/isdn/hisax/l3ni1.c   |   24 ++++---------
 drivers/isdn/hisax/q931.c    |   77 ++++++++++++++---------------------------
 drivers/isdn/hisax/tei.c     |    4 +--
 9 files changed, 55 insertions(+), 120 deletions(-)
drivers/isdn/hisax/callc.c +1 -3
index 7c56c44..0b9ed8e 100644
@@ -834,8 +834,6 @@ static struct FsmNode fnlist[] __initdata  };
 /* *INDENT-ON* */
 
-#define FNCOUNT (sizeof(fnlist)/sizeof(struct FsmNode))
-
 int __init
 CallcNew(void)
 {

@@ -843,7 +841,7 @@ CallcNew(void)
 	callcfsm.event_count = EVENT_COUNT;
 	callcfsm.strEvent = strEvent;
 	callcfsm.strState = strState;
-	return FsmNew(&callcfsm, fnlist, FNCOUNT);
+	return FsmNew(&callcfsm, fnlist, ARRAY_SIZE(fnlist));
 }
 
 void
drivers/isdn/hisax/isdnl1.c +3 -9
index a14204e..80e923e 100644
@@ -647,8 +647,6 @@ static struct FsmNode L1SFnList[] __initdata  	{ST_L1_F8, EV_TIMER_DEACT, l1_timer_deact},
 };
 
-#define L1S_FN_COUNT (sizeof(L1SFnList)/sizeof(struct FsmNode))
-
 #ifdef HISAX_UINTERFACE
 static void
 l1_deact_req_u(struct FsmInst *fi, int event, void *arg)

@@ -706,8 +704,6 @@ static struct FsmNode L1UFnList[] __initdata  	{ST_L1_RESET, EV_TIMER_DEACT, l1_timer_deact},
 };
 
-#define L1U_FN_COUNT (sizeof(L1UFnList)/sizeof(struct FsmNode))
-
 #endif
 
 static void

@@ -754,8 +750,6 @@ static struct FsmNode L1BFnList[] __initdata  	{ST_L1_WAIT_DEACT, EV_TIMER_DEACT, l1b_timer_deact},
 };
 
-#define L1B_FN_COUNT (sizeof(L1BFnList)/sizeof(struct FsmNode))
-
 int __init 
 Isdnl1New(void)
 {

@@ -765,7 +759,7 @@ Isdnl1New(void)
 	l1fsm_s.event_count = L1_EVENT_COUNT;
 	l1fsm_s.strEvent = strL1Event;
 	l1fsm_s.strState = strL1SState;
-	retval = FsmNew(&l1fsm_s, L1SFnList, L1S_FN_COUNT);
+	retval = FsmNew(&l1fsm_s, L1SFnList, ARRAY_SIZE(L1SFnList));
 	if (retval)
 		return retval;
 

@@ -773,7 +767,7 @@ Isdnl1New(void)
 	l1fsm_b.event_count = L1_EVENT_COUNT;
 	l1fsm_b.strEvent = strL1Event;
 	l1fsm_b.strState = strL1BState;
-	retval = FsmNew(&l1fsm_b, L1BFnList, L1B_FN_COUNT);
+	retval = FsmNew(&l1fsm_b, L1BFnList, ARRAY_SIZE(L1BFnList));
 	if (retval) {
 		FsmFree(&l1fsm_s);
 		return retval;

@@ -783,7 +777,7 @@ Isdnl1New(void)
 	l1fsm_u.event_count = L1_EVENT_COUNT;
 	l1fsm_u.strEvent = strL1Event;
 	l1fsm_u.strState = strL1UState;
-	retval = FsmNew(&l1fsm_u, L1UFnList, L1U_FN_COUNT);
+	retval = FsmNew(&l1fsm_u, L1UFnList, ARRAY_SIZE(L1UFnList));
 	if (retval) {
 		FsmFree(&l1fsm_s);
 		FsmFree(&l1fsm_b);
drivers/isdn/hisax/isdnl2.c +1 -3
index 3446f24..7b9496a 100644
@@ -1623,8 +1623,6 @@ static struct FsmNode L2FnList[] __initdata  	{ST_L2_8, EV_L1_DEACTIVATE, l2_persistent_da},
 };
 
-#define L2_FN_COUNT (sizeof(L2FnList)/sizeof(struct FsmNode))
-
 static void
 isdnl2_l1l2(struct PStack *st, int pr, void *arg)
 {

@@ -1836,7 +1834,7 @@ Isdnl2New(void)
 	l2fsm.event_count = L2_EVENT_COUNT;
 	l2fsm.strEvent = strL2Event;
 	l2fsm.strState = strL2State;
-	return FsmNew(&l2fsm, L2FnList, L2_FN_COUNT);
+	return FsmNew(&l2fsm, L2FnList, ARRAY_SIZE(L2FnList));
 }
 
 void
drivers/isdn/hisax/isdnl3.c +1 -3
index 935f233..0676602 100644
@@ -543,8 +543,6 @@ static struct FsmNode L3FnList[] __initdata  };
 /* *INDENT-ON* */
 
-#define L3_FN_COUNT (sizeof(L3FnList)/sizeof(struct FsmNode))
-
 void
 l3_msg(struct PStack *st, int pr, void *arg)
 {

@@ -587,7 +585,7 @@ Isdnl3New(void)
 	l3fsm.event_count = L3_EVENT_COUNT;
 	l3fsm.strEvent = strL3Event;
 	l3fsm.strState = strL3State;
-	return FsmNew(&l3fsm, L3FnList, L3_FN_COUNT);
+	return FsmNew(&l3fsm, L3FnList, ARRAY_SIZE(L3FnList));
 }
 
 void
drivers/isdn/hisax/l3_1tr6.c +6 -14
index c5c36ee..b0554f8 100644
@@ -698,9 +698,6 @@ static struct stateentry downstl[]  	 CC_T308_2, l3_1tr6_t308_2},
 };
 
-#define DOWNSTL_LEN \
-	(sizeof(downstl) / sizeof(struct stateentry))
-
 static struct stateentry datastln1[]  {
 	{SBIT(0),

@@ -735,9 +732,6 @@ static struct stateentry datastln1[]  	 MT_N1_REL_ACK, l3_1tr6_rel_ack}
 };
 
-#define DATASTLN1_LEN \
-	(sizeof(datastln1) / sizeof(struct stateentry))
-
 static struct stateentry manstatelist[]  {
         {SBIT(2),

@@ -746,8 +740,6 @@ static struct stateentry manstatelist[]           DL_RELEASE | INDICATION, l3_1tr6_dl_release},
 };
  
-#define MANSLLEN \
-        (sizeof(manstatelist) / sizeof(struct stateentry))
 /* *INDENT-ON* */
 
 static void

@@ -840,11 +832,11 @@ up1tr6(struct PStack *st, int pr, void *arg)
 				mt = MT_N1_INVALID;
 			}
 		}
-		for (i = 0; i < DATASTLN1_LEN; i++)
+		for (i = 0; i < ARRAY_SIZE(datastln1); i++)
 			if ((mt = datastln1[i].primitive) &&
 			    ((1 << proc->state) & datastln1[i].state))
 				break;
-		if (i = DATASTLN1_LEN) {
+		if (i = ARRAY_SIZE(datastln1)) {
 			dev_kfree_skb(skb);
 			if (st->l3.debug & L3_DEB_STATE) {
 				sprintf(tmp, "up1tr6%sstate %d mt %x unhandled",

@@ -892,11 +884,11 @@ down1tr6(struct PStack *st, int pr, void *arg)
 		proc = arg;
 	}
 
-	for (i = 0; i < DOWNSTL_LEN; i++)
+	for (i = 0; i < ARRAY_SIZE(downstl); i++)
 		if ((pr = downstl[i].primitive) &&
 		    ((1 << proc->state) & downstl[i].state))
 			break;
-	if (i = DOWNSTL_LEN) {
+	if (i = ARRAY_SIZE(downstl)) {
 		if (st->l3.debug & L3_DEB_STATE) {
 			sprintf(tmp, "down1tr6 state %d prim %d unhandled",
 				proc->state, pr);

@@ -922,11 +914,11 @@ man1tr6(struct PStack *st, int pr, void *arg)
                 printk(KERN_ERR "HiSax man1tr6 without proc pr=%04x\n", pr);
                 return;
         }
-        for (i = 0; i < MANSLLEN; i++)
+        for (i = 0; i < ARRAY_SIZE(manstatelist); i++)
                 if ((pr = manstatelist[i].primitive) &&
                     ((1 << proc->state) & manstatelist[i].state))
                         break;
-        if (i = MANSLLEN) {
+        if (i = ARRAY_SIZE(manstatelist)) {
                 if (st->l3.debug & L3_DEB_STATE) {
                         l3_debug(st, "cr %d man1tr6 state %d prim %d unhandled",
                                 proc->callref & 0x7f, proc->state, pr);
drivers/isdn/hisax/l3dss1.c +8 -18
index 99feae8..a12fa4d 100644
@@ -2820,9 +2820,6 @@ static struct stateentry downstatelist[]  	 CC_T309, l3dss1_dl_release},
 };
 
-#define DOWNSLLEN \
-	(sizeof(downstatelist) / sizeof(struct stateentry))
-
 static struct stateentry datastatelist[]  {
 	{ALL_STATES,

@@ -2875,9 +2872,6 @@ static struct stateentry datastatelist[]  	 MT_RESUME_REJECT, l3dss1_resume_rej},
 };
 
-#define DATASLLEN \
-	(sizeof(datastatelist) / sizeof(struct stateentry))
-
 static struct stateentry globalmes_list[]  {
 	{ALL_STATES,

@@ -2888,8 +2882,6 @@ static struct stateentry globalmes_list[]  	 MT_RESTART_ACKNOWLEDGE, l3dss1_restart_ack},
 */
 };
-#define GLOBALM_LEN \
-	(sizeof(globalmes_list) / sizeof(struct stateentry))
 
 static struct stateentry manstatelist[]  {

@@ -2903,8 +2895,6 @@ static struct stateentry manstatelist[]           DL_RELEASE | INDICATION, l3dss1_dl_release},
 };
 
-#define MANSLLEN \
-        (sizeof(manstatelist) / sizeof(struct stateentry))
 /* *INDENT-ON* */
 
 

@@ -2918,11 +2908,11 @@ global_handler(struct PStack *st, int mt, struct sk_buff *skb)
 	struct l3_process *proc = st->l3.global;
 
 	proc->callref = skb->data[2]; /* cr flag */
-	for (i = 0; i < GLOBALM_LEN; i++)
+	for (i = 0; i < ARRAY_SIZE(globalmes_list); i++)
 		if ((mt = globalmes_list[i].primitive) &&
 		    ((1 << proc->state) & globalmes_list[i].state))
 			break;
-	if (i = GLOBALM_LEN) {
+	if (i = ARRAY_SIZE(globalmes_list)) {
 		if (st->l3.debug & L3_DEB_STATE) {
 			l3_debug(st, "dss1 global state %d mt %x unhandled",
 				proc->state, mt);

@@ -3097,11 +3087,11 @@ dss1up(struct PStack *st, int pr, void *arg)
 	}
 	if ((p = findie(skb->data, skb->len, IE_DISPLAY, 0)) != NULL) 
 	  l3dss1_deliver_display(proc, pr, p); /* Display IE included */
-	for (i = 0; i < DATASLLEN; i++)
+	for (i = 0; i < ARRAY_SIZE(datastatelist); i++)
 		if ((mt = datastatelist[i].primitive) &&
 		    ((1 << proc->state) & datastatelist[i].state))
 			break;
-	if (i = DATASLLEN) {
+	if (i = ARRAY_SIZE(datastatelist)) {
 		if (st->l3.debug & L3_DEB_STATE) {
 			l3_debug(st, "dss1up%sstate %d mt %#x unhandled",
 				(pr = (DL_DATA | INDICATION)) ? " " : "(broadcast) ",

@@ -3156,11 +3146,11 @@ dss1down(struct PStack *st, int pr, void *arg)
 		return;
 	}  
 
-	for (i = 0; i < DOWNSLLEN; i++)
+	for (i = 0; i < ARRAY_SIZE(downstatelist); i++)
 		if ((pr = downstatelist[i].primitive) &&
 		    ((1 << proc->state) & downstatelist[i].state))
 			break;
-	if (i = DOWNSLLEN) {
+	if (i = ARRAY_SIZE(downstatelist)) {
 		if (st->l3.debug & L3_DEB_STATE) {
 			l3_debug(st, "dss1down state %d prim %#x unhandled",
 				proc->state, pr);

@@ -3184,11 +3174,11 @@ dss1man(struct PStack *st, int pr, void *arg)
                 printk(KERN_ERR "HiSax dss1man without proc pr=%04x\n", pr);
                 return;
         }
-        for (i = 0; i < MANSLLEN; i++)
+        for (i = 0; i < ARRAY_SIZE(manstatelist); i++)
                 if ((pr = manstatelist[i].primitive) &&
                     ((1 << proc->state) & manstatelist[i].state))
                         break;
-        if (i = MANSLLEN) {
+        if (i = ARRAY_SIZE(manstatelist)) {
                 if (st->l3.debug & L3_DEB_STATE) {
                         l3_debug(st, "cr %d dss1man state %d prim %#x unhandled",
                                 proc->callref & 0x7f, proc->state, pr);
drivers/isdn/hisax/l3ni1.c +8 -16
index f7041d5..b6d35ee 100644
@@ -2755,9 +2755,6 @@ static struct stateentry downstatelist[]  	 CC_TSPID, l3ni1_spid_tout },
 };
 
-#define DOWNSLLEN \
-	(sizeof(downstatelist) / sizeof(struct stateentry))
-
 static struct stateentry datastatelist[]  {
 	{ALL_STATES,

@@ -2810,9 +2807,6 @@ static struct stateentry datastatelist[]  	 MT_RESUME_REJECT, l3ni1_resume_rej},
 };
 
-#define DATASLLEN \
-	(sizeof(datastatelist) / sizeof(struct stateentry))
-
 static struct stateentry globalmes_list[]  {
 	{ALL_STATES,

@@ -2825,8 +2819,6 @@ static struct stateentry globalmes_list[]  	{ SBIT( 0 ), MT_DL_ESTABLISHED, l3ni1_spid_send },
 	{ SBIT( 20 ) | SBIT( 21 ) | SBIT( 22 ), MT_INFORMATION, l3ni1_spid_epid },
 };
-#define GLOBALM_LEN \
-	(sizeof(globalmes_list) / sizeof(struct stateentry))
 
 static struct stateentry manstatelist[]  {

@@ -2858,11 +2850,11 @@ global_handler(struct PStack *st, int mt, struct sk_buff *skb)
 		proc->callref = skb->data[2]; /* cr flag */
 	else
 		proc->callref = 0;
-	for (i = 0; i < GLOBALM_LEN; i++)
+	for (i = 0; i < ARRAY_SIZE(globalmes_list); i++)
 		if ((mt = globalmes_list[i].primitive) &&
 		    ((1 << proc->state) & globalmes_list[i].state))
 			break;
-	if (i = GLOBALM_LEN) {
+	if (i = ARRAY_SIZE(globalmes_list)) {
 		if (st->l3.debug & L3_DEB_STATE) {
 			l3_debug(st, "ni1 global state %d mt %x unhandled",
 				proc->state, mt);

@@ -3049,11 +3041,11 @@ ni1up(struct PStack *st, int pr, void *arg)
 	}
 	if ((p = findie(skb->data, skb->len, IE_DISPLAY, 0)) != NULL) 
 	  l3ni1_deliver_display(proc, pr, p); /* Display IE included */
-	for (i = 0; i < DATASLLEN; i++)
+	for (i = 0; i < ARRAY_SIZE(datastatelist); i++)
 		if ((mt = datastatelist[i].primitive) &&
 		    ((1 << proc->state) & datastatelist[i].state))
 			break;
-	if (i = DATASLLEN) {
+	if (i = ARRAY_SIZE(datastatelist)) {
 		if (st->l3.debug & L3_DEB_STATE) {
 			l3_debug(st, "ni1up%sstate %d mt %#x unhandled",
 				(pr = (DL_DATA | INDICATION)) ? " " : "(broadcast) ",

@@ -3108,11 +3100,11 @@ ni1down(struct PStack *st, int pr, void *arg)
 		return;
 	}  
 
-	for (i = 0; i < DOWNSLLEN; i++)
+	for (i = 0; i < ARRAY_SIZE(downstatelist); i++)
 		if ((pr = downstatelist[i].primitive) &&
 		    ((1 << proc->state) & downstatelist[i].state))
 			break;
-	if (i = DOWNSLLEN) {
+	if (i = ARRAY_SIZE(downstatelist)) {
 		if (st->l3.debug & L3_DEB_STATE) {
 			l3_debug(st, "ni1down state %d prim %#x unhandled",
 				proc->state, pr);

@@ -3136,11 +3128,11 @@ ni1man(struct PStack *st, int pr, void *arg)
                 printk(KERN_ERR "HiSax ni1man without proc pr=%04x\n", pr);
                 return;
         }
-        for (i = 0; i < MANSLLEN; i++)
+        for (i = 0; i < ARRAY_SIZE(manstatelist); i++)
                 if ((pr = manstatelist[i].primitive) &&
                     ((1 << proc->state) & manstatelist[i].state))
                         break;
-        if (i = MANSLLEN) {
+        if (i = ARRAY_SIZE(manstatelist)) {
                 if (st->l3.debug & L3_DEB_STATE) {
                         l3_debug(st, "cr %d ni1man state %d prim %#x unhandled",
                                 proc->callref & 0x7f, proc->state, pr);
drivers/isdn/hisax/q931.c +26 -51

264 lines not on this page · raw message

drivers/isdn/hisax/tei.c +1 -3
index ceb0df9..6e65424 100644
@@ -447,8 +447,6 @@ static struct FsmNode TeiFnList[] __initdata  	{ST_TEI_IDVERIFY, EV_CHKREQ, tei_id_chk_req},
 };
 
-#define TEI_FN_COUNT (sizeof(TeiFnList)/sizeof(struct FsmNode))
-
 int __init
 TeiNew(void)
 {

@@ -456,7 +454,7 @@ TeiNew(void)
 	teifsm.event_count = TEI_EVENT_COUNT;
 	teifsm.strEvent = strTeiEvent;
 	teifsm.strState = strTeiState;
-	return FsmNew(&teifsm, TeiFnList, TEI_FN_COUNT);
+	return FsmNew(&teifsm, TeiFnList, ARRAY_SIZE(TeiFnList));
 }
 
 void
Signature · 8 lines
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
#7 lore raw
In reply to Karsten Keil
Quoted 14 lines · Karsten Keil
drivers/isdn/hisax/callc.c +0 -2
index 7c56c44..0b9ed8e 100644
@@ -834,8 +834,6 @@ static struct FsmNode fnlist[] __initdata =
 };
 /* *INDENT-ON* */
 
-#define FNCOUNT (sizeof(fnlist)/sizeof(struct FsmNode))
-
 int __init
 CallcNew(void)
 {

drivers/isdn/hisax/callc.c CallcNew(void) · line 847

Quoted 8 lines
drivers/isdn/hisax/callc.c +1 -1
@@ -843,7 +841,7 @@ CallcNew(void)
 	callcfsm.event_count = EVENT_COUNT;
 	callcfsm.strEvent = strEvent;
 	callcfsm.strState = strState;
-	return FsmNew(&callcfsm, fnlist, FNCOUNT);
+	return FsmNew(&callcfsm, fnlist, ARRAY_SIZE(fnlist));
 }
 
 void

I think that's really a nice improvement :) Thanks for the work,

MfG, JBG

Signature · 4 lines
      Jan-Benedict Glaw      [email protected]              +49-172-7608481
Signature of:           Ich hatte in letzter Zeit ein bißchen viel Realitycheck.
the second  :               Langsam möchte ich mal wieder weiterträumen können.
                             -- Maximilian Wilhelm (18. Mai 2006, #lug-owl.de)

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

author
#8 lore raw
In reply to Darren Jenkins

<snip>

Quoted 2 lines

I think what was meant here was to remove _all_ the macros that you assigned to the ARRAY_SIZE() macro.

Yes, absolutely. I overlooked the 'eg.' in Jan-Benedict's post. Sorry for that.

Quoted 4 lines

If you look at the two advantages replacing code with the ARRAY_SIZE() macro has;
1. More readable/consistent code.
2. Faster compile times, because of less macros being defined.

ack. The arguments for the consistency that I mentioned in my last post don't hold for a solution that removes all of the macros. So I'm absolutely fine with a new patch that removes them all.

Andi
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors