Skip to contentSkip to conversation

acpi: select ACPI_EC for THINKPAD_ACPI

PATCH Applied Andreas Herrmann 2 participants 3 messages Jun 19, 2007 – Jun 22, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/12 acpi: select ACPI_EC for THINKPAD_ACPI

Fix kernel build problem:

thinkpad_acpi.c:(.text+0x7486a): undefined reference to `ec_write'

(as THINKPAD_ACPI depends on ACPI_EC)

---
 drivers/misc/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/misc/Kconfig +1 -0
index 2f2fbff..72774c9 100644
@@ -139,6 +139,7 @@ config SONYPI_COMPAT
 config THINKPAD_ACPI
 	tristate "ThinkPad ACPI Laptop Extras"
 	depends on X86 && ACPI
+	select ACPI_EC
 	select BACKLIGHT_CLASS_DEVICE
 	select HWMON
 	---help---
Signature · 1 line
1.5.0.7
Acked-by on v1 2/12
#1 lore raw
Quoted 16 lines · Andreas Herrmann

Fix kernel build problem:

thinkpad_acpi.c:(.text+0x7486a): undefined reference to `ec_write'

(as THINKPAD_ACPI depends on ACPI_EC)

---
 drivers/misc/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/misc/Kconfig +0 -0
index 2f2fbff..72774c9 100644

drivers/misc/Kconfig config SONYPI_COMPAT · line 145

Quoted 7 lines
drivers/misc/Kconfig +1 -0
@@ -139,6 +139,7 @@ config SONYPI_COMPAT
 config THINKPAD_ACPI
 	tristate "ThinkPad ACPI Laptop Extras"
 	depends on X86 && ACPI
+	select ACPI_EC
 	select BACKLIGHT_CLASS_DEVICE
 	select HWMON
 	---help---
Signature · 4 lines
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
#2 lore raw
Quoted 12 lines · Henrique de Moraes Holschuh
Quoted 11 lines · Andreas Herrmann

Fix kernel build problem:

thinkpad_acpi.c:(.text+0x7486a): undefined reference to `ec_write'

(as THINKPAD_ACPI depends on ACPI_EC)

---
 drivers/misc/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 15 lines

drivers/misc/Kconfig config SONYPI_COMPAT · line 145

Quoted 12 lines
drivers/misc/Kconfig +1 -0
index 2f2fbff..72774c9 100644
@@ -139,6 +139,7 @@ config SONYPI_COMPAT
 config THINKPAD_ACPI
 	tristate "ThinkPad ACPI Laptop Extras"
 	depends on X86 && ACPI
+	select ACPI_EC
 	select BACKLIGHT_CLASS_DEVICE
 	select HWMON
 	---help---

Well, this one shouldn't be applied. The problem is better fixed in arch/x86_64/Kconfig.

BTW, the above patch would lead to kconfig warnings on non x86-architectures. A proper version would be to add "select ACPI_EC if X86".

Regards,

Andreas

Signature · 5 lines
Operating | AMD Saxony Limited Liability Company & Co. KG,
  System  | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 Research | Register Court Dresden: HRA 4896, General Partner authorized
  Center  | to represent: AMD Saxony LLC (Wilmington, Delaware, US)
  (OSRC)  | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy