ALSA portman2x4 section mismatch
PATCH 1/1 ALSA portman2x4 section mismatch
From: Randy Dunlap <[email protected]>
FIx section mismatch when CONFIG_HOTPLUG=n:
WARNING: sound/built-in.o(.exit.text+0x271): Section mismatch: reference to .init.text:snd_p ortman_unregister_all (between 'snd_portman_module_exit' and 'alsa_mpu401_uart_exit')
--- sound/drivers/portman2x4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/drivers/portman2x4.c +1 -1
@@ -833,7 +833,7 @@ static struct platform_driver snd_portma/********************************************************************* * module init stuff *********************************************************************/ -static void __init_or_module snd_portman_unregister_all(void) +static void snd_portman_unregister_all (void ) {int i;
Takashi Iwai
AppliedAt Tue, 26 Jun 2007 15:30:13 -0700,
Quoted 9 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
FIx section mismatch when
CONFIG_HOTPLUG=n:WARNING: sound/built-in.o(.exit.text+0x271): Section mismatch: reference to .init.text:snd_p
ortman_unregister_all(between 'snd_portman_module_exit' and 'alsa_mpu401_uart_exit')Signed-off-by Randy Dunlap <[email protected]>
I applied it to ALSA tree now because it's the simplest way to fix this warning. But, I'm still wondering whether it was really wrong.
The function snd_portmap_unregister_all() is called both from the module init and exit functions. Would the module_exit function be called even CONFIG_MODULE=n ? If not, __init_or_module should be correct since the function is called only from module_init.
thanks,
Takashi
Quoted 21 lines
--- sound/drivers/portman2x4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/drivers/portman2x4.c +1
-2@@ -833,7 +833,7 @@ static struct platform_driver snd_portma/********************************************************************* * module init stuff *********************************************************************/ -static void __init_or_module snd_portman_unregister_all(void) +static void snd_portman_unregister_all (void ) {int i; -To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoted 10 lines · On Wed, 27 Jun 2007 12:02:32 +0200 Takashi Iwai wrote:
At Tue, 26 Jun 2007 15:30:13 -0700,
Quoted 8 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
FIx section mismatch when
CONFIG_HOTPLUG=n:WARNING: sound/built-in.o(.exit.text+0x271): Section mismatch: reference to .init.text:snd_p
ortman_unregister_all(between 'snd_portman_module_exit' and 'alsa_mpu401_uart_exit')
Quoted 8 lines
Quoted 1 line
Signed-off-by Randy Dunlap <[email protected]>I applied it to ALSA tree now because it's the simplest way to fix this warning. But, I'm still wondering whether it was really wrong.
The function
snd_portmap_unregister_all()is called both from the module init and exit functions. Would themodule_exitfunction be called evenCONFIG_MODULE=n?
No, it's not called when the driver is built-in.
Quoted 2 lines
If not,
__init_or_moduleshould be
correct since the function is called only frommodule_init.
[adding Sam to cc:]
I see. So to try to summarize:
When CONFIG_MODULES=n, __exit functions can be allowed to reference __init functions since the __init functions won't be called because the __exit functions are not invoked.
Does that sound correct? Can & should modpost add this knowledge?
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
Quoted 28 lines · Randy Dunlap
Quoted 10 lines · On Wed, 27 Jun 2007 12:02:32 +0200 Takashi Iwai wrote:
At Tue, 26 Jun 2007 15:30:13 -0700,
Quoted 8 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
FIx section mismatch when
CONFIG_HOTPLUG=n:WARNING: sound/built-in.o(.exit.text+0x271): Section mismatch: reference to .init.text:snd_p
ortman_unregister_all(between 'snd_portman_module_exit' and 'alsa_mpu401_uart_exit')Quoted 8 lines
Quoted 1 line
Signed-off-by Randy Dunlap <[email protected]>I applied it to ALSA tree now because it's the simplest way to fix this warning. But, I'm still wondering whether it was really wrong.
The function
snd_portmap_unregister_all()is called both from the module init and exit functions. Would themodule_exitfunction be called evenCONFIG_MODULE=n?No, it's not called when the driver is built-in.
Quoted 2 lines
If not,
__init_or_moduleshould be
correct since the function is called only frommodule_init.[adding Sam to cc:]
Quoted 7 lines
I see. So to try to summarize:
When
CONFIG_MODULES=n,__exitfunctions can be allowed to reference__initfunctions since the__initfunctions won't be called because the__exitfunctions are not invoked.Does that sound correct?
In the CONFIG_MODULES=n case the __exit section is discarded so yes they can reference anything without causing breakage.
But that said this is by no means a logical thing to allow from the principle of minimum suprise.
Quoted 1 line
Can & should modpost add this knowledge?
So modpost should not have this knowledge. A better approach is either to fix the relations or drom the __init/__exit marker for a few sections. The __init/__exit parts are mainly of benefit in two cases:
1) When someone has a lot of built-in drivers
2) In the embedded world with scarce memory
As for 1) this is a non-typical case not worth optimizing too much against. As for 2) this is where the biggest benefit are.
Considering this alsa drivers are likely not typical embedded so here dropping a few __init/__exit markings should be safe.
But it also depends on what other code is invoked from these functions.
Sam