Skip to contentSkip to conversation

Bug#430833: libasound2: PCM plugin `lfloat' not built

Pkg-alsa-devel Elimar Riesebieter 2 participants 2 messages Jun 27, 2007 – Jun 28, 2007 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

forwarded 430833 [email protected]

Signature · 2 lines
On Wed, 27 Jun 2007 the mental interface of
Mark Wooding told:
Quoted 11 lines

Package: libasound2
Version: 1.0.14a-1
Severity: normal
Tags: patch

The PCM plugin lfloat' isn't compiled into libasound. In particular, this prevents the plug' plugin from doing linear<->float conversion, and in turn this means that hardly any ALSA clients can use the JACK plugin from libasound2-plugins, because JACK uses FLOAT_LE format throughout.

Quoted 5 lines

The reason for this is quite simple: the configure script is broken! In particular, the sense of the `softfloat' check used to decide whether to disable the plugin is wrong! (That's aside from the question of whether it's sensible to fail to build the thing just because it might be slow.)

We should solve this in general. It's not a Debian specific wish so forwarded upstream.

Quoted 23 lines

Index: alsa-lib-1.0.14a/configure.in
===================================================================
--- alsa-lib-1.0.14a.orig/configure.in 2007-06-27 16:24:58.000000000 +0100
+++ alsa-lib-1.0.14a/configure.in 2007-06-27 16:25:19.000000000
+0100

(quoted diff) +1 -1
@@ -416,7 +416,7 @@
   build_pcm_share="no"
 fi
 
-if test "$softfloat" != "yes"; then
+if test "$softfloat" = "yes"; then
   build_pcm_lfloat="no"
 fi
 

Index: alsa-lib-1.0.14a/configure
===================================================================
--- alsa-lib-1.0.14a.orig/configure 2007-06-27 16:25:23.000000000
+0100
+++ alsa-lib-1.0.14a/configure 2007-06-27 16:25:38.000000000 +0100

Review line 20952

Quoted 8 lines
(quoted diff) +1 -1
@@ -20946,7 +20946,7 @@
   build_pcm_share="no"
 fi
 
-if test "$softfloat" != "yes"; then
+if test "$softfloat" = "yes"; then
   build_pcm_lfloat="no"
 fi
 

Elimar

Signature · 2 lines
  Experience is something you don't get until 
  just after you need it!
#2 lore raw

At Wed, 27 Jun 2007 22:16:00 +0200,

Quoted 27 lines · Elimar Riesebieter

forwarded 430833 [email protected]

Signature · 2 lines
On Wed, 27 Jun 2007 the mental interface of
Mark Wooding told:
Quoted 11 lines

Package: libasound2
Version: 1.0.14a-1
Severity: normal
Tags: patch

The PCM plugin lfloat' isn't compiled into libasound. In particular, this prevents the plug' plugin from doing linear<->float conversion, and in turn this means that hardly any ALSA clients can use the JACK plugin from libasound2-plugins, because JACK uses FLOAT_LE format throughout.

Quoted 5 lines

The reason for this is quite simple: the configure script is broken! In particular, the sense of the `softfloat' check used to decide whether to disable the plugin is wrong! (That's aside from the question of whether it's sensible to fail to build the thing just because it might be slow.)

We should solve this in general. It's not a Debian specific wish so forwarded upstream.

Yep, now committed to ALSA HG tree.

Thanks!

Takashi