Fix lguest w/ lockdep
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 Fix lguest w/ lockdep
Quoted 2 lines · Matt Mackall
lguest: unhandled trap 14 at
0xc01362f7(0x0) Dump of assembler code for function__lock_acquire:
Thanks for the bug report Matt! I wonder if other paravirt_disable_iospace users have the same issue...
===
Fix "lguest: unhandled trap 14 at 0xc013630f (0x0)" with CONFIG_LOCKDEP=y
paravirt_disable_iospace -> request_resource -> write_lock -> __lock_acquire()
lockdep_init() is already idempotent: simply call it before paravirt_disable_iospace().
drivers/lguest/lguest.c +2 -0
@@ -593,6 +593,8 @@ __init void lguest_init(void *boot)reserve_top_address (lguest_data.reserve_mem); +lockdep_init (); +paravirt_disable_iospace ();cpu_detect (&new_cpu_data);
Quoted 9 lines · Rusty Russell
Quoted 3 lines · Matt Mackall
lguest: unhandled trap 14 at
0xc01362f7(0x0) Dump of assembler code for function__lock_acquire:Thanks for the bug report Matt! I wonder if other
paravirt_disable_iospaceusers have the same issue...
I call it a little later (from arch_setup), and I think lockdep_init will have already been called at that point. Hm, yes, it gets called at the top of start_kernel.
J