Skip to contentSkip to conversation

filemap.c: interesting check around zero_length_segment:

DISCUSSION Alexey Dobriyan 1 participant 1 message Jun 29, 2007

lore
Share & tools
lore
#0 lore raw

Adding -W -Wno-stupid-warnings results in the following warning:

mm/filemap.c: In function 'generic_file_buffered_write':
mm/filemap.c:2179: warning: comparison of unsigned expression >= 0 is always true

		if (likely(copied >= 0)) {
			if (!status)
				status = copied;

Branch is always taken since "copied" is size_t.

Such code doesn't exist in -mm, but is this something to worry about for current and older kernels?