se401: fix "&& 0x" typo
PATCH 1/1 se401: fix "&& 0x" typo
Code there survived trivial regexp made earlier, but after bulk preprocessing was done...
===> if (!cp[2] && 0x40) { <===
printk("<3>" "%s: " "Bayer format not supported!" ...
return 1;
}NOTE: to me, check or error message should be reverted, but I know nothing about this driver.
---
drivers/media/video/se401.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/video/se401.c +1 -1
@@ -1280,7 +1280,7 @@ static int se401_init(struct usb_se401 *se401, int button) rc=se401_sndctrl (0 , se401,SE401_REQ_GET_HEIGHT ,0 , cp,sizeof (cp)); se401->cheight=cp[0 ]+cp[1 ]*256 ; -if (!cp[2 ] &&SE401_FORMAT_BAYER ) { +if (!(cp[2 ] &SE401_FORMAT_BAYER )) {err ("Bayer format not supported!" );return 1 ; }
Em Seg, 2007-07-02 às 15:04 +0400, Alexey Dobriyan escreveu:
Quoted 11 lines
Code there survived trivial regexp made earlier, but after bulk preprocessing was done...
===> if (!cp[2] &&
0x40) { <===printk("<3>" "%s: " "Bayer format not supported!" ... return 1; }NOTE: to me, check or error message should be reverted, but I know nothing about this driver.
Your patch looks to be coherent. However, I suspect that this will break the driver. There are some functions at the driver for decoding Bayer format. Without your patch, the if condition will never occur. So, Bayer decoding will work.
IMO, the better is to add an #if 0 at the test.
Signature · 2 lines
Cheers, Mauro