Skip to contentSkip to conversation

Input updates for 2.6.22-rc7

GIT PULL Dmitry Torokhov 4 participants 8 messages Jul 5, 2007 – Jul 6, 2007

lore
Share & tools
lore
#0 lore raw

[Resending with proper kernel version in subject... I guess original claiming to be for 2.6.22-rc4 might have something to do with it being dropped...]

Hi Linus,

Please consider pulling from:

        git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus

or
        master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus

to receive updates for input subsystem. You will get update to AT keyboard driver that throttles LED switching so that 'setleds' does not lock up keyboards. Also fix for an oops happening if user presses Ctrl-Alt-Del in the middle of keyboard being probed (serio_cleanup should take mutex). Note that the bulk of changes to input.h are just comments for various KEY_XXX input codes and not functional changes.

Changelog:
----------

Dmitry Torokhov (4):
      Input: i8042 - add HP Pavilion ZT1000 to the MUX blacklist
      Input: atkbd - throttle LED switching
      Input: serio - take drv_mutex in serio_cleanup()
      Input: document some of keycodes

Henrique de Moraes Holschuh (1):
      Input: add a new EV_SW SW_RADIO event, for radio switches on laptops

Qi Yong (1):
      Input: atkbd - use printk_ratelimit for spurious ACK messages

Diffstat:
---------

 drivers/input/keyboard/atkbd.c        |   47 +++++++---- drivers/input/serio/i8042-x86ia64io.h |   11 +++ drivers/input/serio/serio.c           |    2 + include/linux/input.h                 |  143 +++++++++++++++++---------------

 4 files changed, 119 insertions(+), 84 deletions(-)
Signature · 1 line
Dmitry
#1 lore raw

[ Ok, pulled. However, it's time for another installment of "Flame that
stupid mail client", because this isn't the first time this bit me ]

Quoted 4 lines · Dmitry Torokhov

Please consider pulling from:

        git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus

There's somethign wrong with your emails, and it's very irritating.

I cannot just cut-and-paste the whole line, because your tabs and spaces aren't tabs and spaces, they are some horrible abomination.

What _looks_ like a tab above, when I save it and look at it with "od", it shows it true nasty life: it's not a tab, and it's not even eight spaces, it's four copies of the byte sequence '\302\240 ' ('\xC2\xA0\x20'), ie some horrid nasty three-byte sequence where one character is a space, and the previous two characters are some utf-8 abomination.

I have no idea what kind of crap you use to generate it, and quite frankly, I don't want to know. I just want it to stop, so that when I cut-and-paste, I don't get random UTF-8 characters that just *look* like spaces but don't act like it, and cause my shell to very reasonably whine about the result.

I think the "c2 a0" character is the utf-8 representation of a &nbsp (non-breaking space), but:
- you are damn well sending text
- it's followed by a regular space, so it's stupid
- please don't do it.

It says your user-agent is "Kmail", and maybe there is some way to fix it. And if kmail is correct, please make a bug-report to the kmail people. Sending hidden invisible utf-8 crap that looks like space, but doesn't act like it, is just damn impolite by kmail. I assume you weren't even aware of the random crud you are sending out?

Linus

#2 lore raw
Quoted 3 lines · Linus Torvalds

It says your user-agent is "Kmail", and maybe there is some way to fix it. And if kmail is correct, please make a bug-report to the kmail people.

Ok, googling for kmail, I think it really is kmail doing it, because I find others complaining about the same idiocy.

Btw, the others who noticed this weren't _nearly_ as polite as I am about kmail.

Apparently kmail - at least when cutting-and-pasting - will actually turn every other space into an NBSP for some internal idiotic reason. So even if you _originally_ had 8 spaces, Kmail will apparently corrupt your data when cutting-and-pasting according to that other report I saw.

Please stop using kmail, or ask for it to get fixed.

I'm constantly surprised by just how _many_ ways MUA's find to screw up. It's not like they seem to all have some stupid bug. It's more like they seem to all have willfully added code explicitly to mess up the content of email, often with the goal of making it "look" right, even if it's crap.

In this case, it means that you cannot cut-and-paste simple ASCII text, because Kmail messed up.

Linus

#3 lore raw
Quoted 13 lines · Linus Torvalds
Quoted 3 lines · Linus Torvalds

It says your user-agent is "Kmail", and maybe there is some way to fix it. And if kmail is correct, please make a bug-report to the kmail people.

Ok, googling for kmail, I think it really is kmail doing it, because I find others complaining about the same idiocy.

Btw, the others who noticed this weren't _nearly_ as polite as I am about kmail.

Quoted 7 lines

Apparently kmail - at least when cutting-and-pasting - will actually turn every other space into an NBSP for some internal idiotic reason. So even if you _originally_ had 8 spaces, Kmail will apparently corrupt your data when cutting-and-pasting according to that other report I saw.

Please stop using kmail, or ask for it to get fixed.

Or just configure it differently. I use kmail sometimes (either that or pine) and with a little config tweaking (and a few rules of thumb about use) it can actually be made to behave resonably fine.

Here are a few tips;
- Don't cut'n'paste stuff into kmail
- Go to Settings --> Configure KMail, select Composer, remove the
checkmark from "Word wrap at column ...".
- Go to Settings --> Configure KMail, select Composer, go to the
Charset tab, make the list read us-ascii, iso-8859-1 - just listing
those two (in that order) seems to generate working mails.
- Go to Settings --> Configure KMail, select Accounts, go to the
Sending tab, make "Message property" be "Allow 8-bit".

When writing a new message, check the Options menu, make sure Wordwrap is not enabled and that Encoding is us-ascii or iso-8859-1 (or possibly something else) - the auto-detect option seems to sometimes get things wrong.

When inserting a patch or similar into a mail, use Message-->"Insert File"

Quoted 1 line

I'm constantly surprised by just how _many_ ways MUA's find to screw up.

'pine' actually seems to work pretty damn well once you disable the flowed-text "feature".

Quoted 7 lines

It's not like they seem to all have some stupid bug. It's more like they seem to all have willfully added code explicitly to mess up the content of email, often with the goal of making it "look" right, even if it's crap.

In this case, it means that you cannot cut-and-paste simple ASCII text, because Kmail messed up.

Yeah, email is old, and there are too many ways to do things, too many conflicting RFC's, compeeting commercial implementations etc etc etc - the whole thing could do with a from-scratch re-implementation (as if that's going to happen)...

Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
#4 lore raw
Quoted 5 lines · Jesper Juhl
Quoted 2 lines

I'm constantly surprised by just how _many_ ways MUA's find to screw up.

'pine' actually seems to work pretty damn well once you disable the flowed-text "feature".

Yes. And 'alpine', it's modern version, does even better, but you also need to make sure to disable "downgrade-multipart-to-text".

I've been using alpine for a while now, and it's nice to see it be utf-8 capable and able to handle other charsets well.

So as a former pine user, I can recommend upgrading.

Linus

#5 lore raw
In reply to Linus Torvalds
Quoted 9 lines · Linus Torvalds
Quoted 4 lines · Dmitry Torokhov

Please consider pulling from:

        git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus

There's somethign wrong with your emails, and it's very irritating.

Oops, sorry.

Quoted 3 lines

I cannot just cut-and-paste the whole line, because your tabs and spaces aren't tabs and spaces, they are some horrible abomination.

Yes, for some reason Kmail somethmes does this when cut-and-pasting from another email. I don't think it does it when cutting and pasting from anywhere else...

Quoted 18 lines

What _looks_ like a tab above, when I save it and look at it with "od", it shows it true nasty life: it's not a tab, and it's not even eight spaces, it's four copies of the byte sequence '\302\240 ' ('\xC2\xA0\x20'), ie some horrid nasty three-byte sequence where one character is a space, and the previous two characters are some utf-8 abomination.

I have no idea what kind of crap you use to generate it, and quite frankly, I don't want to know. I just want it to stop, so that when I cut-and-paste, I don't get random UTF-8 characters that just *look* like spaces but don't act like it, and cause my shell to very reasonably whine about the result.

I think the "c2 a0" character is the utf-8 representation of a &nbsp (non-breaking space), but:
- you are damn well sending text
- it's followed by a regular space, so it's stupid
- please don't do it.

Quoted 6 lines

It says your user-agent is "Kmail", and maybe there is some way to fix it. And if kmail is correct, please make a bug-report to the kmail people. Sending hidden invisible utf-8 crap that looks like space, but doesn't act like it, is just damn impolite by kmail. I assume you weren't even aware of the random crud you are sending out?

I was not... The copy I got from LKML looks fine in Kmail, Gmail and MS Outlook.

The thing is I like Kmail because it never screwed up patches that I sent out. I guess I will just stop cutting and pasting e-mails and just adjust my script that generates changelog and diffstat. The issue may even be already fixed in newer versions of Kmail, I am a little behind times with my setup...

Signature · 1 line
Dmitry
#6 lore raw
Quoted 3 lines · Dmitry Torokhov

I was not... The copy I got from LKML looks fine in Kmail, Gmail and
MS Outlook. ^^^^^^^^^^

That's the problem.

It *looks* *fine*.

The "&nbsp" doesn't look any different from a regular space. There's no way to tell the difference. Except it doesn't *work* the same. You cut-and-paste it into a shell window, and that shell window will not consider a nbsp to be the same thing as a space.

And I don't really understand why Kmail would do something like that. They obviously do it on purpose, since the nbsp wasn't there originally, so they literally go do extra work to _corrupt_ the data they cut-and-paste. Why do it? Who knows. But it's really sad.

Linus

#7 lore raw

plain text MUAs (Re: [git pull][resend] Input updates for 2.6.22-rc7)

In reply to Linus Torvalds

* Linus Torvalds <Thu, 5 Jul 2007 16:09:10 -0700 (PDT)>

Quoted 6 lines

Content-Transfer-Encoding: QUOTED-PRINTABLE

Quoted 3 lines · Dmitry Torokhov

Please consider pulling from:

Quoted 8 lines
Quoted 1 line

б═ б═ б═ б═ git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus

There's somethign wrong with your emails, and it's very irritating.

I cannot just cut-and-paste the whole line, because your tabs and spaces aren't tabs and spaces, they are some horrible abomination.

What _looks_ like a tab above, when I save it and look at it with "od",

The Plain-Text tools...
As a proud user of such, i can only say, that crap can be seen just like a plain-text (:

|-*-
=C2=A0 =C2=A0 =C2=A0 =C2=A0 git://git.kernel.org/pub/scm/linux/kernel/g=
it/dtor/input.git for-linus

or
=C2=A0 =C2=A0 =C2=A0 =C2=A0 master.kernel.org:/pub/scm/linux/kernel/git= /dtor/input.git for-linus
|-*-

And quoted-printable is the most awful thing, when i read MLs with slrn :)
____