Skip to contentSkip to conversation

error out if signing was requested, but can't be fulfilled

PATCH New Jeff Layton 1 participant 1 message Jul 5, 2007 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 error out if signing was requested, but can't be fulfilled

Currently, if mount with a signing-enabled sec= option (e.g. sec=ntlmi), the kernel does a warning printk if the server doesn't support signing, and then proceeds without signatures.

This is probably OK for people that think to look at the ring buffer, but seems wrong to me. If someone explicitly requests signing, we should error out if that request can't be satisfied. They can then reattempt the mount without signing if that's ok.

Is there any reason not to do something like the following patch?

fs/cifs/cifssmb.c +1 -0
index 4a2458e..c9cae48 100644
@@ -650,6 +650,7 @@ signing_check:
 			(SECMODE_SIGN_ENABLED | SECMODE_SIGN_REQUIRED)) == 0) {
 			cERROR(1,
 				("signing required but server lacks support"));
+			rc = -EOPNOTSUPP;
 		} else
 			server->secMode |= SECMODE_SIGN_REQUIRED;
 	} else {