GEODE: basic infrastructure support for AMD geode-class machines
PATCH 1/3 GEODE: basic infrastructure support for AMD geode-class machines
This builds upon the existing geode infrastructure, but adds southbridge support, some GPIO functions, and a header file (asm-i386/geode.h) with some useful GX/LX detection tests.
The majority of this code was written by Jordan Crouse.
--- arch/i386/kernel/Makefile | 1 + arch/i386/kernel/geode.c | 156 ++++++++++++++++++++++++++++++++++++++++++++ include/asm-i386/geode.h | 159 +++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 316 insertions(+), 0 deletions(-) create mode 100644 arch/i386/kernel/geode.c create mode 100644 include/asm-i386/geode.h
arch/i386/kernel/Makefile +1 -0
@@ -40,6 +40,7 @@ obj-$(CONFIG_VM86) += vm86.o obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-$(CONFIG_HPET_TIMER) += hpet.o obj-$(CONFIG_K8_NB) += k8.o +obj-$(CONFIG_MGEODE_LX) += geode.o obj-$(CONFIG_VMI) += vmi.o vmiclock.o obj-$(CONFIG_PARAVIRT) += paravirt.o
arch/i386/kernel/geode.c new file +156 -0
156 lines not on this page · raw message
include/asm-i386/geode.h new file +159 -0
159 lines not on this page · raw message
Signature · 1 line
1.5.2.2
The patches have some trivial-but-common coding-style bloopers which scripts/checkpatch.pl will detect. Please check it out.
Please send a patch which documents mfgpt_irq inDocumentation/kernel-parameters.txt, thanks.
Andy, the miss rate on documentation for new __setup() handlers is about 75%. Might be worth adding to checkpatch.pl.
Quoted 9 lines · Andrew Morton
The patches have some trivial-but-common coding-style bloopers which
scripts/checkpatch.plwill detect. Please check it out. ohPlease send a patch which documents
mfgpt_irqinDocumentation/kernel-parameters.txt, thanks.Andy, the miss rate on documentation for new
__setup()handlers is about 75%. Might be worth adding to checkpatch.pl.
If we are willing to expect the update in the same patch then we can emit a failure if the presented string in __check isn't in the update to the documentation. I guess emit it as a CHECK in case they have loads of them and a separate documentation patch.
CHECK: __setup appears un-documented -- check
Documentation/kernel-parameters.txt
#131: FILE: arch/i386/kernel/mfgpt.c:233:
+__setup("mfgpt_irq=", mfgpt_setup);
-apw