Skip to contentSkip to conversation

Include serial_reg.h with userspace headers

PATCH In review Herton Ronaldo Krzesinski 2 participants 2 messages Jul 15, 2007 – Jul 19, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Include serial_reg.h with userspace headers

Hi,

As reported by Gustavo de Nardin <[email protected]>, while trying to compile xosview (http://xosview.sourceforge.net/) with upstream kernel headers being used you get the following errors:
serialmeter.cc:48:30: error: linux/serial_reg.h: No such file or directory serialmeter.cc: In member function 'virtual void SerialMeter::checkResources()':
serialmeter.cc:71: error: 'UART_LSR' was not declared in this scope serialmeter.cc:71: error: 'UART_MSR' was not declared in this scope
...

I don't know if it's right to provide serial_reg.h with userspace headers, may be serial_reg.h isn't included for some reason. But if it's ok, the following patch adds serial_reg.h to be installed with user space kernel headers:

=================================================

Add serial_reg.h to userspace kernel headers

Include serial_reg.h in kernel headers for user space, it is at least needed for one program, xosview.

include/linux/Kbuild +1 -0
index 127d2d1..eba0ccb 100644
@@ -137,6 +137,7 @@ header-y += radeonfb.h
 header-y += raw.h
 header-y += resource.h
 header-y += rose.h
+header-y += serial_reg.h
 header-y += smbno.h
 header-y += snmp.h
 header-y += sockios.h

--
[]'s
Herton.

#1 lore raw
Quoted 10 lines · On Sun, 15 Jul 2007 00:02:39 -0300 Herton Ronaldo Krzesinski…

As reported by Gustavo de Nardin <[email protected]>, while trying to compile xosview (http://xosview.sourceforge.net/) with upstream kernel headers being used you get the following errors:
serialmeter.cc:48:30: error: linux/serial_reg.h: No such file or directory serialmeter.cc: In member function 'virtual void SerialMeter::checkResources()':
serialmeter.cc:71: error: 'UART_LSR' was not declared in this scope serialmeter.cc:71: error: 'UART_MSR' was not declared in this scope
...

Quoted 4 lines

I don't know if it's right to provide serial_reg.h with userspace headers, may be serial_reg.h isn't included for some reason. But if it's ok, the following patch adds serial_reg.h to be installed with user space kernel headers:

Well that file is just a pile of "#define name number"s so I guess it's OK to export it to save someone some typing, and to avoid breaking existing stuff more than we need to.