Skip to contentSkip to conversation

Fix memory leak in dm_create_persistent() when starting metadata update thread fails.

PATCH New Jesper Juhl 1 participant 1 message Jul 16, 2007 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix memory leak in dm_create_persistent() when starting metadata update thread fails.

If, in dm_create_persistent(), the call to create_singlethread_workqueue() fails then we'll return without freeing the memory allocated to 'ps', thus leaking sizeof(struct pstore) bytes.
This patch fixes the leak.

---

drivers/md/dm-exception-store.c +1 -0
index 3d65917..8fe81e1 100644
@@ -623,6 +623,7 @@ int dm_create_persistent(struct exception_store *store)
 
 	ps->metadata_wq = create_singlethread_workqueue("ksnaphd");
 	if (!ps->metadata_wq) {
+		kfree(ps);
 		DMERR("couldn't start header metadata update thread");
 		return -ENOMEM;
 	}