Skip to contentSkip to conversation

fs/romfs/inode.c: trivial improvements

PATCH New WANG Cong 1 participant 1 message Jul 18, 2007 VFS

lore
Share & tools
lore

WANG Cong

author
#0 lore raw

PATCH 1/1 fs/romfs/inode.c: trivial improvements

1. There's no lists in fs/romfs/inode.c, so using list_entry is a bit confusing. Replace it with container_of.

2. It is unnecessary to cast the return value of kmem_cache_alloc, since it returns a void* pointer.

This patch is against 2.6.22.1.

---
 fs/romfs/inode.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/romfs/inode.c +2 -2
Index: linux-2.6.22.1/fs/romfs/inode.c
===================================================================
@@ -92,7 +92,7 @@
 
 static inline struct romfs_inode_info *ROMFS_I(struct inode *inode)
 {
-	return list_entry(inode, struct romfs_inode_info, vfs_inode);
+	return container_of(inode, struct romfs_inode_info, vfs_inode);
 }
 
 static __u32
@@ -555,7 +555,7 @@
 static struct inode *romfs_alloc_inode(struct super_block *sb)
 {
 	struct romfs_inode_info *ei;
-	ei = (struct romfs_inode_info *)kmem_cache_alloc(romfs_inode_cachep, GFP_KERNEL);
+	ei = kmem_cache_alloc(romfs_inode_cachep, GFP_KERNEL);
 	if (!ei)
 		return NULL;
 	return &ei->vfs_inode;