cr_backlight_probe allocates too little storage for struct cr_panel
Subsystems (2)
PATCH 1/1 cr_backlight_probe allocates too little storage for struct cr_panel
Hi,
The Coverity checker noticed that we allocate too little storage for "struct cr_panel *crp" in cr_backlight_probe().
We allocate sizeof(crp) where we should really be allocating sizeof(*crp) - or sizeof(struct cr_panel) - I chose the first notation.
This patch should fix the problem.
Signed-off-by Jesper Juhl <[email protected]>
---
drivers/video/backlight/cr_bllcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/backlight/cr_bllcd.c +1 -1
@@ -174,7 +174,7 @@ static int cr_backlight_probe(struct platform_device *pdev)struct cr_panel *crp;u8 dev_en; - crp =kzalloc (sizeof (crp),GFP_KERNEL ); + crp =kzalloc (sizeof (*crp),GFP_KERNEL );if (crp ==NULL )return -ENOMEM ;