Skip to contentSkip to conversation

i2o: defined but not used.

PATCH In review Sebastian Siewior 4 participants 5 messages Jul 20, 2007 – Jul 26, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2o: defined but not used.

Got with randconfig
drivers/message/i2o/exec-osm.c:539: warning: 'i2o_exec_lct_notify' defined but not used

drivers/message/i2o/exec-osm.c +8 -2
Index: b/drivers/message/i2o/exec-osm.c
===================================================================
@@ -389,9 +389,7 @@ static void i2o_exec_lct_modified(struct
 	if (i2o_device_parse_lct(c) != -EAGAIN)
 		change_ind = c->lct->change_ind + 1;
 
-#ifdef CONFIG_I2O_LCT_NOTIFY_ON_CHANGES
 	i2o_exec_lct_notify(c, change_ind);
-#endif
 };
 
 /**
@@ -525,6 +523,7 @@ int i2o_exec_lct_get(struct i2o_controll
 	return rc;
 }
 
+#ifdef CONFIG_I2O_LCT_NOTIFY_ON_CHANGES
 /**
  *	i2o_exec_lct_notify - Send a asynchronus LCT NOTIFY request
  *	@c: I2O controller to which the request should be send
@@ -570,6 +569,13 @@ static int i2o_exec_lct_notify(struct i2
 	return 0;
 };
 
+#else
+static int i2o_exec_lct_notify(struct i2o_controller *c, u32 change_ind)
+{
+	return 0;
+}
+#endif
+
 /* Exec OSM driver struct */
 struct i2o_driver i2o_exec_driver = {
 	.name = OSM_NAME,
#1 lore raw
Quoted 1 line · On Sat, 21 Jul 2007 00:58:01 +0200 Sebastian Siewior <[email protected]>…

Got with randconfig

randconfig apparently generates impossible configs. Please always run `make oldconfig' after the randconfig, then do the test build.

#2 lore raw
Quoted 6 lines · * Andrew Morton | 2007-07-21 03:31:33 [-0700]:
Quoted 1 line · On Sat, 21 Jul 2007 00:58:01 +0200 Sebastian Siewior <[email protected]>…

Got with randconfig

randconfig apparently generates impossible configs. Please always run `make oldconfig' after the randconfig, then do the test build.

Ah okey, I did not know this.

CONFIG_I2O=y
# CONFIG_I2O_LCT_NOTIFY_ON_CHANGES is not set

Is still in my .config after oldconfig.

Sebastian

#3 lore raw
In reply to Andrew Morton
Quoted 6 lines · On Sat, 21 Jul 2007 03:31:33 -0700 Andrew Morton wrote:
Quoted 1 line · On Sat, 21 Jul 2007 00:58:01 +0200 Sebastian Siewior <[email protected]>…

Got with randconfig

randconfig apparently generates impossible configs. Please always run `make oldconfig' after the randconfig, then do the test build.

This one is not impossible. Patch looks good.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#4 lore raw
In reply to Andrew Morton

Hi,

Quoted 1 line · Andrew Morton

On Sat, 21 Jul 2007 00:58:01 +0200 Sebastian Siewior

Quoted 4 lines · <[email protected]> wrote:
Quoted 1 line

Got with randconfig

randconfig apparently generates impossible configs. Please always run `make oldconfig' after the randconfig, then do the test build.

If that should make any difference, that would be a bug and I'd like to see that .config.

bye, Roman