Skip to contentSkip to conversation

fix modular compilation of pmu_battery

PATCH Dave Jones 2 participants 2 messages Jul 21, 2007 – Jul 22, 2007 Linux for power macintosh

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

pmu_battery fails to compile as a module on ppc64.

ERROR: "pmu_batteries" [drivers/power/pmu_battery.ko] undefined!
ERROR: "pmu_battery_count" [drivers/power/pmu_battery.ko] undefined!
ERROR: "pmu_power_flags" [drivers/power/pmu_battery.ko] undefined!

drivers/macintosh/via-pmu.c renamed from drivers/macintosh/via-pmu.c~ +2 -2
@@ -2842,10 +2842,10 @@ EXPORT_SYMBOL(pmu_wait_complete);
 EXPORT_SYMBOL(pmu_suspend);
 EXPORT_SYMBOL(pmu_resume);
 EXPORT_SYMBOL(pmu_unlock);
-#if defined(CONFIG_PM) && defined(CONFIG_PPC32)
+#if defined(CONFIG_PM)
 EXPORT_SYMBOL(pmu_enable_irled);
 EXPORT_SYMBOL(pmu_battery_count);
 EXPORT_SYMBOL(pmu_batteries);
 EXPORT_SYMBOL(pmu_power_flags);
-#endif /* CONFIG_PM && CONFIG_PPC32 */
+#endif
 
Signature · 1 line
http://www.codemonkey.org.uk
#1 lore raw
Quoted 12 lines · Dave Jones

pmu_battery fails to compile as a module on ppc64.

ERROR: "pmu_batteries" [drivers/power/pmu_battery.ko] undefined!
ERROR: "pmu_battery_count" [drivers/power/pmu_battery.ko] undefined!
ERROR: "pmu_power_flags" [drivers/power/pmu_battery.ko] undefined!

drivers/macintosh/via-pmu.c 2007-07-20 20:45:52.000000000 -0400 renamed from drivers/macintosh/via-pmu.c~ 2007-07-20 20:45:27.000000000 -0400 +0 -0
@@ -2842,10 +2842,10 @@ EXPORT_SYMBOL(pmu_wait_complete);
 EXPORT_SYMBOL(pmu_suspend);

drivers/macintosh/via-pmu.c 2007-07-20 20:45:52.000000000 -0400 EXPORT_SYMBOL(pmu_wait_complete); · line 2850

Quoted 10 lines
drivers/macintosh/via-pmu.c 2007-07-20 20:45:52.000000000 -0400 renamed from drivers/macintosh/via-pmu.c~ 2007-07-20 20:45:27.000000000 -0400 +2 -2
 EXPORT_SYMBOL(pmu_resume);
 EXPORT_SYMBOL(pmu_unlock);
-#if defined(CONFIG_PM) && defined(CONFIG_PPC32)
+#if defined(CONFIG_PM)
 EXPORT_SYMBOL(pmu_enable_irled);
 EXPORT_SYMBOL(pmu_battery_count);
 EXPORT_SYMBOL(pmu_batteries);
 EXPORT_SYMBOL(pmu_power_flags);
-#endif /* CONFIG_PM && CONFIG_PPC32 */
+#endif

Paul has a different fix for this pending on the linuxppc-dev list.

josh