Skip to contentSkip to conversation

struct led_classdev conversion compile fallout

FIX Andreas Gruenbacher 2 participants 2 messages Jul 23, 2007 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

Commit f8a7c6fe switched from a struct class_device to a struct device in struct led_classdev. Need to adjust drivers/misc/asus-laptop.c as well.

drivers/misc/asus-laptop.c +2 -2
index f753060..2fdee5b 100644
@@ -1067,8 +1067,8 @@ static void asus_backlight_exit(void)
 }
 
 #define  ASUS_LED_UNREGISTER(object)				\
-	if(object##_led.class_dev				\
-	   && !IS_ERR(object##_led.class_dev))			\
+	if(object##_led.dev					\
+	   && !IS_ERR(object##_led.dev))			\
 		led_classdev_unregister(&object##_led)
 
 static void asus_led_exit(void)
#1 lore raw
Quoted 10 lines · Andreas Gruenbacher

Commit f8a7c6fe switched from a struct class_device to a struct device in struct led_classdev. Need to adjust drivers/misc/asus-laptop.c as well.

drivers/misc/asus-laptop.c +0 -0
index f753060..2fdee5b 100644

drivers/misc/asus-laptop.c static void asus_backlight_exit(void) · line 1074

Quoted 10 lines
drivers/misc/asus-laptop.c +2 -2
@@ -1067,8 +1067,8 @@ static void asus_backlight_exit(void)
 }
 
 #define  ASUS_LED_UNREGISTER(object)				\
-	if(object##_led.class_dev				\
-	   && !IS_ERR(object##_led.class_dev))			\
+	if(object##_led.dev					\
+	   && !IS_ERR(object##_led.dev))			\
 		led_classdev_unregister(&object##_led)
 
 static void asus_led_exit(void)

Same fix here -> http://lkml.org/lkml/2007/7/23/137 but see Al Viro comment about -> http://lkml.org/lkml/2007/7/23/139

Regards,

Gabriel C