Skip to contentSkip to conversation

IOC3: Switch hw checksumming to ethtool configurable.

NET Applied Ralf Baechle 2 participants 2 messages Jul 25, 2007 – Jul 30, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

---

I've previously sent out this patch a long time ago. At that time I was told NETIF_F_IP_CSUM wouldn't make any sense without NETIF_F_SG. IOC3's S/G abilities are very limited; it can do upto three segments of which the first one is upto 104 bytes and part of the packet's TX ring entry, the second and 3rd ones can be anywhere in the 64-bit PCI address space but may not cross a 16kB page boundary. So setting NETIF_F_SG isn't really an option unless the IOC3 was going to linearize any packet it can't cope with itself.

So the big question, does NETIF_F_IP_CSUM without NETIF_F_SG make sense?

 drivers/net/Kconfig    |   20 --------------------
 drivers/net/ioc3-eth.c |   48 ++++++++++++++++++++++++++++++++----------------
 2 files changed, 32 insertions(+), 36 deletions(-)
drivers/net/Kconfig +0 -20
Index: linux-2.6/drivers/net/Kconfig
===================================================================
@@ -480,26 +480,6 @@ config SGI_IOC3_ETH
 	  the Ethernet-HOWTO, available from
 	  <http://www.tldp.org/docs.html#howto>.
 
-config SGI_IOC3_ETH_HW_RX_CSUM
-	bool "Receive hardware checksums"
-	depends on SGI_IOC3_ETH && INET
-	default y
-	help
-	  The SGI IOC3 network adapter supports TCP and UDP checksums in
-	  hardware to offload processing of these checksums from the CPU.  At
-	  the moment only acceleration of IPv4 is supported.  This option
-	  enables offloading for checksums on receive.  If unsure, say Y.
-
-config SGI_IOC3_ETH_HW_TX_CSUM
-	bool "Transmit hardware checksums"
-	depends on SGI_IOC3_ETH && INET
-	default y
-	help
-	  The SGI IOC3 network adapter supports TCP and UDP checksums in
-	  hardware to offload processing of these checksums from the CPU.  At
-	  the moment only acceleration of IPv4 is supported.  This option
-	  enables offloading for checksums on transmit.  If unsure, say Y.
-
 config MIPS_SIM_NET
 	tristate "MIPS simulator Network device"
 	depends on MIPS_SIM
drivers/net/ioc3-eth.c +32 -16

116 lines not on this page · raw message

Applied
#1 lore raw
Quoted 1 line · Ralf Baechle

applied to #upstream (2.6.24)

Quoted 10 lines

I've previously sent out this patch a long time ago. At that time I was told NETIF_F_IP_CSUM wouldn't make any sense without NETIF_F_SG. IOC3's S/G abilities are very limited; it can do upto three segments of which the first one is upto 104 bytes and part of the packet's TX ring entry, the second and 3rd ones can be anywhere in the 64-bit PCI address space but may not cross a 16kB page boundary. So setting NETIF_F_SG isn't really an option unless the IOC3 was going to linearize any packet it can't cope with itself.

So the big question, does NETIF_F_IP_CSUM without NETIF_F_SG make sense?

Conventional wisdom has always been that NETIF_F_SG is required if NETIF_F_*CSUM is present, and vice versa.

I admit I've not verified this in the past year or two.

Jeff