Skip to contentSkip to conversation

acpi_ec_remove(): fix use-after-free

2.6.23 regression fix Adrian Bunk 1 participant 1 message Jul 29, 2007 ACPI

lore
Share & tools
lore
#0 lore raw

This patch fixes an obvious use-after-free introduced by commit 837012ede14a8fc088be3682c964da7fc6af026b.

Spotted by the Coverity checker.

---

drivers/acpi/ec.c renamed from drivers/acpi/ec.c.old +2 -2
@@ -730,14 +730,14 @@
 static int acpi_ec_remove(struct acpi_device *device, int type)
 {
 	struct acpi_ec *ec;
-	struct acpi_ec_query_handler *handler;
+	struct acpi_ec_query_handler *handler, *tmp;
 
 	if (!device)
 		return -EINVAL;
 
 	ec = acpi_driver_data(device);
 	mutex_lock(&ec->lock);
-	list_for_each_entry(handler, &ec->list, node) {
+	list_for_each_entry_safe(handler, tmp, &ec->list, node) {
 		list_del(&handler->node);
 		kfree(handler);
 	}