remove unused TIF_NOTIFY_RESUME (take 2)
Subsystems (2)
PATCH 1/1 remove unused TIF_NOTIFY_RESUME (take 2)
Hello,
This following patch removes the TIF_NOTIFY_RESUME flag for thread_info. It is unused on all but the IA-64 architecture. This is take 2 of this patch. In this version, The definition is removed but no re-numbering of the TIF flags is done to minimize the possibility of errors and reduce the size of the patch.
For IA-64, we ran out of low-order bits (first 7 bits). Adding a bit for perfmon would cause important code rescheduling changes in the kernel entry/exit path. Instead, we replace TIF_NOTIFY_RESUME with TIF_PERFMON_WORK. This way we get very close to what the new perfmon code base is doing.
thread_info: remove unused TIF_NOTIFY_RESUME, add TIF_PERFMON_WORK to IA-64
arch/arm/kernel/entry-common.S +1 -1
@@ -46,7 +46,7 @@ fast_work_pending: work_pending: tst r1, #_TIF_NEED_RESCHED bne work_resched - tst r1, #_TIF_NOTIFY_RESUME | _TIF_SIGPENDING + tst r1, #_TIF_SIGPENDING beq no_work_pending mov r0, sp @ 'regs' mov r2, why @ 'syscall'
arch/arm26/kernel/entry.S +1 -1
@@ -194,7 +194,7 @@ fast_work_pending: work_pending: tst r1, #_TIF_NEED_RESCHED bne work_resched - tst r1, #_TIF_NOTIFY_RESUME | _TIF_SIGPENDING + tst r1, #_TIF_SIGPENDING beq no_work_pending mov r0, sp @ 'regs' mov r2, why @ 'syscall'
arch/ia64/kernel/perfmon.c +9 -13
@@ -361,9 +361,6 @@ typedef struct pfm_context {#define ctx_fl_no_msg ctx_flags.no_msg#define ctx_fl_can_restart ctx_flags.can_restart -#define PFM_SET_WORK_PENDING (t, v) do { (t)->thread.pfm_needs_checking = v; } while(0); -#define PFM_GET_WORK_PENDING (t) (t)->thread.pfm_needs_checking -/* * global information about all sessions * mostly used to synchronize between system wide and per-process
@@ -591,13 +588,13 @@ pfm_set_task_notify(struct task_struct *task)struct thread_info *info; info = (struct thread_info *) ((char *) task +IA64_TASK_SIZE ); -set_bit (TIF_NOTIFY_RESUME , &info->flags); +set_bit (TIF_PERFMON_WORK , &info->flags); }static inline void pfm_clear_task_notify (void ) { -clear_thread_flag (TIF_NOTIFY_RESUME ); +clear_thread_flag (TIF_PERFMON_WORK ); } static inline void
@@ -3728,7 +3725,7 @@ pfm_restart(pfm_context_t *ctx, void *arg, int count, struct pt_regs *regs) ctx->ctx_fl_trap_reason =PFM_TRAP_REASON_RESET ; -PFM_SET_WORK_PENDING (task,1 ); +set_ti_thread_flag (task_thread_info (task),TIF_PERFMON_WORK );pfm_set_task_notify (task);
@@ -4609,7 +4606,7 @@ pfm_context_unload(pfm_context_t *ctx, void *arg, int count, struct pt_regs *reg task->thread.pfm_context =NULL ; ctx->ctx_task =NULL ; -PFM_SET_WORK_PENDING (task,0 ); +clear_ti_thread_flag (task_thread_info (task),TIF_PERFMON_WORK ); ctx->ctx_fl_trap_reason =PFM_TRAP_REASON_NONE ; ctx->ctx_fl_can_restart =0 ;
@@ -5085,7 +5082,7 @@ pfm_handle_work(void)PROTECT_CTX (ctx, flags); -PFM_SET_WORK_PENDING (current,0 ); +clear_thread_flag (TIF_PERFMON_WORK );pfm_clear_task_notify ();
@@ -5449,7 +5446,7 @@ pfm_overflow_handler(struct task_struct *task, pfm_context_t *ctx, u64 pmc0, str/* * set the perfmon specific checking pending work for the task */ -PFM_SET_WORK_PENDING (task,1 ); +set_ti_thread_flag (task_thread_info (task),TIF_PERFMON_WORK );/* * when coming from ctxsw, current still points to the
@@ -5464,9 +5461,8 @@ pfm_overflow_handler(struct task_struct *task, pfm_context_t *ctx, u64 pmc0, str must_notify =1 ; } - DPRINT_ovfl(("owner [%d] pending=%ld reason=%u ovfl_pmds=0x%lx ovfl_notify=0x%lx masked=%d\n", + DPRINT_ovfl(("owner [%d] reason=%u ovfl_pmds=0x%lx ovfl_notify=0x%lx masked=%d\n", GET_PMU_OWNER() ? GET_PMU_OWNER()->pid : -1, - PFM_GET_WORK_PENDING(task), ctx->ctx_fl_trap_reason, ovfl_pmds, ovfl_notify,
@@ -5884,7 +5880,7 @@ pfm_force_cleanup(pfm_context_t *ctx, struct pt_regs *regs)/* * disconnect the task from the context and vice-versa */ -PFM_SET_WORK_PENDING (task,0 ); +clear_ti_thread_flag (task_thread_info (task),TIF_PERFMON_WORK ); task->thread.pfm_context =NULL ; task->thread.flags &= ~IA64_THREAD_PM_VALID ;
@@ -6864,7 +6860,7 @@ pfm_inherit(struct task_struct *task, struct pt_regs *regs)*/ thread->pfm_context =NULL ; -PFM_SET_WORK_PENDING (task,0 ); +clear_ti_thread_flag (task_thread_info (task),TIF_PERFMON_WORK );/* * the psr bits are already set properly in copy_threads()
arch/ia64/kernel/process.c +1 -1
@@ -165,7 +165,7 @@ do_notify_resume_user (sigset_t *unused, struct sigscratch *scr, long in_syscall }#ifdef CONFIG_PERFMON -if (current->thread.pfm_needs_checking) +if (test_thread_flag (TIF_PERFMON_WORK ))pfm_handle_work ();#endif
arch/powerpc/kernel/entry_64.S +0 -1
@@ -546,7 +546,6 @@ END_FW_FTR_SECTION_IFSET(FW_FEATURE_ISERIES) rfid b . /* prevent speculative execution */ -/* Note: this must change if we start using the TIF_NOTIFY_RESUME bit */ do_work: #ifdef CONFIG_PREEMPT andi. r0,r3,MSR_PR /* Returning to user mode? */
arch/x86_64/kernel/entry.S +3 -3
@@ -282,7 +282,7 @@ sysret_careful: sysret_signal: TRACE_IRQS_ON sti - testl $(_TIF_SIGPENDING|_TIF_NOTIFY_RESUME|_TIF_SINGLESTEP|_TIF_MCE_NOTIFY),%edx + testl $(_TIF_SIGPENDING|_TIF_SINGLESTEP|_TIF_MCE_NOTIFY),%edx jz 1f /* Really a signal */
@@ -375,7 +375,7 @@ int_very_careful: jmp int_restore_rest int_signal: - testl $(_TIF_NOTIFY_RESUME|_TIF_SIGPENDING|_TIF_SINGLESTEP|_TIF_MCE_NOTIFY),%edx + testl $(_TIF_SIGPENDING|_TIF_SINGLESTEP|_TIF_MCE_NOTIFY),%edx jz 1f movq %rsp,%rdi # &ptregs -> arg1 xorl %esi,%esi # oldset -> arg2
@@ -599,7 +599,7 @@ retint_careful: jmp retint_check retint_signal: - testl $(_TIF_SIGPENDING|_TIF_NOTIFY_RESUME|_TIF_SINGLESTEP|_TIF_MCE_NOTIFY),%edx + testl $(_TIF_SIGPENDING|_TIF_SINGLESTEP|_TIF_MCE_NOTIFY),%edx jz retint_swapgs TRACE_IRQS_ON sti
include/asm-alpha/thread_info.h +1 -4
@@ -67,7 +67,6 @@ register struct thread_info *__current_thread_info __asm__("$8");* TIF_SYSCALL_TRACE is known to be 0 via blbs. */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_POLLING_NRFLAG 4/* poll_idle is polling NEED_RESCHED */
@@ -79,15 +78,13 @@ register struct thread_info *__current_thread_info __asm__("$8");#define TIF_RESTORE_SIGMASK 10/* restore signal mask in do_signal */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)#define _TIF_RESTORE_SIGMASK (1<<TIF_RESTORE_SIGMASK)/* Work to do on interrupt/exception return. */ -#define _TIF_WORK_MASK (_TIF_NOTIFY_RESUME \ - | _TIF_SIGPENDING \ +#define _TIF_WORK_MASK ( _TIF_SIGPENDING \ | _TIF_NEED_RESCHED)/* Work to do on any return to userspace. */
include/asm-arm/thread_info.h +0 -3
@@ -134,13 +134,11 @@ extern void iwmmxt_task_switch(struct thread_info *);/* * thread information flags: * TIF_SYSCALL_TRACE - syscall trace active -* TIF_NOTIFY_RESUME - resumption notification requested * TIF_SIGPENDING - signal pending * TIF_NEED_RESCHED - rescheduling necessary * TIF_USEDFPU - FPU was used by this task this quantum (SMP) * TIF_POLLING_NRFLAG - true if poll_idle() is polling TIF_NEED_RESCHED */ -#define TIF_NOTIFY_RESUME 0#define TIF_SIGPENDING 1#define TIF_NEED_RESCHED 2#define TIF_SYSCALL_TRACE 8
@@ -149,7 +147,6 @@ extern void iwmmxt_task_switch(struct thread_info *);#define TIF_MEMDIE 18#define TIF_FREEZE 19 -#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)#define _TIF_SYSCALL_TRACE (1 << TIF_SYSCALL_TRACE)
include/asm-arm26/thread_info.h +0 -3
@@ -110,13 +110,11 @@ extern void free_thread_info(struct thread_info *);/* * thread information flags: * TIF_SYSCALL_TRACE - syscall trace active -* TIF_NOTIFY_RESUME - resumption notification requested * TIF_SIGPENDING - signal pending * TIF_NEED_RESCHED - rescheduling necessary * TIF_USEDFPU - FPU was used by this task this quantum (SMP) * TIF_POLLING_NRFLAG - true if poll_idle() is polling TIF_NEED_RESCHED */ -#define TIF_NOTIFY_RESUME 0#define TIF_SIGPENDING 1#define TIF_NEED_RESCHED 2#define TIF_SYSCALL_TRACE 8
@@ -124,7 +122,6 @@ extern void free_thread_info(struct thread_info *);#define TIF_POLLING_NRFLAG 17#define TIF_MEMDIE 18 -#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)#define _TIF_SYSCALL_TRACE (1 << TIF_SYSCALL_TRACE)
include/asm-avr32/thread_info.h +0 -2
@@ -74,7 +74,6 @@ static inline struct thread_info *current_thread_info(void)* - other flags in MSW */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_POLLING_NRFLAG 4/* true if poll_idle() is polling
@@ -87,7 +86,6 @@ static inline struct thread_info *current_thread_info(void)#define TIF_USERSPACE 31/* true if FS sets userspace */ #define _TIF_SYSCALL_TRACE (1 << TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1 << TIF_POLLING_NRFLAG)
include/asm-blackfin/thread_info.h +0 -2
@@ -118,7 +118,6 @@ static inline struct thread_info *current_thread_info(void)* thread information flag bit numbers */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_POLLING_NRFLAG 4/* true if poll_idle() is polling
@@ -129,7 +128,6 @@ static inline struct thread_info *current_thread_info(void)/* as above, but as bit values */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)
include/asm-cris/thread_info.h +0 -2
@@ -79,14 +79,12 @@ struct thread_info {* - other flags in MSW */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_POLLING_NRFLAG 16/* true if poll_idle() is polling TIF_NEED_RESCHED */ #define TIF_MEMDIE 17#define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)
include/asm-frv/thread_info.h +0 -2
@@ -108,7 +108,6 @@ register struct thread_info *__current_thread_info asm("gr15");* - other flags in MSW */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_SINGLESTEP 4/* restore singlestep on return to user mode */
@@ -119,7 +118,6 @@ register struct thread_info *__current_thread_info asm("gr15");#define TIF_FREEZE 18/* freezing for suspend */ #define _TIF_SYSCALL_TRACE (1 << TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)#define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP)
include/asm-h8300/thread_info.h +0 -2
@@ -86,7 +86,6 @@ static inline struct thread_info *current_thread_info(void)* thread information flag bit numbers */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_POLLING_NRFLAG 4/* true if poll_idle() is polling
@@ -96,7 +95,6 @@ static inline struct thread_info *current_thread_info(void)/* as above, but as bit values */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)
include/asm-i386/thread_info.h +0 -2
@@ -124,7 +124,6 @@ static inline struct thread_info *current_thread_info(void)* - other flags in MSW */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_SINGLESTEP 4/* restore singlestep on return to user mode */
@@ -140,7 +139,6 @@ static inline struct thread_info *current_thread_info(void)#define TIF_NOTSC 20/* TSC is not accessible in userland */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_SINGLESTEP (1<<TIF_SINGLESTEP)
include/asm-ia64/thread_info.h +4 -3
@@ -79,7 +79,7 @@ struct thread_info {* - pending work-to-be-done flags are in least-significant 16 bits, other flags * in top 16 bits */ -#define TIF_NOTIFY_RESUME 0/* resumption notification requested */ +#define TIF_PERFMON_WORK 0/* work for pfm_handle_work() */ #define TIF_SIGPENDING 1/* signal pending */ #define TIF_NEED_RESCHED 2/* rescheduling necessary */ #define TIF_SYSCALL_TRACE 3/* syscall trace active */
@@ -96,7 +96,6 @@ struct thread_info {#define _TIF_SYSCALL_AUDIT (1 << TIF_SYSCALL_AUDIT)#define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP)#define _TIF_SYSCALL_TRACEAUDIT (_TIF_SYSCALL_TRACE|_TIF_SYSCALL_AUDIT|_TIF_SINGLESTEP) -#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)#define _TIF_RESTORE_SIGMASK (1 << TIF_RESTORE_SIGMASK)#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)
@@ -104,9 +103,11 @@ struct thread_info {#define _TIF_MCA_INIT (1 << TIF_MCA_INIT)#define _TIF_DB_DISABLED (1 << TIF_DB_DISABLED)#define _TIF_FREEZE (1 << TIF_FREEZE) +#define _TIF_PERFMON_WORK (1 << TIF_PERFMON_WORK)/* "work to do on user-return" bits */ -#define TIF_ALLWORK_MASK (_TIF_NOTIFY_RESUME|_TIF_SIGPENDING|_TIF_NEED_RESCHED|_TIF_SYSCALL_TRACE|_TIF_SYSCALL_AUDIT|_TIF_RESTORE_SIGMASK) +#define TIF_ALLWORK_MASK (_TIF_SIGPENDING|_TIF_NEED_RESCHED|_TIF_SYSCALL_TRACE|\ + _TIF_PERFMON_WORK|_TIF_SYSCALL_AUDIT|_TIF_RESTORE_SIGMASK)/* like TIF_ALLWORK_BITS but sans TIF_SYSCALL_TRACE or TIF_SYSCALL_AUDIT */ #define TIF_WORK_MASK (TIF_ALLWORK_MASK&~(_TIF_SYSCALL_TRACE|_TIF_SYSCALL_AUDIT))
include/asm-m32r/thread_info.h +0 -2
@@ -146,7 +146,6 @@ static inline unsigned int get_thread_fault_code(void)* - other flags in MSW */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_SINGLESTEP 4/* restore singlestep on return to user mode */
@@ -156,7 +155,6 @@ static inline unsigned int get_thread_fault_code(void)#define TIF_MEMDIE 17#define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_SINGLESTEP (1<<TIF_SINGLESTEP)
include/asm-m68knommu/thread_info.h +0 -2
@@ -83,7 +83,6 @@ static inline struct thread_info *current_thread_info(void)* thread information flag bit numbers */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_POLLING_NRFLAG 4/* true if poll_idle() is polling
@@ -92,7 +91,6 @@ static inline struct thread_info *current_thread_info(void)/* as above, but as bit values */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)
include/asm-mips/thread_info.h +0 -2
@@ -109,7 +109,6 @@ register struct thread_info *__current_thread_info __asm__("$28");* - pending work-to-be-done flags are in LSW * - other flags in MSW */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_SYSCALL_AUDIT 4/* syscall auditing active */
@@ -122,7 +121,6 @@ register struct thread_info *__current_thread_info __asm__("$28");#define TIF_SYSCALL_TRACE 31/* syscall trace active */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_SYSCALL_AUDIT (1<<TIF_SYSCALL_AUDIT)
include/asm-parisc/thread_info.h +1 -3
@@ -56,7 +56,6 @@ struct thread_info {* thread information flags */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_POLLING_NRFLAG 4/* true if poll_idle() is polling TIF_NEED_RESCHED */
@@ -65,14 +64,13 @@ struct thread_info {#define TIF_RESTORE_SIGMASK 7/* restore saved signal mask */ #define _TIF_SYSCALL_TRACE (1 << TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1 << TIF_POLLING_NRFLAG)#define _TIF_32BIT (1 << TIF_32BIT)#define _TIF_RESTORE_SIGMASK (1 << TIF_RESTORE_SIGMASK) -#define _TIF_USER_WORK_MASK (_TIF_NOTIFY_RESUME | _TIF_SIGPENDING | \ +#define _TIF_USER_WORK_MASK ( _TIF_SIGPENDING | \ _TIF_NEED_RESCHED | _TIF_RESTORE_SIGMASK)#endif /* __KERNEL__ */
include/asm-powerpc/thread_info.h +1 -3
@@ -107,7 +107,6 @@ static inline struct thread_info *current_thread_info(void)* thread information flag bit numbers */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_POLLING_NRFLAG 4/* true if poll_idle() is polling
@@ -128,7 +127,6 @@ static inline struct thread_info *current_thread_info(void)/* as above, but as bit values */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)
@@ -146,7 +144,7 @@ static inline struct thread_info *current_thread_info(void)#define _TIF_ABI_PENDING (1<<TIF_ABI_PENDING)#define _TIF_SYSCALL_T_OR_A (_TIF_SYSCALL_TRACE|_TIF_SYSCALL_AUDIT|_TIF_SECCOMP) -#define _TIF_USER_WORK_MASK (_TIF_NOTIFY_RESUME | _TIF_SIGPENDING | \ +#define _TIF_USER_WORK_MASK ( _TIF_SIGPENDING | \ _TIF_NEED_RESCHED | _TIF_RESTORE_SIGMASK)#define _TIF_PERSYSCALL_MASK (_TIF_RESTOREALL|_TIF_NOERROR)
include/asm-sh/thread_info.h +0 -2
@@ -107,7 +107,6 @@ static inline struct thread_info *current_thread_info(void)* - other flags in MSW */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_RESTORE_SIGMASK 4/* restore signal mask in do_signal() */
@@ -118,7 +117,6 @@ static inline struct thread_info *current_thread_info(void)#define TIF_FREEZE 19#define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_RESTORE_SIGMASK (1<<TIF_RESTORE_SIGMASK)
include/asm-v850/thread_info.h +0 -2
@@ -77,7 +77,6 @@ struct thread_info {* thread information flag bit numbers */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_POLLING_NRFLAG 4/* true if poll_idle() is polling
@@ -86,7 +85,6 @@ struct thread_info {/* as above, but as bit values */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)
include/asm-x86_64/thread_info.h +0 -2
@@ -107,7 +107,6 @@ static inline struct thread_info *stack_thread_info(void)* Warning: layout of LSW is hardcoded in entry.S */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_SINGLESTEP 4/* reenable singlestep on user return*/
@@ -126,7 +125,6 @@ static inline struct thread_info *stack_thread_info(void)#define TIF_FREEZE 23/* is freezing for suspend */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_SINGLESTEP (1<<TIF_SINGLESTEP)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)
include/asm-xtensa/thread_info.h +0 -2
@@ -110,7 +110,6 @@ static inline struct thread_info *current_thread_info(void)* - other flags in MSW */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_SINGLESTEP 4/* restore singlestep on return to user mode */
@@ -120,7 +119,6 @@ static inline struct thread_info *current_thread_info(void)#define TIF_POLLING_NRFLAG 16/* true if poll_idle() is polling TIF_NEED_RESCHED */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_SINGLESTEP (1<<TIF_SINGLESTEP)
Quoted 9 lines · On Mon, 30 Jul 2007 02:30:34 -0700 Stephane Eranian <[email protected]> wrote:
This following patch removes the
TIF_NOTIFY_RESUMEflag forthread_info. It is unused on all but the IA-64 architecture. This is take 2 of this patch. In this version, The definition is removed but no re-numbering of the TIF flags is done to minimize the possibility of errors and reduce the size of the patch.For IA-64, we ran out of low-order bits (first 7 bits). Adding a bit for perfmon would cause important code rescheduling changes in the kernel entry/exit path. Instead, we replace
TIF_NOTIFY_RESUMEwithTIF_PERFMON_WORK. This way we get very close to what the new perfmon code base is doing.
This has been (painfully) maintained in -mm for quite a long time. I've been waiting for everyone else to merge their stuff so I can get it in without disrupting them. This has now happened.
I think it'd be better to merge the larger patch - it's a bit tidier and more tested, OK?
From: Stephane Eranian <[email protected]>
Remove unused TIF_NOTIFY_RESUME flag for all processor architectures. The flag was not used excecpt on IA-64 where the patch replaces it with TIF_PERFMON_WORK.
---
arch/arm/kernel/entry-common.S | 2 - arch/arm26/kernel/entry.S | 2 - arch/ia64/kernel/perfmon.c | 4 +- arch/powerpc/kernel/entry_64.S | 1 arch/x86_64/kernel/entry.S | 6 ++-- include/asm-alpha/thread_info.h | 24 +++++++---------- include/asm-arm/thread_info.h | 7 +---- include/asm-arm26/thread_info.h | 7 +---- include/asm-avr32/thread_info.h | 18 +++++-------- include/asm-blackfin/thread_info.h | 14 ++++------ include/asm-cris/thread_info.h | 6 +--- include/asm-frv/thread_info.h | 12 +++----- include/asm-h8300/thread_info.h | 12 +++----- include/asm-i386/thread_info.h | 18 +++++-------- include/asm-ia64/thread_info.h | 20 +++++++------- include/asm-m32r/thread_info.h | 10 ++----- include/asm-m68knommu/thread_info.h | 10 ++----- include/asm-mips/thread_info.h | 10 ++----- include/asm-parisc/thread_info.h | 16 +++++------ include/asm-powerpc/thread_info.h | 36 ++++++++++++-------------- include/asm-sh/thread_info.h | 10 ++----- include/asm-v850/thread_info.h | 10 ++----- include/asm-x86_64/thread_info.h | 2 - include/asm-xtensa/thread_info.h | 14 ++++------ 24 files changed, 116 insertions(+), 155 deletions(-)
arch/arm26/kernel/entry.S renamed from arch/arm26/kernel/entry.S~remove-unused-tif_notify_resume-flag +1 -1
@@ -194,7 +194,7 @@ fast_work_pending: work_pending: tst r1, #_TIF_NEED_RESCHED bne work_resched - tst r1, #_TIF_NOTIFY_RESUME | _TIF_SIGPENDING + tst r1, #_TIF_SIGPENDING beq no_work_pending mov r0, sp @ 'regs' mov r2, why @ 'syscall'
arch/arm/kernel/entry-common.S renamed from arch/arm/kernel/entry-common.S~remove-unused-tif_notify_resume-flag +1 -1
@@ -46,7 +46,7 @@ fast_work_pending: work_pending: tst r1, #_TIF_NEED_RESCHED bne work_resched - tst r1, #_TIF_NOTIFY_RESUME | _TIF_SIGPENDING + tst r1, #_TIF_SIGPENDING beq no_work_pending mov r0, sp @ 'regs' mov r2, why @ 'syscall'
arch/ia64/kernel/perfmon.c renamed from arch/ia64/kernel/perfmon.c~remove-unused-tif_notify_resume-flag +2 -2
@@ -591,13 +591,13 @@ pfm_set_task_notify(struct task_struct *struct thread_info *info; info = (struct thread_info *) ((char *) task +IA64_TASK_SIZE ); -set_bit (TIF_NOTIFY_RESUME , &info->flags); +set_bit (TIF_PERFMON_WORK , &info->flags); }static inline void pfm_clear_task_notify (void ) { -clear_thread_flag (TIF_NOTIFY_RESUME ); +clear_thread_flag (TIF_PERFMON_WORK ); } static inline void
arch/powerpc/kernel/entry_64.S renamed from arch/powerpc/kernel/entry_64.S~remove-unused-tif_notify_resume-flag +0 -1
@@ -546,7 +546,6 @@ END_FW_FTR_SECTION_IFSET(FW_FEATURE_ISER rfid b . /* prevent speculative execution */ -/* Note: this must change if we start using the TIF_NOTIFY_RESUME bit */ do_work: #ifdef CONFIG_PREEMPT andi. r0,r3,MSR_PR /* Returning to user mode? */
arch/x86_64/kernel/entry.S renamed from arch/x86_64/kernel/entry.S~remove-unused-tif_notify_resume-flag +3 -3
@@ -282,7 +282,7 @@ sysret_careful: sysret_signal: TRACE_IRQS_ON sti - testl $(_TIF_SIGPENDING|_TIF_NOTIFY_RESUME|_TIF_SINGLESTEP|_TIF_MCE_NOTIFY),%edx + testl $(_TIF_SIGPENDING|_TIF_SINGLESTEP|_TIF_MCE_NOTIFY),%edx jz 1f /* Really a signal */
@@ -375,7 +375,7 @@ int_very_careful: jmp int_restore_rest int_signal: - testl $(_TIF_NOTIFY_RESUME|_TIF_SIGPENDING|_TIF_SINGLESTEP|_TIF_MCE_NOTIFY),%edx + testl $(_TIF_SIGPENDING|_TIF_SINGLESTEP|_TIF_MCE_NOTIFY),%edx jz 1f movq %rsp,%rdi # &ptregs -> arg1 xorl %esi,%esi # oldset -> arg2
@@ -599,7 +599,7 @@ retint_careful: jmp retint_check retint_signal: - testl $(_TIF_SIGPENDING|_TIF_NOTIFY_RESUME|_TIF_SINGLESTEP|_TIF_MCE_NOTIFY),%edx + testl $(_TIF_SIGPENDING|_TIF_SINGLESTEP|_TIF_MCE_NOTIFY),%edx jz retint_swapgs TRACE_IRQS_ON sti
include/asm-alpha/thread_info.h renamed from include/asm-alpha/thread_info.h~remove-unused-tif_notify_resume-flag +10 -14
@@ -67,28 +67,24 @@ register struct thread_info *__current_t* TIF_SYSCALL_TRACE is known to be 0 via blbs. */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ -#define TIF_SIGPENDING 2/* signal pending */ -#define TIF_NEED_RESCHED 3/* rescheduling necessary */ -#define TIF_POLLING_NRFLAG 4/* poll_idle is polling NEED_RESCHED */ -#define TIF_DIE_IF_KERNEL 5/* dik recursion lock */ -#define TIF_UAC_NOPRINT 6/* see sysinfo.h */ -#define TIF_UAC_NOFIX 7 -#define TIF_UAC_SIGBUS 8 -#define TIF_MEMDIE 9 -#define TIF_RESTORE_SIGMASK 10/* restore signal mask in do_signal */ +#define TIF_SIGPENDING 1/* signal pending */ +#define TIF_NEED_RESCHED 2/* rescheduling necessary */ +#define TIF_POLLING_NRFLAG 3/* poll_idle is polling NEED_RESCHED */ +#define TIF_DIE_IF_KERNEL 4/* dik recursion lock */ +#define TIF_UAC_NOPRINT 5/* see sysinfo.h */ +#define TIF_UAC_NOFIX 6 +#define TIF_UAC_SIGBUS 7 +#define TIF_MEMDIE 8 +#define TIF_RESTORE_SIGMASK 9/* restore signal mask in do_signal */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)#define _TIF_RESTORE_SIGMASK (1<<TIF_RESTORE_SIGMASK)/* Work to do on interrupt/exception return. */ -#define _TIF_WORK_MASK (_TIF_NOTIFY_RESUME \ - | _TIF_SIGPENDING \ - | _TIF_NEED_RESCHED) +#define _TIF_WORK_MASK (_TIF_SIGPENDING | _TIF_NEED_RESCHED)/* Work to do on any return to userspace. */ #define _TIF_ALLWORK_MASK (_TIF_WORK_MASK \
include/asm-arm26/thread_info.h renamed from include/asm-arm26/thread_info.h~remove-unused-tif_notify_resume-flag +2 -5
@@ -110,21 +110,18 @@ extern void free_thread_info(struct thre/* * thread information flags: * TIF_SYSCALL_TRACE - syscall trace active -* TIF_NOTIFY_RESUME - resumption notification requested * TIF_SIGPENDING - signal pending * TIF_NEED_RESCHED - rescheduling necessary * TIF_USEDFPU - FPU was used by this task this quantum (SMP) * TIF_POLLING_NRFLAG - true if poll_idle() is polling TIF_NEED_RESCHED */ -#define TIF_NOTIFY_RESUME 0 -#define TIF_SIGPENDING 1 -#define TIF_NEED_RESCHED 2 +#define TIF_SIGPENDING 0 +#define TIF_NEED_RESCHED 1#define TIF_SYSCALL_TRACE 8#define TIF_USED_FPU 16#define TIF_POLLING_NRFLAG 17#define TIF_MEMDIE 18 -#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)#define _TIF_SYSCALL_TRACE (1 << TIF_SYSCALL_TRACE)
include/asm-arm/thread_info.h renamed from include/asm-arm/thread_info.h~remove-unused-tif_notify_resume-flag +2 -5
@@ -134,22 +134,19 @@ extern void iwmmxt_task_switch(struct th/* * thread information flags: * TIF_SYSCALL_TRACE - syscall trace active -* TIF_NOTIFY_RESUME - resumption notification requested * TIF_SIGPENDING - signal pending * TIF_NEED_RESCHED - rescheduling necessary * TIF_USEDFPU - FPU was used by this task this quantum (SMP) * TIF_POLLING_NRFLAG - true if poll_idle() is polling TIF_NEED_RESCHED */ -#define TIF_NOTIFY_RESUME 0 -#define TIF_SIGPENDING 1 -#define TIF_NEED_RESCHED 2 +#define TIF_SIGPENDING 0 +#define TIF_NEED_RESCHED 1#define TIF_SYSCALL_TRACE 8#define TIF_POLLING_NRFLAG 16#define TIF_USING_IWMMXT 17#define TIF_MEMDIE 18#define TIF_FREEZE 19 -#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)#define _TIF_SYSCALL_TRACE (1 << TIF_SYSCALL_TRACE)
include/asm-avr32/thread_info.h renamed from include/asm-avr32/thread_info.h~remove-unused-tif_notify_resume-flag +8 -10
@@ -74,20 +74,18 @@ static inline struct thread_info *curren* - other flags in MSW */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ -#define TIF_SIGPENDING 2/* signal pending */ -#define TIF_NEED_RESCHED 3/* rescheduling necessary */ -#define TIF_POLLING_NRFLAG 4/* true if poll_idle() is polling +#define TIF_SIGPENDING 1/* signal pending */ +#define TIF_NEED_RESCHED 2/* rescheduling necessary */ +#define TIF_POLLING_NRFLAG 3/* true if poll_idle() is polling TIF_NEED_RESCHED */ -#define TIF_BREAKPOINT 5/* true if we should break after return */ -#define TIF_SINGLE_STEP 6/* single step after next break */ -#define TIF_MEMDIE 7 -#define TIF_RESTORE_SIGMASK 8/* restore signal mask in do_signal */ -#define TIF_CPU_GOING_TO_SLEEP 9/* CPU is entering sleep 0 mode */ +#define TIF_BREAKPOINT 4/* true if we should break after return */ +#define TIF_SINGLE_STEP 5/* single step after next break */ +#define TIF_MEMDIE 6 +#define TIF_RESTORE_SIGMASK 7/* restore signal mask in do_signal */ +#define TIF_CPU_GOING_TO_SLEEP 8/* CPU is entering sleep 0 mode */ #define TIF_USERSPACE 31/* true if FS sets userspace */ #define _TIF_SYSCALL_TRACE (1 << TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1 << TIF_POLLING_NRFLAG)
include/asm-blackfin/thread_info.h renamed from include/asm-blackfin/thread_info.h~remove-unused-tif_notify_resume-flag +6 -8
@@ -118,18 +118,16 @@ static inline struct thread_info *curren* thread information flag bit numbers */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ -#define TIF_SIGPENDING 2/* signal pending */ -#define TIF_NEED_RESCHED 3/* rescheduling necessary */ -#define TIF_POLLING_NRFLAG 4/* true if poll_idle() is polling +#define TIF_SIGPENDING 1/* signal pending */ +#define TIF_NEED_RESCHED 2/* rescheduling necessary */ +#define TIF_POLLING_NRFLAG 3/* true if poll_idle() is polling TIF_NEED_RESCHED */ -#define TIF_MEMDIE 5 -#define TIF_RESTORE_SIGMASK 6/* restore signal mask in do_signal() */ -#define TIF_FREEZE 7/* is freezing for suspend */ +#define TIF_MEMDIE 4 +#define TIF_RESTORE_SIGMASK 5/* restore signal mask in do_signal() */ +#define TIF_FREEZE 6/* is freezing for suspend */ /* as above, but as bit values */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)
include/asm-cris/thread_info.h renamed from include/asm-cris/thread_info.h~remove-unused-tif_notify_resume-flag +2 -4
@@ -79,14 +79,12 @@ struct thread_info {* - other flags in MSW */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ -#define TIF_SIGPENDING 2/* signal pending */ -#define TIF_NEED_RESCHED 3/* rescheduling necessary */ +#define TIF_SIGPENDING 1/* signal pending */ +#define TIF_NEED_RESCHED 2/* rescheduling necessary */ #define TIF_POLLING_NRFLAG 16/* true if poll_idle() is polling TIF_NEED_RESCHED */ #define TIF_MEMDIE 17#define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)
include/asm-frv/thread_info.h renamed from include/asm-frv/thread_info.h~remove-unused-tif_notify_resume-flag +5 -7
@@ -108,18 +108,16 @@ register struct thread_info *__current_t* - other flags in MSW */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ -#define TIF_SIGPENDING 2/* signal pending */ -#define TIF_NEED_RESCHED 3/* rescheduling necessary */ -#define TIF_SINGLESTEP 4/* restore singlestep on return to user mode */ -#define TIF_IRET 5/* return with iret */ -#define TIF_RESTORE_SIGMASK 6/* restore signal mask in do_signal() */ +#define TIF_SIGPENDING 1/* signal pending */ +#define TIF_NEED_RESCHED 2/* rescheduling necessary */ +#define TIF_SINGLESTEP 3/* restore singlestep on return to user mode */ +#define TIF_IRET 4/* return with iret */ +#define TIF_RESTORE_SIGMASK 5/* restore signal mask in do_signal() */ #define TIF_POLLING_NRFLAG 16/* true if poll_idle() is polling TIF_NEED_RESCHED */ #define TIF_MEMDIE 17/* OOM killer killed process */ #define TIF_FREEZE 18/* freezing for suspend */ #define _TIF_SYSCALL_TRACE (1 << TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)#define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP)
include/asm-h8300/thread_info.h renamed from include/asm-h8300/thread_info.h~remove-unused-tif_notify_resume-flag +5 -7
@@ -86,17 +86,15 @@ static inline struct thread_info *curren* thread information flag bit numbers */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ -#define TIF_SIGPENDING 2/* signal pending */ -#define TIF_NEED_RESCHED 3/* rescheduling necessary */ -#define TIF_POLLING_NRFLAG 4/* true if poll_idle() is polling +#define TIF_SIGPENDING 1/* signal pending */ +#define TIF_NEED_RESCHED 2/* rescheduling necessary */ +#define TIF_POLLING_NRFLAG 3/* true if poll_idle() is polling TIF_NEED_RESCHED */ -#define TIF_MEMDIE 5 -#define TIF_RESTORE_SIGMASK 6/* restore signal mask in do_signal() */ +#define TIF_MEMDIE 4 +#define TIF_RESTORE_SIGMASK 5/* restore signal mask in do_signal() */ /* as above, but as bit values */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)
include/asm-i386/thread_info.h renamed from include/asm-i386/thread_info.h~remove-unused-tif_notify_resume-flag +8 -10
@@ -124,15 +124,14 @@ static inline struct thread_info *curren* - other flags in MSW */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ -#define TIF_SIGPENDING 2/* signal pending */ -#define TIF_NEED_RESCHED 3/* rescheduling necessary */ -#define TIF_SINGLESTEP 4/* restore singlestep on return to user mode */ -#define TIF_IRET 5/* return with iret */ -#define TIF_SYSCALL_EMU 6/* syscall emulation active */ -#define TIF_SYSCALL_AUDIT 7/* syscall auditing active */ -#define TIF_SECCOMP 8/* secure computing */ -#define TIF_RESTORE_SIGMASK 9/* restore signal mask in do_signal() */ +#define TIF_SIGPENDING 1/* signal pending */ +#define TIF_NEED_RESCHED 2/* rescheduling necessary */ +#define TIF_SINGLESTEP 3/* restore singlestep on return to user mode */ +#define TIF_IRET 4/* return with iret */ +#define TIF_SYSCALL_EMU 5/* syscall emulation active */ +#define TIF_SYSCALL_AUDIT 6/* syscall auditing active */ +#define TIF_SECCOMP 7/* secure computing */ +#define TIF_RESTORE_SIGMASK 8/* restore signal mask in do_signal() */ #define TIF_MEMDIE 16#define TIF_DEBUG 17/* uses debug registers */ #define TIF_IO_BITMAP 18/* uses I/O bitmap */
@@ -140,7 +139,6 @@ static inline struct thread_info *curren#define TIF_NOTSC 20/* TSC is not accessible in userland */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_SINGLESTEP (1<<TIF_SINGLESTEP)
include/asm-ia64/thread_info.h renamed from include/asm-ia64/thread_info.h~remove-unused-tif_notify_resume-flag +11 -9
@@ -79,13 +79,13 @@ struct thread_info {* - pending work-to-be-done flags are in least-significant 16 bits, other flags * in top 16 bits */ -#define TIF_NOTIFY_RESUME 0/* resumption notification requested */ -#define TIF_SIGPENDING 1/* signal pending */ -#define TIF_NEED_RESCHED 2/* rescheduling necessary */ -#define TIF_SYSCALL_TRACE 3/* syscall trace active */ -#define TIF_SYSCALL_AUDIT 4/* syscall auditing active */ -#define TIF_SINGLESTEP 5/* restore singlestep on return to user mode */ -#define TIF_RESTORE_SIGMASK 6/* restore signal mask in do_signal() */ +#define TIF_SIGPENDING 0/* signal pending */ +#define TIF_NEED_RESCHED 1/* rescheduling necessary */ +#define TIF_SYSCALL_TRACE 2/* syscall trace active */ +#define TIF_SYSCALL_AUDIT 3/* syscall auditing active */ +#define TIF_SINGLESTEP 4/* restore singlestep on return to user mode */ +#define TIF_RESTORE_SIGMASK 5/* restore signal mask in do_signal() */ +#define TIF_PERFMON_WORK 6/* work for pfm_handle_work() */ #define TIF_POLLING_NRFLAG 16/* true if poll_idle() is polling TIF_NEED_RESCHED */ #define TIF_MEMDIE 17#define TIF_MCA_INIT 18/* this task is processing MCA or INIT */
@@ -96,8 +96,8 @@ struct thread_info {#define _TIF_SYSCALL_AUDIT (1 << TIF_SYSCALL_AUDIT)#define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP)#define _TIF_SYSCALL_TRACEAUDIT (_TIF_SYSCALL_TRACE|_TIF_SYSCALL_AUDIT|_TIF_SINGLESTEP) -#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)#define _TIF_RESTORE_SIGMASK (1 << TIF_RESTORE_SIGMASK) +#define _TIF_PERFMON_WORK (1 << TIF_PERFMON_WORK)#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1 << TIF_POLLING_NRFLAG)
@@ -106,7 +106,9 @@ struct thread_info {#define _TIF_FREEZE (1 << TIF_FREEZE)/* "work to do on user-return" bits */ -#define TIF_ALLWORK_MASK (_TIF_NOTIFY_RESUME|_TIF_SIGPENDING|_TIF_NEED_RESCHED|_TIF_SYSCALL_TRACE|_TIF_SYSCALL_AUDIT|_TIF_RESTORE_SIGMASK) +#define TIF_ALLWORK_MASK (_TIF_SIGPENDING|_TIF_PERFMON_WORK|_TIF_SYSCALL_AUDIT|\ + _TIF_NEED_RESCHED| _TIF_SYSCALL_TRACE|\ + _TIF_RESTORE_SIGMASK)/* like TIF_ALLWORK_BITS but sans TIF_SYSCALL_TRACE or TIF_SYSCALL_AUDIT */ #define TIF_WORK_MASK (TIF_ALLWORK_MASK&~(_TIF_SYSCALL_TRACE|_TIF_SYSCALL_AUDIT))
include/asm-m32r/thread_info.h renamed from include/asm-m32r/thread_info.h~remove-unused-tif_notify_resume-flag +4 -6
@@ -146,17 +146,15 @@ static inline unsigned int get_thread_fa* - other flags in MSW */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ -#define TIF_SIGPENDING 2/* signal pending */ -#define TIF_NEED_RESCHED 3/* rescheduling necessary */ -#define TIF_SINGLESTEP 4/* restore singlestep on return to user mode */ -#define TIF_IRET 5/* return with iret */ +#define TIF_SIGPENDING 1/* signal pending */ +#define TIF_NEED_RESCHED 2/* rescheduling necessary */ +#define TIF_SINGLESTEP 3/* restore singlestep on return to user mode */ +#define TIF_IRET 4/* return with iret */ #define TIF_POLLING_NRFLAG 16/* true if poll_idle() is polling TIF_NEED_RESCHED */ /* 31..28 fault code */ #define TIF_MEMDIE 17#define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_SINGLESTEP (1<<TIF_SINGLESTEP)
include/asm-m68knommu/thread_info.h renamed from include/asm-m68knommu/thread_info.h~remove-unused-tif_notify_resume-flag +4 -6
@@ -83,16 +83,14 @@ static inline struct thread_info *curren* thread information flag bit numbers */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ -#define TIF_SIGPENDING 2/* signal pending */ -#define TIF_NEED_RESCHED 3/* rescheduling necessary */ -#define TIF_POLLING_NRFLAG 4/* true if poll_idle() is polling +#define TIF_SIGPENDING 1/* signal pending */ +#define TIF_NEED_RESCHED 2/* rescheduling necessary */ +#define TIF_POLLING_NRFLAG 3/* true if poll_idle() is polling TIF_NEED_RESCHED */ -#define TIF_MEMDIE 5 +#define TIF_MEMDIE 4/* as above, but as bit values */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)
include/asm-mips/thread_info.h renamed from include/asm-mips/thread_info.h~remove-unused-tif_notify_resume-flag +4 -6
@@ -109,11 +109,10 @@ register struct thread_info *__current_t* - pending work-to-be-done flags are in LSW * - other flags in MSW */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ -#define TIF_SIGPENDING 2/* signal pending */ -#define TIF_NEED_RESCHED 3/* rescheduling necessary */ -#define TIF_SYSCALL_AUDIT 4/* syscall auditing active */ -#define TIF_SECCOMP 5/* secure computing */ +#define TIF_SIGPENDING 1/* signal pending */ +#define TIF_NEED_RESCHED 2/* rescheduling necessary */ +#define TIF_SYSCALL_AUDIT 3/* syscall auditing active */ +#define TIF_SECCOMP 4/* secure computing */ #define TIF_RESTORE_SIGMASK 9/* restore signal mask in do_signal() */ #define TIF_USEDFPU 16/* FPU was used by this task this quantum (SMP) */ #define TIF_POLLING_NRFLAG 17/* true if poll_idle() is polling TIF_NEED_RESCHED */
@@ -122,7 +121,6 @@ register struct thread_info *__current_t#define TIF_SYSCALL_TRACE 31/* syscall trace active */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_SYSCALL_AUDIT (1<<TIF_SYSCALL_AUDIT)
include/asm-parisc/thread_info.h renamed from include/asm-parisc/thread_info.h~remove-unused-tif_notify_resume-flag +7 -9
@@ -56,23 +56,21 @@ struct thread_info {* thread information flags */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ -#define TIF_SIGPENDING 2/* signal pending */ -#define TIF_NEED_RESCHED 3/* rescheduling necessary */ -#define TIF_POLLING_NRFLAG 4/* true if poll_idle() is polling TIF_NEED_RESCHED */ -#define TIF_32BIT 5/* 32 bit binary */ -#define TIF_MEMDIE 6 -#define TIF_RESTORE_SIGMASK 7/* restore saved signal mask */ +#define TIF_SIGPENDING 1/* signal pending */ +#define TIF_NEED_RESCHED 2/* rescheduling necessary */ +#define TIF_POLLING_NRFLAG 3/* true if poll_idle() is polling TIF_NEED_RESCHED */ +#define TIF_32BIT 4/* 32 bit binary */ +#define TIF_MEMDIE 5 +#define TIF_RESTORE_SIGMASK 6/* restore saved signal mask */ #define _TIF_SYSCALL_TRACE (1 << TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1 << TIF_POLLING_NRFLAG)#define _TIF_32BIT (1 << TIF_32BIT)#define _TIF_RESTORE_SIGMASK (1 << TIF_RESTORE_SIGMASK) -#define _TIF_USER_WORK_MASK (_TIF_NOTIFY_RESUME | _TIF_SIGPENDING | \ +#define _TIF_USER_WORK_MASK (_TIF_SIGPENDING | \ _TIF_NEED_RESCHED | _TIF_RESTORE_SIGMASK)#endif /* __KERNEL__ */
include/asm-powerpc/thread_info.h renamed from include/asm-powerpc/thread_info.h~remove-unused-tif_notify_resume-flag +17 -19
@@ -107,28 +107,26 @@ static inline struct thread_info *curren* thread information flag bit numbers */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ -#define TIF_SIGPENDING 2/* signal pending */ -#define TIF_NEED_RESCHED 3/* rescheduling necessary */ -#define TIF_POLLING_NRFLAG 4/* true if poll_idle() is polling +#define TIF_SIGPENDING 1/* signal pending */ +#define TIF_NEED_RESCHED 2/* rescheduling necessary */ +#define TIF_POLLING_NRFLAG 3/* true if poll_idle() is polling TIF_NEED_RESCHED */ -#define TIF_32BIT 5/* 32 bit binary */ -#define TIF_PERFMON_WORK 6/* work for pfm_handle_work() */ -#define TIF_PERFMON_CTXSW 7/* perfmon needs ctxsw calls */ -#define TIF_SYSCALL_AUDIT 8/* syscall auditing active */ -#define TIF_SINGLESTEP 9/* singlestepping active */ -#define TIF_MEMDIE 10 -#define TIF_SECCOMP 11/* secure computing */ -#define TIF_RESTOREALL 12/* Restore all regs (implies NOERROR) */ -#define TIF_NOERROR 14/* Force successful syscall return */ -#define TIF_RESTORE_SIGMASK 15/* Restore signal mask in do_signal */ -#define TIF_FREEZE 16/* Freezing for suspend */ -#define TIF_RUNLATCH 17/* Is the runlatch enabled? */ -#define TIF_ABI_PENDING 18/* 32/64 bit switch needed */ +#define TIF_32BIT 4/* 32 bit binary */ +#define TIF_PERFMON_WORK 5/* work for pfm_handle_work() */ +#define TIF_PERFMON_CTXSW 6/* perfmon needs ctxsw calls */ +#define TIF_SYSCALL_AUDIT 7/* syscall auditing active */ +#define TIF_SINGLESTEP 8/* singlestepping active */ +#define TIF_MEMDIE 9 +#define TIF_SECCOMP 10/* secure computing */ +#define TIF_RESTOREALL 11/* Restore all regs (implies NOERROR) */ +#define TIF_NOERROR 12/* Force successful syscall return */ +#define TIF_RESTORE_SIGMASK 13/* Restore signal mask in do_signal */ +#define TIF_FREEZE 14/* Freezing for suspend */ +#define TIF_RUNLATCH 15/* Is the runlatch enabled? */ +#define TIF_ABI_PENDING 16/* 32/64 bit switch needed */ /* as above, but as bit values */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)
@@ -146,7 +144,7 @@ static inline struct thread_info *curren#define _TIF_ABI_PENDING (1<<TIF_ABI_PENDING)#define _TIF_SYSCALL_T_OR_A (_TIF_SYSCALL_TRACE|_TIF_SYSCALL_AUDIT|_TIF_SECCOMP) -#define _TIF_USER_WORK_MASK (_TIF_NOTIFY_RESUME | _TIF_SIGPENDING | \ +#define _TIF_USER_WORK_MASK ( _TIF_SIGPENDING | \ _TIF_NEED_RESCHED | _TIF_RESTORE_SIGMASK)#define _TIF_PERSYSCALL_MASK (_TIF_RESTOREALL|_TIF_NOERROR)
include/asm-sh/thread_info.h renamed from include/asm-sh/thread_info.h~remove-unused-tif_notify_resume-flag +4 -6
@@ -107,18 +107,16 @@ static inline struct thread_info *curren* - other flags in MSW */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ -#define TIF_SIGPENDING 2/* signal pending */ -#define TIF_NEED_RESCHED 3/* rescheduling necessary */ -#define TIF_RESTORE_SIGMASK 4/* restore signal mask in do_signal() */ -#define TIF_SINGLESTEP 5/* singlestepping active */ +#define TIF_SIGPENDING 1/* signal pending */ +#define TIF_NEED_RESCHED 2/* rescheduling necessary */ +#define TIF_RESTORE_SIGMASK 3/* restore signal mask in do_signal() */ +#define TIF_SINGLESTEP 4/* singlestepping active */ #define TIF_USEDFPU 16/* FPU was used by this task this quantum (SMP) */ #define TIF_POLLING_NRFLAG 17/* true if poll_idle() is polling TIF_NEED_RESCHED */ #define TIF_MEMDIE 18#define TIF_FREEZE 19#define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_RESTORE_SIGMASK (1<<TIF_RESTORE_SIGMASK)
include/asm-v850/thread_info.h renamed from include/asm-v850/thread_info.h~remove-unused-tif_notify_resume-flag +4 -6
@@ -77,16 +77,14 @@ struct thread_info {* thread information flag bit numbers */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ -#define TIF_SIGPENDING 2/* signal pending */ -#define TIF_NEED_RESCHED 3/* rescheduling necessary */ -#define TIF_POLLING_NRFLAG 4/* true if poll_idle() is polling +#define TIF_SIGPENDING 1/* signal pending */ +#define TIF_NEED_RESCHED 2/* rescheduling necessary */ +#define TIF_POLLING_NRFLAG 3/* true if poll_idle() is polling TIF_NEED_RESCHED */ -#define TIF_MEMDIE 5 +#define TIF_MEMDIE 4/* as above, but as bit values */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)
include/asm-x86_64/thread_info.h renamed from include/asm-x86_64/thread_info.h~remove-unused-tif_notify_resume-flag +0 -2
@@ -107,7 +107,6 @@ static inline struct thread_info *stack_* Warning: layout of LSW is hardcoded in entry.S */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ #define TIF_SIGPENDING 2/* signal pending */ #define TIF_NEED_RESCHED 3/* rescheduling necessary */ #define TIF_SINGLESTEP 4/* reenable singlestep on user return*/
@@ -126,7 +125,6 @@ static inline struct thread_info *stack_#define TIF_FREEZE 23/* is freezing for suspend */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_SINGLESTEP (1<<TIF_SINGLESTEP)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)
include/asm-xtensa/thread_info.h renamed from include/asm-xtensa/thread_info.h~remove-unused-tif_notify_resume-flag +6 -8
@@ -110,17 +110,15 @@ static inline struct thread_info *curren* - other flags in MSW */ #define TIF_SYSCALL_TRACE 0/* syscall trace active */ -#define TIF_NOTIFY_RESUME 1/* resumption notification requested */ -#define TIF_SIGPENDING 2/* signal pending */ -#define TIF_NEED_RESCHED 3/* rescheduling necessary */ -#define TIF_SINGLESTEP 4/* restore singlestep on return to user mode */ -#define TIF_IRET 5/* return with iret */ -#define TIF_MEMDIE 6 -#define TIF_RESTORE_SIGMASK 7/* restore signal mask in do_signal() */ +#define TIF_SIGPENDING 1/* signal pending */ +#define TIF_NEED_RESCHED 2/* rescheduling necessary */ +#define TIF_SINGLESTEP 3/* restore singlestep on return to user mode */ +#define TIF_IRET 4/* return with iret */ +#define TIF_MEMDIE 5 +#define TIF_RESTORE_SIGMASK 6/* restore signal mask in do_signal() */ #define TIF_POLLING_NRFLAG 16/* true if poll_idle() is polling TIF_NEED_RESCHED */ #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE) -#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)#define _TIF_SINGLESTEP (1<<TIF_SINGLESTEP)
_
Andrew,
Quoted 12 lines · Andrew Morton
Quoted 9 lines · On Mon, 30 Jul 2007 02:30:34 -0700 Stephane Eranian <[email protected]> wrote:
This following patch removes the
TIF_NOTIFY_RESUMEflag forthread_info. It is unused on all but the IA-64 architecture. This is take 2 of this patch. In this version, The definition is removed but no re-numbering of the TIF flags is done to minimize the possibility of errors and reduce the size of the patch.For IA-64, we ran out of low-order bits (first 7 bits). Adding a bit for perfmon would cause important code rescheduling changes in the kernel entry/exit path. Instead, we replace
TIF_NOTIFY_RESUMEwithTIF_PERFMON_WORK. This way we get very close to what the new perfmon code base is doing.
Quoted 7 lines
This has been (painfully) maintained in -mm for quite a long time. I've been waiting for everyone else to merge their stuff so I can get it in without disrupting them. This has now happened.
I think it'd be better to merge the larger patch - it's a bit tidier and more tested, OK?
I appreciate your effort and understand your pain at maintaining this kind of patch. It seems that neither you or myself have received any complaints on this patch so far, so I am fine with you using the older version instead.
Thanks.
--
-Stephane