Skip to contentSkip to conversation

Reduce size of the xterm-linux.xpm image by 12 bytes.

PATCH RESEND Superseded Jesper Juhl 1 participant 1 message Aug 4, 2007 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 Reduce size of the xterm-linux.xpm image by 12 bytes.

Ok, this is a bit silly (but also a little fun) :-)

In Documentation/ we have the xterm-linux.xpm image. Now an XPM image is more or less C code, so I thought it would be fun to look at it like that and put on the CodingStyle and space use glasses.

I made two changes, none of which change the actual image.
1) I removed two lines that just had empty comments.
2) I brought the 'image_name' declaration into line with how we commonly write arrays and pointers.

This saves us an astonishing 12 bytes on the file size ;-) That's a little less data for every future Linux kernel source user to download - that can't be bad.

Ok, ok, so it does have the drawback of being 99,999% churn and you could argue that it'll clutter the git history. So if you don't apply it I won't hate you (too much) ;-)

---

Documentation/xterm-linux.xpm +1 -3
index f469c1a..93cb180 100644
@@ -9,10 +9,8 @@
 /**       Swiss Federal Institute of Technology                             **/
 /**       Central Computing Service                                         **/
 /*****************************************************************************/
-static char * image_name [] = {
-/**/
+static char *image_name[] = {
 "64 38 8 1",
-/**/
 " 	s mask	c none",
 ".	c gray70",
 "X	c gray85",